Git Product home page Git Product logo

bettershulkerboxesrewritten's Introduction

Hello there! I'm Martín

I'm a Computer Science student from Rosario, Argentina.

🌐 Portfolio: www.martinl.dev

⚠ For now, I don't have large projects on here, but you can take a look at these repositories:

🗨 If you would like to see larger projects of mine please contact me

🛠 Skills:

  • Java, Kotlin and Swing
  • Spigot API
  • NodeJS, NPM
  • Spring
  • MyQSL, MongoDB, Redis, InfluxDB
  • Linux, Apache, Nginx, IPTables, UFW, FTP, Certbot and general server administration
  • Docker
  • Kubernetes and Fabric (learning)
  • HTML, CSS, JS, Svelte (intermediate)
  • Jenkins (intermediate)
  • Discord's API, discord.js and JDA

bettershulkerboxesrewritten's People

Contributors

aplini avatar christechs avatar hutch79 avatar ivillager avatar jack444410 avatar kaspiandev avatar kuripasanda avatar level3cache avatar lmartin3 avatar oryfox avatar yuanyuanowo avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

bettershulkerboxesrewritten's Issues

Active duplication exploit

Active duplication glitch using Aristois client.
How to replicate it:

  • Place items in shulker.
  • Enable Inventory++ feature
  • Open shulker box from hand, remove items.
  • Open shulker box from hand remove items again.
  • Disable Inventory++
  • Start process again

The items stay in the shulker after being taken out the first time allowing duplication at a rapid pace.

using vulnerable version

WARNING! You are currently using a vulnerable version of BSB
The plugins disabled the features to prevent exploitation
Please update the plugins as soon as possible!

But i got the newest version so whats the problem

Permission problem

when ever I try to use the plugin it says no permission . so how can I grant permission for the plugin in my aternos server pls help ..

Cannot deserialize field of type java.util.List

[15:37:30] [Server thread/INFO]: [BetterShulkerBoxes] Enabling BetterShulkerBoxes v4.1.0
[15:37:30] [Server thread/INFO]: Warning: Could not deserialize field of type java.util.List correctly!
[15:37:30] [Server thread/INFO]: SAVE CONFIG CALL
[15:37:30] [Server thread/INFO]: [BSB] BetterShulkerBoxes successfully hooked to WorldGuard

Duplication

Steps to duplicate all content of a shulkerbox:

  1. Open a shulkerbox with Rightklicking
  2. Move all items from the shulkerbox to your Inventory or drop it
  3. Right-click the Open shulkerbox in your Inventory, without closing it

Duplication glitch

Duplication bug : open your shulker, take item from it and die without close your shulker. Items took will be drop and be inside the shulker. Reported by zankyo_#4009 on Discord.

add 1.20.2 and 1.20.3 support!! and warning message in console

the best plugin, but please add 1.20.2 and 1.20.3 support!!

[12:51:31 INFO]: WARNING! You are currently using a vulnerable version of Better Shulker Boxes!
The plugin did NOT disable anything because of the configuration
Please update the plugin as soon as possible!

Open and close sounds played twice

As the title says, when opening a shulker box in my inventory the open and close sounds get played twice. Also when changing the open and close sounds it plays the selected one as well as the default one.

It would be nice to be able to turn off the sounds all together.

Feature request - Back to backpack page

I would like to be able to show the backpack page after the player closes the shulker box, rather than just exiting.
This will be handy for players who are looking for items.

Edit: Or can continue to open other shulker boxes in the interface of opening the shulker box.

Shulker contents might be saved to another identical shulkerbox instad of the one the player's actually using

This bug has been already verified. Video

The issue originates here

ItemStack targetItem = stackClone;
boolean found = false;
for (ItemStack is : player.getInventory().getContents()) {
if (is != null && is.equals(stackClone)) {
found = true;
targetItem = is;
break;
}
}

as the plugin looks for identical items to save the shulker box contents into.

The ShulkerOpenData class should store the original item slot the shulker is in.

[BUG] Inventory desync (visual)

When opening a shulker directly from the inventory using a right-click, the client inventory will desync from the server.

This desync lasts until the client manually updates their inventory using any means, including clicking an empty slot in their inventory. Until then, picking up items from the ground and other similar activities will not update the client side inventory. It's like the client inventory is completely frozen.

The same bug does not appear when opening a shulker from the hotbar, unless you then open another shulkers in your inventory.

[Bug Report] Shulkers get mixed up in hotbar

A user reported this video to me: https://youtu.be/WxDvZOCdqF0

Where they fill different shulker boxes in their inventory and after they close the last one, the wrong one in the hotbar was switched.

I'll copy their words exactly, hoping it makes sense to you as well:

first you see that i have 3 shulkers in my hands, if i open it and go with my mouse over the shulkers the items come in the good shulker however if i dont go over the shulker like i do the second time i put items in the shulker it goes into the most left shulker, watch good

The least important thing I've ever heard a complaint about but hey, at least I forwarded it and I can take it off my list and I'll forward them to this issue. If you decline, I'm pretty sure he/we also accept that as it's ridiculously unimportant 😂

[Enhancement] Shulker Enchantments

Posted here as directed on spigot

xisuma made a video about inventoty issues and solutions, in it he outlined an idea to have an enchantment for shulkers that make them even more useful.

Blocks don't however keep NBT data for enchantments, I suspect that to be the same for shulkers, so maybe an item that you put inside them could give them the ability he mentioned in his video on it

https://youtu.be/zJtJ90Vl03M

New feature - Automatic updates

Allow the plugin to update itself, downloading the latest JAR from GitHub. This option should be disabled by default, and users should be able to execute the command /bsb update to download the update.

Feature Request: Compatible with stacked plugins

I'm using the SimpleStack plugin to make empty Shulker box stackable.

When I opened stacked Shulker box in my backpack and put items in, all the Shulker boxes were modified at the same time.

Can you add a feature that prevents opening stacked Shulker box?

[Bug] Item Despawn on Rightklick (In Inventory)

Hey, i have found a way to delete Items if you open your Shulkerbox in the Inventory.

How to reproduce?

  1. Take a Item in your Hand (In your Inv)
  2. Right Klick on a Shulkerbox with the Item in your Hand (Also in your Inv)
  3. Realize that you have found a Trashcan that also can eat up all your Diamonds or tools ^^
2022-10-20.18-00-02.mp4

Shulkerbox Name

The issue here is when you remove the angle brackets (<>) from the inventory-name config the whole config resets. As well as that though, if the shulker box name is coloured the last angle bracket (>) gets changed to the colour and upon inputting something like &r to reset the colours it just makes &r apart of the inventory name.

No Angle Brackets In Config
noanglebrackets

Angle Brackets In Config
anglebrackets

Refactor the configuration parsing system

The configuration parsing system should be refactored to avoid code repetition, in addition of automatically creating fields in the configuration for the missing options.

Feature request - World guard

Description: Add world guard region support, and a configuration option to allow using the plugin only on certain regions, or otherwise, using the plugin anywhere but in those regions.
Suggested by: Halvnaken#5585

Config doesn't work?

The messages in config works fine, however the option to enable / disable things like right click in inventory / right click in hand true / false doesn't work. For me, it just allows players to open it any way even though in the config it says false.

cooldown: 0 # Integer - Time a player has to wait between uses of the plugin's features, set to 0 to disable requires_permission: true # Boolean - Set this to false if you want to allow anyone to use the plugin enable_read_only: false # Boolean - Set this to true if you just want players to be able to preview a shulkerbox's contents enable_right_click_open: false # Boolean - Set this to false if you do not want to allow players to open a shulker by rightclicking enable_inventory_click_open: false # Boolean - Set this to false if you do not want to allow players to open a shulker by shift clicking in their inventories disable_movement_check: false # Boolean - Set this to true if you want players to be able to open shulkerboxes using the plugin while moving

console spam

Error! BSB could not retrieve the changelog
java.net.UnknownHostException: raw.githubusercontent.com
Error! BSB could not retrieve the changelog
java.net.ConnectException: Connection timed out: connect

They appear so frequently that I'd like them to not output logs, or have a config to turn them off.
These domains may not be properly accessible in my region.

Worldguard command allows item dupe

When both BSB and WorldGuard are installed on a server, and a player has the permission to use the right-click feature of BSB and /stack from WorldGuard, any items inside the shulkers are duped into all shulkers in the stack. This includes items already in the shulker, or any items placed inside while they are stacked. This dupe was happening to ALL items in the shulker when we reproduced this. I did not try it with different items in multiple shulkers for fear of a crash, though that may also be possible.

For informative purposes:
BSB version: 3.1.3
Paper version: 1.18.2-335
Worldguard version: 7.0.7

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.