The mysql-json-schema from llorentegerman

mysql-json-schema's People

Stargazers

mysql-json-schema's Issues

Incorrect error handling

On many places you have if (err) {reject(err);} without return, and the code goes on to try to forEach undefined variables or other wrong execution flow.

Error describing tables with a name that is a keyword

I got the following error when trying use this nifty library.
The issue is that I have a table with the name update.
I'm going to create a pull request to fix the issue by wwrapping the table name in `

node_modules\mysql-json-schema\node_modules\mysql\lib\protocol\Parser.js:80
        throw err; // Rethrow non-MySQL errors
        ^

TypeError: Cannot read property 'forEach' of undefined
    at Query._callback (node_modules\mysql-json-schema\dist\mysql.js:65:17)
    at Query.Sequence.end (node_modules\mysql-json-schema\node_modules\mysql\lib\protocol\sequences\Sequence.js:88:24)
    at Query.ErrorPacket (node_modules\mysql-json-schema\node_modules\mysql\lib\protocol\sequences\Query.js:90:8)
    at Protocol._parsePacket (node_modules\mysql-json-schema\node_modules\mysql\lib\protocol\Protocol.js:279:23)
    at Parser.write (node_modules\mysql-json-schema\node_modules\mysql\lib\protocol\Parser.js:76:12)
    at Protocol.write (node_modules\mysql-json-schema\node_modules\mysql\lib\protocol\Protocol.js:39:16)
    at Socket.<anonymous> (node_modules\mysql-json-schema\node_modules\mysql\lib\Connection.js:103:28)
    at emitOne (events.js:115:13)
    at Socket.emit (events.js:210:7)
    at addChunk (_stream_readable.js:266:12)
    at readableAddChunk (_stream_readable.js:253:11)
    at Socket.Readable.push (_stream_readable.js:211:10)
    at TCP.onread (net.js:585:20)

Process finished with exit code 1

does not generate JSON schema, but simply JSON

Minor issue, but I believe the name of this repo is misleading, as it does not generate a JSON schema (http://json-schema.org/) but simply proprietary JSON string

Recommend Projects