GetFirstRef with form type filter ignores deleted references about xobse HOT 4 CLOSED

Ok I added an optional parameter for including deleted references (1 including, 0 excluding).

Also added filter type 90 to only return deleted references.

Need extensive test.
@Forlini91 can you or lubronbrons test if this solve the need of your tests cases?
Please report.

from xobse.

Ok, the command seems to work as expected, but I have noticed something in the code and in the tests:
In Commands_MiscReferences.cpp:

class RefMatcherActor
{
public:
    bool  m_includeDeleted;
    RefMatcherActor(bool includeDeleted) : m_includeDeleted(includeDeleted)
        { }

    bool Accept(const TESObjectREFR* refr)
    {
        if (refr->IsDeleted() && !m_includeDeleted)
            return false;
        else if (refr->baseForm->typeID == kFormType_Creature)
            return true;
        else if (refr->baseForm->typeID == kFormType_NPC && refr->baseForm->refID != 7) //exclude the player
            return true;
        else
            return false;
    }
};

specifically:
... && refr->baseForm->refID != 7)
This filter is only applied when you use the form filter for actors. When you don't use any filter, the player reference is included. Is this intended?

from xobse.

You should ask to the one who originally wrote the code.I really don't know.
I'm closing the issue

from xobse.

Close in c8386b1

from xobse.