lkellar / shelf Goto Github PK

If a user puts in a really high number of days to expire (like 99999999), python overflows and fails.

Probably the current thing to do here is to just set it to whatever the max is, and put a notice on the save screen

[Wed May 13 03:55:50.961870 2020] [wsgi:error] [pid 20001] [remote 192.168.0.1:55489]   File "/var/www/shelf/shelf/db.py", line 42, in insert
[Wed May 13 03:55:50.961902 2020] [wsgi:error] [pid 20001] [remote 192.168.0.1:55489]     expiry_date = utc_date + timedelta(days=ttl_days)
[Wed May 13 03:55:50.961934 2020] [wsgi:error] [pid 20001] [remote 192.168.0.1:55489] OverflowError: Python int too large to convert to C int

Allow the user to, via url query or something, automatically go to the URL if the text of the shelf if a url.

I've thought about letting the setter do it, but then the setter could tell the getter (assuming it's two different people), to go to it, and it's something terrible. One might say, getter beware, but I don't know if that's an attitude I'd like to have.

Unless there's a good way to do it that let's setter decide to redirect (without risk to the getter, either in bad content, or even malicious attacks), I'll probably go with allowing a user to do it. Maybe even just having another button appear on the page to instantly go to the link (or just hyperlink it too, but we've gotta be careful on that)