liviuschera / noctis Goto Github PK

Since 1.43, VSCode themes can take advantage of semantic highlighting.

Every theme controls whether semantic tokens are enabled. So far, only built-in themes have it enabled and I filed this issue to ask you to opt-in for the Noctis themes as well.

Adoption is easy and there are new cool styling possibilities.

To turn on semantic highlighting for a theme, all you have to do is put
"semanticHighlighting": true
in the theme's definition file.

There's a good chance that no further change to the theme is needed (thanks to a default mapping from semantic tokens to TextMate scopes (if not, I'd be interested to know, so I can improve the defaults further)).

But, more interestingly, themes can tune and go wild by defining new styling rules against the semantic tokens:

"semanticTokenColors": {
    "variable.readonly": "#ff0000", 
    "parameter": { "fontStyle": "underline" },
    "*.declaration:java": { "fontStyle": "bold" }
} 

Check out our Semantic Highlighting Wiki and the Semantic Highlighting Guide for more details and feel free to ping me in this issue if I can help.

Thanks for the great work and looking forward to semantic highlighting in your theme.

First of all, thanks for making this, great work.

However, if I may propose one thing, a little more contrast for the orange text on “Noctis Lux”.

When editing a Shell Script, like pictured below, all shell commands get colored orange, and on an orange background, that gets more than a little hard to read in my opinion. I think this could be helped, if the orange was just a little darker, so it would stand out from the background.

IMO, it's a little bit brighter than other elements.

Obsolete asciidoctor package, it has been replaced by asciidoctor.asciidoctor-vscode: https://marketplace.visualstudio.com/items?itemName=asciidoctor.asciidoctor-vscode

Hi @liviuschera,

This is one of the awesome 👍🏻 vscode theme I've ever seen 👀 in my life. I want one more favor to make Notics iTem theme.

I'm ready to contribute to this.

Thanks a lot.

Hi. Thanks for this wonderful theme. It looks really amazing.

I'be been trying the new color scheme, Uva, and it looks very nice as well.
The only issue I've found so far is about the suggestion popup.

As you can see from the image, it's hard to distinguish which item is highlighted at first sight.

It would be better to have it a bit darker.
Thanks.

I could not find the Noctis Hibernus color scheme hex value any where

i want them because i want to apply it to my st treminal

Not sure if it's even possible in VSCode, but it'd be nice if there was a gradual saturation of color for a list item's text depending on how far a list item is nested in Markdown. Currently, the first-level item's color is the same as any other indentation level, which can make some of my markdown notes seem very...same-y.

For example, this:

- Lorem ipsum dolor sit amet, consectetur adipiscing elit.
  - Donec ac nisi laoreet, vestibulum nulla a, condimentum enim.
  - Duis dignissim nulla in molestie maximus.
      - Nam aliquam odio vitae mauris feugiat, sit amet lacinia elit ullamcorper.
      - In tincidunt ipsum eu malesuada viverra.
  - Ut eleifend lectus id elit commodo, at lobortis ipsum feugiat.
  - Etiam sodales metus at consequat dignissim.
  - Etiam varius magna non finibus vulputate.
- Ut id enim ultrices, consequat turpis eu, vehicula augue.
- Donec commodo metus et dolor pharetra tristique.
- Proin venenatis erat laoreet, mollis justo in, auctor ipsum.
  - Phasellus eget urna facilisis, egestas tortor et, venenatis velit.
  - Nunc ut turpis dapibus, dapibus magna ac, blandit felis.
    - Mauris vulputate lorem eget scelerisque tincidunt.
      - Pellentesque id risus vestibulum, aliquam ligula et, lacinia tellus.
      - Vestibulum maximus massa sit amet nulla imperdiet, vel accumsan nulla ultrices.

Looks like this (in Noctis Obscuro):

While I could understand it if maybe some prefer for all of this text to look the same, I for one would love it if there was some kind of visual difference between indentation levels. Is it possible to either add some progressive saturation of list item text in markdown, or maybe have some alternating styling so that one can more clearly denote one line from another? I keep coming back to desaturation because I think it'd look pretty neat with the way I take notes now.

Further, I noticed it's hard to read the documentation comments. Here is an example:

It's a C# file it that matters. Please consider bumping the color!

Fenced blocks have many roles in markdown:

1. verbatim text
2. code blocks
3. a generalization of the above in pandoc
4. a translation of reStructuredText roles in MyST markdown
5. probably many others

Most Noctis themes treat these blocks almost as comments, in that they are shown in a dimmed down fashion, except when a language is specified (then the syntax highlighting for the language is used, of course). But there is no reason to assume that these blocks are less important than other contents or shouldn't divert attention as much as other contents. This assumption is unsafe even for the vanilla verbatim block.

I think that deemphasizing these blocks is an undesirable quirk of the Noctis themes.

Issue Type: Bug

Currently there are keyword.control.import { "fontStyle": "italic" } and keyword.control.from { "fontStyle": "italic" }, it would be nice to also have keyword.control.type { "fontStyle": "italic" } for the new import type syntax in TS3.8. I could configure in "editor.tokenColorCustomizations", but that's not ideal as I'd need a seperate entry for each variant.

I'm on the VS Code team and I love the theme btw!

Extension version: 10.24.0
VS Code version: Code - Insiders 1.42.0-insider (33c79d5ad447956814a2a3658029dffb9e28bae6, 2020-01-15T08:53:57.100Z)
OS version: Darwin x64 18.7.0

Hi, i want to know the name of the font you used for the image in examples! its really cool!

Which font are you using in your preview images in README.md ? Love the font almost as I love the theme!

I see this can be used with VScode, but can we use it with IntelliJ IDE?

I noticed that Noctis and Noctis Sereno have slightly different colour / tone to the background in the terminal and sidebar area, whereas Noctis Azureus and Obscuro don't. Just wondering if this could be changed so that those two variants have slightly different backgrounds to those areas too?

I love this theme. However the color matching for terminal is a little less harmonic. Above is a comparison: left noctis, right nord. Nord's terminal is better imho.

About Syntax.

First of all th10 for an awesome theme! 🎆
I don't understand why the color syntax for all languages that I use (i.e. - C#, JS, TS, AHK, C++, C, Java, Html, CSS, Python...) is the same?
Is there a wat to implement for ich language his own different ⚡Syntax Highlighting⚡ ?

Regards! 👍✌️

Any plans to export these themes over to https://hyper.is/

There is a default setting in VS Code called Occurrences Highlight that will highlight all occurrences of a word when the caret is touching it. This highlighting is not visible in Noctis Bordo, but it works with all other themes.

I use an extension called Bracket Pair Colorizer 2 to change the colors of nested brackets/parentheses/etc., and it seems like the maintainer of that extension chooses colors that only look good/are legible in dark themes. I'm trying to use Noctis Lux, and while I don't want to lose the utility of Bracket Pair Colorizer, I don't want to change the settings to colors that the maintainer of this colorscheme would think would clash with the color palette 😅

Do you have any suggestions for a good set of colors for this extension for Noctis Lux? For reference, these colors are the default (and don't seem to adjust based on the color scheme you have chosen - it also accepts RGBA and hex codes):

"bracket-pair-colorizer-2.colors": [
    "Gold",
    "Orchid",
    "LightSkyBlue"
]

Thanks!

I love this theme very much, but get one issue after install it. I can't set Noctis theme, file not found, i think because the file name with uppercase. After rename it from Noctis.json to noctis.json, now i can use it.

Thank you if this issue fixed on next update

Recently, VS team made it easy to port VS Code themes - https://devblogs.microsoft.com/visualstudio/vs-code-themes-in-vs/

Please publish as VS themes as well

First, thanks so much for this theme—I love it.

When debugging, I've noticed that the color of the text in the status bar becomes barely legible. Perhaps the alpha for statusBar.debuggingForeground should be adjusted a bit? For now, I've overridden the value to #e06e968c which helps a lot.

Before

After

I absolutely love the theme but the darker purple numbers on dark themes can be a bit hard to read, please consider changing this color to something else.

Example:
https://i.imgur.com/x2QjSSl.png

It is harder to read these numbers while glancing over them compared to the rest due to the background being a bit darker too.

On the debug console, when a row is highlighted, selected text should get a different background color
Here I have selected Access-Control-Allow-Credentials but when the row is highlighted, can't see which part of the text is selected.

Been using Noctis Azureus for a while and love the colors. I find that on the diff view colors are not so prominent and and not easy to identify changes. For example:

VS say monokai:

Please consider changing the colors to make it easy to detect changes.

Firstly thanks so much for such a great theme, best vscode theme I've ever used. Uninstalled all others already. 👍👍👍

Thing is, in light Noctis themes(Lux and Hibernus), when current focused tab is hovered, a 1px #fff border appears on the bottom of it.

It felt a little, little bit mismatching to me, and I didn't found similar border in dark Nocits themes. (If I'm to pick a tiny, tiny flaw from the epic theme, this would be it.) 🤔 Anyway, I haven't got much UI experience, probably it's by design? Please let me know. 😁

Hi, maybe this is intended to be so, then ignore me.

There is this 1px highlight between the editor and the panel:

The reasons I find to think it's weird and maybe not as intended are:

1. It's usually not in other themes but it's in all Noctis dark ones.
2. It goes away when I'm dragging.
3. Even in Noctis themes, other separators between windows are not highlighted (but darkened).
4. Looks a little glossy for Noctis.

Anyway, your themes are the best I've yet seen.

Hi! 🙂

Sorry, but Theme Color docs sucks.

NOTE:
I've already googled (3 days) and can't find info about a few features.

I don't understand how it works? Maybe it works with some kind of extension?
If you can please provide 🎬 screencast or 🖼️ screenshot.

ℹ️ Features for which clarification is needed:

📑 Base colors:

descriptionForeground

📑 Text Colors:

textBlockQuote.border
textCodeBlock.background
textPreformat.foreground

📑 Input control:

inputValidation.errorBackground
inputValidation.errorForeground
inputValidation.infoBackground
inputValidation.infoForeground
inputValidation.infoBorder
inputValidation.warningBackground
inputValidation.warningForeground
inputValidation.warningBorder

📑 Lists and trees:

list.inactiveFocusBackground

📑 Activity Bar:

sideBar.dropBackground

📑 MiniMap:

minimapGutter.addedBackground
minimapGutter.modifiedBackground
minimapGutter.deletedBackground

📑 Editor Groups & Tabs:

tab.activeModifiedBorder
tab.inactiveModifiedBorder
tab.unfocusedActiveModifiedBorder
tab.unfocusedInactiveModifiedBorder
editorPane.background

📑 Editor colors:

editorCursor.background
editor.findRangeHighlightBackground
editor.findRangeHighlightBorder
searchEditor.findMatchBackground
searchEditor.findMatchBorder
editor.symbolHighlightBackground
editor.symbolHighlightBorder

📑 Overview ruler:

editorOverviewRuler.rangeHighlightForeground
editorOverviewRuler.selectionHighlightForeground
editorOverviewRuler.wordHighlightForeground
editorOverviewRuler.wordHighlightStrongForeground
editorOverviewRuler.modifiedForeground
editorOverviewRuler.addedForeground
editorOverviewRuler.deletedForeground
editorOverviewRuler.errorForeground
editorOverviewRuler.warningForeground
editorOverviewRuler.infoForeground
editorOverviewRuler.bracketMatchForeground

📑 Errors and warnings:

editorWarning.foreground
editorWarning.border
editorHint.foreground
editorHint.border
problemsWarningIcon.foreground

📑 The gutter contains the glyph margins and the line numbers:

editorGutter.commentRangeForeground

📑 Editor widget colors:

editorMarkerNavigation.background
editorMarkerNavigationError.background
editorMarkerNavigationWarning.background
editorMarkerNavigationInfo.background

📑 Panel colors:

panel.dropBackground
panelInput.border

📑 Notification colors:

notificationLink.foreground

📑 Debug:

editor.stackFrameHighlightBackground
editor.focusedStackFrameHighlightBackground

I think it's about - Debug > CALL STACK
...but don't know the idea where are these features disappear? 😯

📑 Welcome page:

walkThrough.embeddedEditorBackground

📑 Settings Editor colors:

settings.dropdownListBorder

📑 Snippets:

editor.snippetFinalTabstopHighlightBackground
editor.snippetFinalTabstopHighlightBorder

ℹ️ System:
Microsoft Windows 10 Enterprise 2016 LTSB, 64x
Version: 10.0.14393.2273 (Win10 RS1)
«VS Code» is last updated.

Best regards❗ ✌️

Noctis seems like it might be overriding VS Code's default syntax highlight for Markdown diff code blocks.

Example screenshots and a bit more explanation here.

Very minor issue but it started to bug me as the tabs look like they are floating and not attached to the editor window.

It doesn't happen with other themes i tested and i could find a fix for it myself.

This is a cute theme! Would be super great if LaTeX is on the language list

Hi I love your theme!

The only issue is that the color of the numbers/booleans don't have enough contrast. Could you please change it to a brighter purple so that it pops out of the page more or something? Thanks!

Hi! I'm from the VS Code team and have tested whether Noctis can run in the different extension host setups VS Code currently supports. I've found that the current definition of extensionKind for your extension is too restrictive.

The extension has the extensionKind set to ["ui"]: https://github.com/liviuschera/noctis/blob/master/package.json#L11.

This defines that the extension can only run in the VS Code desktop extension host. However, this extension can also run on the workspace extension host (which is used for remote scenarios).

Thus, the best practice would be to change the extensionKind to ["ui", "workspace"].

We have a way to customize the extensionKind from an extension in the VS Code core. Given the popularity of your extension I will do this in the meantime.

Please let me know if you have any questions - I'm happy to help clarify anything. Thank you!

Looking at an SCSS file and search result highlight looks like this:

Makes it hard to read. Please change the color tint.

These themes are really awesome!! Thank you!

Attempting to install the noctis theme extension leads to the following message:

"Cannot install 'Noctis' because this extension has defined that it cannot run on the remote server."

I would really love more support for italics in the syntax highlighting similar to Lucy, where const, import, using, and params or types in params (typescript) are italicized. I have used Lucy for a bit, but I prefer Noctis Minimus.

Perhaps replace the bold parts with italicized...anyway, here's hoping for some more italics 🍻

Thanks!

OS : macOS High Sierra Version 10.13.6

VS Code version : Version 1.27.2 (1.27.2)

Hi. I use Noctis Uva. When run diff using Noctis I have ugly border by lines. Screenshot:

I don't change any settings with UI and on other themes(for example built in themes) haven't this problem.

Was wondering how do you get the formatting of the fonts to look similar to the screenshot pictures? I already have the font but just can't get the formatting to be the same.

Thanks

Noctis is really nice and beautiful. I use it in vscode. I wanna change some colors of codes in golang. I found source.go in settings.json can influence specific types of golang displays. But struct declarations are no exactly handling.

What can I do could it display the color I expect.

Hi

First of all, thanks for the cool theme. I'm using it to look at C# code, and I notice that the italics behave a bit weird.

1. It seems that member fields are supposed to be italics. But nested types/classes are as well, which looks weird. In this example Volume is not a member, but a classname, just like Collection.
   
2. Some keywords are italic, while others are not. What is the rationale behind this?
   
3. Indexed variables are italics. Why is this? It looks a little weird, especially since often the indexed variable declaration isn't italic at all:
   

For those of us using VsCodium or Eclipse Theia, it would be great to have this theme available on https://open-vsx.org/

HowTo available here:

https://github.com/eclipse/openvsx/wiki

I think the green color contrast should be increased a little bit?

I noticed there is a difference in color of property in javascript, like the image below

Big fan! This issue seems to happen across all Noctis themes:

When long typings are made multiline (in my case from prettier), Noctis loses correct syntax highlighting. I've included an example here, where when the code is all on one line, syntax highlighting is correct, but when formatted to miltiline, Noctis struggles.

Request/Suggestion:
Not sure if you only use VScode, but would love to see these beautiful themes you've created ported for JetBrain IDE's like PyCharm/GoLand/IntellliJ. I like to keep my themes consistent between editors and I love this VScode theme.

Would also possibly love to see this theme for iTerm2 or oh-my-zsh.