Comments (5)
The issue were with Symfony Process
class. It hasn't a return type so everytime PHPUnit invoked (with SF < 6) the method, it used to return null
. Now as bool
is instead used as return type, we should've add false
(as correctly done).
What I should think (but that's not related to SF 6 support) is if tests are still valid as (maybe? probably?) we were missing a point when not declaring explicitly the last false
return.
from fastest.
Please, open a PR. I'll merge it as long as test are green.
Cheers.
from fastest.
Ok. Will try to make some time for this later this week!
from fastest.
I tried my hand at this today. When just adding symfony 6 components as depencies a couple of tests fail. I managed to fix the tests, but I'm not sure why they failed, or why they are working now:
https://github.com/Grldk/fastest/tree/add-symfony-6
As far as I can see, the symfony upgrade from 5 to 6 does not contain any relevant breaking changes. But after upgrading three tests fail because willReturnOnConsecutiveCalls
for isTerminated()
does not get enough values. Adding an extra false
makes the test succeed again.
I'm not very familiar with the way mocking in PHPUnit works. isTerminated()
is not getting called more often in Symfony 6 (as far as I can see). So I'm not sure what's happening there.
Apart from the test failures the package actually seems to be working as expected after the Symfony component upgrade btw. (as far as my dev env is concerned at least...)
from fastest.
Please, open a pull request in order to facilitate my review.
Thanks.
from fastest.
Related Issues (20)
- support of PHP 7.3 HOT 7
- Test names are not aligned with -vv when some tests take minutes and other seconds HOT 4
- Behat tests never end HOT 10
- use input list in inverse mode HOT 5
- generating the list of tests from a PHPUnit XML file ignores the <groups> tag
- Always a false positive HOT 1
- symfony 5 HOT 5
- Incompatible with laravel HOT 3
- before option not working anymore HOT 10
- How to run two commands before tests? HOT 1
- Not compatible with PHPUnit 9+ HOT 2
- Switch to GitHub actions
- Add support for MongoDB official client HOT 4
- Failure on several issues HOT 4
- Latest Symfony Process make fastest screaming with PHP Warning: Array to string conversion HOT 19
- Symfony 5.4 phpunit 9.5 with forceCoversAnnotation and beStrictAboutCoversAnnotation giving random failures HOT 2
- Support for DATABASE_URL HOT 8
- Question about database isolation HOT 3
- Couldn't make it run with WordPress HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fastest.