Update symfony dependencies to ^6.0 about fastest HOT 5 CLOSED

The issue were with Symfony Process class. It hasn't a return type so everytime PHPUnit invoked (with SF < 6) the method, it used to return null . Now as bool is instead used as return type, we should've add false (as correctly done).
What I should think (but that's not related to SF 6 support) is if tests are still valid as (maybe? probably?) we were missing a point when not declaring explicitly the last false return.

from fastest.

Please, open a PR. I'll merge it as long as test are green.
Cheers.

from fastest.

Ok. Will try to make some time for this later this week!

from fastest.

@DonCallisto

I tried my hand at this today. When just adding symfony 6 components as depencies a couple of tests fail. I managed to fix the tests, but I'm not sure why they failed, or why they are working now:

https://github.com/Grldk/fastest/tree/add-symfony-6

As far as I can see, the symfony upgrade from 5 to 6 does not contain any relevant breaking changes. But after upgrading three tests fail because willReturnOnConsecutiveCalls for isTerminated() does not get enough values. Adding an extra false makes the test succeed again.

I'm not very familiar with the way mocking in PHPUnit works. isTerminated() is not getting called more often in Symfony 6 (as far as I can see). So I'm not sure what's happening there.

Apart from the test failures the package actually seems to be working as expected after the Symfony component upgrade btw. (as far as my dev env is concerned at least...)

from fastest.

Please, open a pull request in order to facilitate my review.
Thanks.

from fastest.