Comments (10)
@matlar83 can you try and see if https://github.com/liuggio/fastest/tree/input_args_parsing fix this?
I've only fixed args parsing, the "older" issues with --before
should not be trackled here.
Let me know please.
Thank you.
from fastest.
@DonCallisto, it does not fix it, according to my tests.
And it seems not to run the "execute" command anymore.
Performed test:
> rm -f before.txt test.txt
> ls | fastest --before="echo ciao >> before.txt" "echo test {} >> test.txt"
> ls -l before.txt test.txt
ls: cannot access 'before.txt': No such file or directory
ls: cannot access 'test.txt': No such file or directory
Can you reproduce it?
Thank you
from fastest.
I confirm, -b/--before isn't working
from fastest.
I was able to reproduce.
With my fix, I'm not using the StringInput
the right way: as a matter of fact, it expects to match a certain input, so a first try is to copy/paste the function that parse input string directly in fastest but with no luck.
I'm not sure why the command is not interpreted in the right way.
Sadly last week, I had no time to investigate deeper.
I'll try this week but I really don't know if I'll have time.
If someone would like to help (with suggestions I gave before) is welcome to do so.
from fastest.
@matlar83 @Brightside56 sorry for the long delay, I was quite busy.
I've updated my fork https://github.com/liuggio/fastest/tree/input_args_parsing
Could you give it a shot and let me know if it's ok for your projects?
Mine tests were fine.
from fastest.
If no one will give a feedback, I'm gonna merge the PR within this week and release a new tagged version in order to let everyone use new code.
I'm pretty confident it's gonna be fine but a double check would be great.
Thanks in advance @matlar83, @Brightside56 and everyone will check this.
from fastest.
Sorry @DonCallisto, I don't have time to test it :-(
I hope I will have in the next weeks, but I'm not sure
from fastest.
Don't worry. I've used your test cases as guidelines and it works like a charm, so I'm pretty sure we won't have surprise here.
After all, this taken me 4 months, it won't be a problem if you can't try it.
from fastest.
I've released v1.7.1 https://github.com/liuggio/fastest/releases/tag/v1.7.1
It should fix the bug.
from fastest.
Gonna close it for the moment.
Feel free to comment if something's wrong and I'll reopen it.
from fastest.
Related Issues (20)
- support of PHP 7.3 HOT 7
- Test names are not aligned with -vv when some tests take minutes and other seconds HOT 4
- Behat tests never end HOT 10
- use input list in inverse mode HOT 5
- generating the list of tests from a PHPUnit XML file ignores the <groups> tag
- Always a false positive HOT 1
- symfony 5 HOT 5
- Incompatible with laravel HOT 3
- How to run two commands before tests? HOT 1
- Not compatible with PHPUnit 9+ HOT 2
- Switch to GitHub actions
- Add support for MongoDB official client HOT 4
- Failure on several issues HOT 4
- Latest Symfony Process make fastest screaming with PHP Warning: Array to string conversion HOT 19
- Symfony 5.4 phpunit 9.5 with forceCoversAnnotation and beStrictAboutCoversAnnotation giving random failures HOT 2
- Support for DATABASE_URL HOT 8
- Question about database isolation HOT 3
- Update symfony dependencies to ^6.0 HOT 5
- Couldn't make it run with WordPress HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fastest.