littensy / reflex Goto Github PK

Currently, the broadcaster state-getter calls getState on every producer in the map. This is prone to bugs since the combined producer does not update the state of the individual producers!

Pass the root producer to Broadcaster, and filter out non-shared state when a player retrieves state.

Write tests to make sure this bug doesn't come back.

It's possible to allow an action to return a Promise to defer a state update. Actions run independently from one another, and they get called directly, so it should be safe to allow it

But why do some state management libraries allow async actions while others don't?

Combine subscribe and observe into a single function with overloads for both cases.

producer.subscribe(callback)
producer.subscribe(selector, callback)

Look into integrating a Luau analyzer and run-in-roblox into the CI process

When changes are repeatedly made in a Heartbeat or RenderStepped connection, the subscribe() method doesn't detect the changes.

This should be straightforward to implement and simplifies some functions.

We might be able to define multiple overloads with:

local arguments = select("#", ...)
local selector, predicate, listener

if arguments == 1 then
  listener = ...
elseif arguments == 2 then
  selector, listener = ...
else
  selector, predicate, listener = ...
end

I ran a benchmark, and combineProducers is over 100% slower than manually combining state in a single producer. Optimizations can be made to reduce overhead from wrapping producers.

Release this package for Luau on Wally.

Imports can be resolved with a function that checks Reflex's parent for a package of the same name and a possible src or out entry point.

Promise will need to be re-exported and attempt to import any installed Promise module as a dependency first.

Reflex should throw more descriptive errors for oversights like:

• Mutating state, enforced by deep-freezing
• Type errors in parameters or return values
• Selectors returning a different value for the same state input
• observe receiving a record of objects with no discriminator
• Invalid middleware functions
• Broadcasters sending invalid data types (i.e. non-string keys)

I should make one with Moonwave