lirwin3007 / cs261-coursework-backend Goto Github PK

Just a question:
What are we going to display on the front end for companies? At the minute the company code is passed through - do we want to display this, or would we want to use this to look up the company name and display that instead.

Or even display both like:

Would it be possible to have currency symbols passed through along with the currency code?

For example, in derivative-management/get-derivative, we pass back

{
  "derivative": {
    ...
    "currency_code": "USD",
    ...
  }
}

Would we be able to pass back:

{
  "derivative": {
    ...
    "currency_code": "USD",
    "currency_symbol": "$"
    ...
  }
}

This would just make it easier for me to display in the front end 😄

Quick question - what currency is the strike price in? The notional currency, or the underlying currency?

How does the pagination work on index derivatives? Am I passing in the page number correctly?

Please could we pass back the reports keyed by date. This is so that I know where to display them whilst they are loading 😃

It would be good to be in a format similar to this:

{
    "2020-01-01": [
        1,
        2
    ],
    "2020-01-02": [
        3
    ]
}

Any chance we could adjust the index reports endpoint so we passing the date through GET parameters instead of in the URL?
There's nothing particularly wrong with passing it through the URL, but it can mess a bit with some browsers caching.

An example of using get parameters is in @jdjfisher's index-derivatives:

@DerivativeBlueprint.route('/index-derivatives')
def indexDerivatives():
    # Retreive form
    form_dict = request.form.to_dict()

    # Determine page parameters
    page_size = form_dict.get('page_size') or 15
    page_number = form_dict.get('page_number') or 0

Which would result in a request similar to /index-derivatives?page_size=10&page_number=1

Two new branches have been created, validation and validate. What's happening here? We need to sort this out.