Git Product home page Git Product logo

swade-tools's People

Contributors

arnok13 avatar bloy avatar blueskyblackbird avatar bnp800 avatar engaric avatar forjasalvaje avatar inxaos avatar leratierbretonnien avatar lipefl avatar parvusdomus avatar softycat avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

swade-tools's Issues

Allow expanding items in quick-actions

Right now this module seems to override the click on quick action names. In the base system that click would expand the entry to show additional information. I think it would be nice to still be able to do that.

Maybe just override click interactions for places that toggle a roll in the base system?

Maybe also keep an eye on this issue I posted a few days ago for the SWADE system, it might be interesting in this regard too: https://gitlab.com/peginc/swade/-/issues/167

Getting "Error: This is not a registered game setting"

As the title says, i get this error anytime i try to make a skill roll for a weapon.

FVT: v0.7.9
SWADE: v0.16.2

Uncaught Error: Error: This is not a registered game setting
at Dialog.submit (foundry.js:13153)
at Dialog._onClickButton (foundry.js:13112)
at HTMLButtonElement.dispatch (jquery.min.js:2)
at HTMLButtonElement.v.handle (jquery.min.js:2)

Strength modifier not included in damage rolls

Environment Details

Foundry VTT Version: 0.7.9
Operating System: OSX
How Are You Using Foundry: Chrome
Modules Enabled?: yes
SWADE Tools v1.3.5

Issue Description

When rolling a damage formula for a weapon that uses "@str", the strength modifier is ignored.

Relevant logs and/or screenshots

Screen Shot 2021-05-12 at 1 48 06 PM
The first entry is a roll from the character sheet using only the SWADE system (no modules).
The second entry is a roll from the character sheet using the card generated by SWADE tools.
In both cases, the same weapon is used with a damage value of "@str+d4"

Possible Solution and/or Root Cause

It looks like the damage formula is just taking the strength die value, and not the strength modifier.
Likely caused right here where it replaces strength with a die, but not the additional modifier.

Ações extras

Boa noite,

Teria a possibilidade de "puxar" as ações extras dos itens e poderes direto do chat? vou postar as imagens para ver se me faço entender
Captura de tela 2021-05-19 233408
Captura de tela 2021-05-19 233438

Chat text

Sorry bothering you, it's me again,
but the text of the chat cards, has no paragraphs, and ends up sticking together as in the image, but after a chat refresh (restart of foundry or a change of setting) the formatting of the text is corrected.
image

Vulnerable

When the objetive of an attack has the vulnerable status applied, the difficulty to hit is not reduced.

PP deducted from total with PP tracking disabled.

When the option to track power points is disabled at least 1 PP is spent when doing a power roll either when it suceeds or fails. The expected behaviour is that no PP is spent with that option disabled.

Handling of Wild Attack and associated Vulnerable status

Is there anyway to handle Wild Attack (p.109) and it's associated Vulnerable status which is until the end of the characters next turn ?

The automatic removal of Vulnerable is happening at the end of the characters current turn, so we have to remember to re-apply the Vulnerable status

Ammo from inventory not working

Hey ho.
I've noticed with SWADE-Tools installed, reloading from inventory does not work.
Another user noticed the same issue and received: "Uncaught Error: Error: This is not a registered game setting" (last updated yesterday)

Thanks!

Roll dialog: Add indication what type of action a button represents

The two default buttons say "Shooting" (or Fighting etc.) while the damage button say "Damage". In addition, there is another button for each extra Action. These extra actions can be of type "damage" or "skill".

Some weapons (like the official SWADE "Streetsweeper Shotgun") have two actions with the same name but different type (in this example we have "Slug" twice, once as damage and once as skill action). Right now both buttons look the same / have the same label.

image

I have 2 possible ideas for this:

  1. Add the type to the button label (for example: "Shooting: Slug" or "Slug (Shooting)") or add an appropriate icon instead
  2. Like the default buttons, display the additional actions in two columns, one for skills and one for damage.

Descrição do item/poder na rolagem

Gostaria de saber se é possível fazer, assim como na rolagem default do sistema, que apareça a descrição cl do item/poder na rolagem.
default
default
default

SWADE Tools
sistema

Hellfrost Land of Fire has Fast Regeneration Edge/Special Ability

in Hellfrost/Land of Fire, there is a Special Ability called Fast Regeneration that among other things adds +2 to remove Shaken that stacks with other Edges/Special Attributes that also add +2 to remove Shaken like Undead or Hardy. I have modified my local copy of the code to handle this for my Land of Fire world but don't know if it could/should be included in the basic SWADE Tools.

Joker's Wild not getting disabled?

When using the 'Hard Choices' setting rule, even with 'Disable Joker's Wild' clicked, Bennies still seem to be given automatically (tested with all other modules removed).

Double charging Power Points

When casting a power, SWADE Tools is charging power points when you cast the spell, then again when you click on damage in the chat log or from the character sheet.

Wait for Dice So Nice rolls to be finished

I noticed at least one roll (the automatic roll to remove shaken) which does not wait for the dice so nice roll to be finished before posting / applying the result. Attack and damage rolls seem to behave as expected.

Problem using with dice so nice module.

When using swade tools 1.2.5 with the module dice so nice 3.3.1 (latest version) i can't use the reroll with a bennie button or the soak damage button, when i click any of thoose the bennie is spent but nothing else happen.
The problem has been replicated by 3 users afaik.

Cannot read property '0' of undefined

Just installed the newest 1.2.3 version that fixes the DSN issue, but now I'm getting this one:

Uncaught Error: TypeError: Cannot read property '0' of undefined
at Dialog.submit (foundry.js:13153)
at Dialog._onClickButton (foundry.js:13112)
at HTMLButtonElement.dispatch (jquery.min.js:2)
at HTMLButtonElement.v.handle (jquery.min.js:2)

Whenever I do a skill roll from a weapon equipped in a NPC sheet. From PC sheets it works and the damage rolls from a weapon in the NPC sheet work too.

Damage with a Raise

When you get a raise in the attack roll and click on the raise message in the chat card to roll damage, the extra d6 is not being rolled.

Blast applied same damage to all targets

Environment Details

  • Foundry VTT Version: 0.7.9
  • Operating System: Windows
  • How Are You Using Foundry: both Native Application (Electron) and Edge
  • Modules Enabled?: yes
    SWADE Core Rules v1.0.4
    SWADE Tools v1.3.5
    Easy Target v2.10

Issue Description

Using the Blast Damage button with two targets selected. Clicking Damage roll one set of dice (in this case 2d6) and applies the same damage to ALL targets.

Relevant logs and/or screenshots

fvtt-blast-damage

Possible Solution and/or Root Cause

N/A

Maestro + Item Track = double sound

When a weapon is linked with Maestro (using item track), either if you make the hit check or if you roll damage, the sound activates, causing a double sound in a row.
But it's also true that if someone doesn't need to roll the ability to hit, the sound should sound the same by just rolling damage.
Maybe it could be disabled when using SWADE Tools target function.
Example:
By clicking on the skill the sound starts and then clicking on "Enemy: Hit" to roll the damage the sound does not start.
Is it possible to make it work like that?

Armas Veículares (Macro)

Foundry 0.8.6
Savage Worlds 0.19.4

Não consigo rolar as armas veiculares, toda vez aparece a seguinte mensagem
erro

Conviction not counted

SWADE Tools does not take Conviction into calculations. In core when 'conviction' is used, it automaticly adds 1d6 to trait and damage rolls as per rules while conviction is active.

For workaround, adding manually 1d6 does produce the same end result, so this is a minor issue.

Feature Request: automatic range penalties

Would be really cool to have option for autocalculating range penalties (and switching TN4 to Parry for targets in range <1 inch) for ranged attacks.
(Better Rolls2 does this since v2.26)

German Translation

I would like to help out with a German translation for SWADE tools (there already is a German version of the SWADE rules which I own).

damage on vehicles

when attacking a vehicle, when I roll the damage, it does not calculate its resistance / armor

dano tanque

Weapon dialog gives "Error: This is not a registered game setting"

On the character sheet, I can select a token, and click on the "Fighting" skill in the "Summary" tab, get a dialog "Fighting Skill Test", and click "Roll", and it works

Similarly on the "Inventory" tab, I can click on a weapons "Damage", get the weapons "Damage" dialog, and click on either "Roll" or "Roll Raise", and they work

But if I click on the weapons name, get the weapon dialog, when I click on either the "Fighting" or "Damage" buttons, I get an error alert ... "Error: This is not a registered game setting"

image

Thrown weapons use ammo in close combat.

When using a thrown weapon in close combat I set up an action for use Strength, 0 shots, but when I roll to attack it still removes 1 shot. If I roll it through the core system it doesn't remove a shot for close combat.
image

Savage dice in attack rolls

When you do an attack roll from the weapon dialog, the savage dice does not explode, while the skill dice does. Heard that his might be a Foundry issue actually but just in case (works properly in the better rolls and better rolls 2 modules).

Benny animation.

No benny animation is triggered when the reroll with benny button is clicked.

Auto-Apply Statuses

Hello Dev,
I was wondering if it is possible to auto apply statuses based on other statuses like:

If Stunned or Bound, also check Distracted and Vulnerable
If Entangled also check Distracted

Also uncheck actions:
Remove Distracted AND Vulnerable if Unbound
Remove Vulnerable if Unstunned.

If this would be possible using Active Effects, this would be awesome!

Roll initiative on Joker the next round doesn't roll.

When SWADE tools rolls initiative, if it gets a joker it kicks in jokers wild. But at the start of the next turn it doesn't roll initiative automatically. It also stops doing the checking and removing of conditions. Once the round has completed it goes back to checking, rolling for and removing conditions. I tried it on 2 worlds with the same results.

Dice So Nice + SWADE tools

Hi,
when I use "SWADE tools" rolls, "Dice so Nice" does not recognize the wild die and does not change the color of the wild die.

Hit message with failed powers

When you roll, and fail, a power, you get the 1PP spent message (that's ok) but you are also getting a green "HIT" button to roll damage.

Counting shots to core SWADE

Now since SWADE v0.16.0 the ammo usage and reloading is part of the core.
Could that be implemented into SWADE Tools too, or just use core system as is (need that reload button to weapon card)? Currently Tools overrides Core ammo usage&reload system.

Token NPC not linked don't work with "Ammunition Management"

The NPC tokens not connected to the sheet, when they try to reload their weapon, receive the message "The weapon is already fully loaded" (probably because the NPC sheet is already loaded) and do not make the roll, when I use SWADE Tools (otherwise works as expected).
Did I do something wrong or is it a bug?

Tracking Power Points not working

When I try to use a power, the chat box displays "not enough power points". I have set the counter on the powers page to 10 / 10, 0/10 and 10/0 and nothing changes. I also do not see PP subtracting or adding to the total.

FVTT v. 0.7.9
SWADE 0.16.2 (premium content)

Rate of Fire > 1 summing

Using a Frenzy action (standard Fighting with RoF 2), against self token (NPC, not sure if matters), a parry.value=10 and parry.modifier=-1 results in hit with results of 7 and 8.

Expected result here is that the two results are evaluated separately, since they are two separate rolled attacks (with one Wild Die if WC).

Some other modules incompatibility

Hi!
I found some incompatibility with these other modules:

  1. Token Action HUD (use system rolls and no SWADE Tools roll , there is an option to choose which "roller" use, but SWADE don't appear)
  2. Chat Portrait (SWADE Tools rolls don't have neither image or border like system rolls)
  3. Maestro (Item Track don't work with SWADE Tools)
  4. Chat BubbleRolls (simply don't work with SWADE Tools)

P.S.
i'm translating SWADE Tools in italian, when i finish, can i send to you the json file for implemented into your project? and how can I send it to you?

Vehicular weapons not working

When clicking in a vehicular weapon (be it in the name or icon) in the vehicle sheet, it doesn't triggler the swade tools shooting roll.

Ideally it should do it and use the shooting skill of the character manning the weapon.

Feature request: support for Gritty Damage settings rule

Would it be possible to add option to automaticly roll from Injury table (user created, rolltable picker) when Wound is applied to actor, and append (or just create new chat message) the result to chat?
This ofc should be toggleable from module settings.

Jokers wild not adding jokers

NPC draws a joker and the Jokers wild message is displayed. No joker is added. After that, no other joker drawn triggers the "jokers wild" message and no benny is added.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.