liorgrossman / darkness Goto Github PK

Can you please disable the youtube icon? It' s not even need, cause youtube already has dark mode built in.. And the icon in fullscreen just ruins the experience..

Chrome version 56
YouTube "Tomorrow" theme
GitHub "Iceberg" theme
Twitter "Tomorrow" theme

• On YouTube, click on the playbar as if to scrub through a video, but drag up instead of left or right. This might only be a feature on long videos, but when dragging up on the scrubber, it displays video thumbnails. All of this interface should not have inverted colors.
• On GitHub, the label colors are inverted and shouldn't be. This is especially confusing when adding new labels because you have to get the inverse color of what you want.
• On Twitter, all videos and gifs are inverted when they shouldn't be. The gifs that show up with the "add a gif" button aren't inverted until you mouseover them (when they start playing). For videos, both the thumbnail and video itself are inverted and shouldn't be.

Only the @ symbol is shown as "visited" if you've been to that profile - it should be the full name. The inline mentions aren't changing at all; I don't know if they should be or not.

Just did an update and now getting build errors. Looks like an old issue of https://github.com/sass/node-sass is the culprit.

Node/darkness(master) ☸ npm install

> [email protected] install /Users/ay/code/darkness
> gulp install

/Users/ay/code/darkness/node_modules/node-sass/lib/binding.js:13
      throw new Error(errors.unsupportedEnvironment());
      ^

Error: Node Sass does not yet support your current environment: OS X 64-bit with Unsupported runtime (57)
For more information on which environments are supported please see:
https://github.com/sass/node-sass/releases/tag/v3.13.1
    at module.exports (/Users/ay/code/darkness/node_modules/node-sass/lib/binding.js:13:13)
    at Object.<anonymous> (/Users/ay/code/darkness/node_modules/node-sass/lib/index.js:14:35)
    at Module._compile (module.js:643:30)
    at Object.Module._extensions..js (module.js:654:10)
    at Module.load (module.js:556:32)
    at tryModuleLoad (module.js:499:12)
    at Function.Module._load (module.js:491:3)
    at Module.require (module.js:587:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (/Users/ay/code/darkness/node_modules/gulp-sass/index.js:187:21)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] install: `gulp install`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the [email protected] install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:

From https://github.com/sass/node-sass/releases/tag/v3.13.1, node v7 is the latest supported version. Looks like an old version of gulp-sass is the issue. Bumping to 4.0.0 fixed it (see #74)

As per #37 the label colors on the create label page were fixed, however, the labels are still inverted on the issues pages (main issues page, new issue in the dropdown to assign a label, etc.)

The other thing inverted is on commit pages - The highlighting of line additions and deletions shouldn't be inverted (as it is, it shows red for addition and green for removal, the opposite of what it should be).

^ my Avatar is inverted on the home screen of amazon.co.uk

the letters in the comment fields on Facebook are in dark color and can not be seen when you write.

Hello, I paid for the Pro Darkness. I'm hoping that there will be a release in the near future to support split mode on the new Gmail -- so the calendar showing will also be in dark mode along with email.

Thank you!
Iana

See below - loads nicely with a dark background, but 1sec in, and some JS event paints it white again

When I'm using Darkness in facebook and try to put a video fullscreen, it's shown with inverted colors. Tested on Mac OS and Linux (Ubuntu).

Just wanted to let people know that I intend to go through the Google themes and collect the common stuff in the intended "all-google.scss" file, so that when Google updates a class for one of their headers/footers it only has to be updated in one file.

Is your feature request related to a problem you've encountered? Please describe.
Current Facebook themes have text that is too dark to read concerning reacts on posts.

Describe the solution you'd like to see
Perhaps a light color could be used to read text. Current colors are a strain to read.

normal

as you can see whit darkness

I don't have steps to reproduce other than recieve a mesage that is a video link in facebook messenger and it will be inverted in the messenger video preview.

Bug Information

• Site: github
• Theme: coffee
• URL: https://github.com/orgs/fluidincorp/projects/1
• Darkness Version: 2.0.0 Pro
• Browser: Chrome 70.0.3538.77
• Operating System: Linux - Ubuntu 18.10
• Resolution: 3440x1440
• Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Ubuntu Chromium/70.0.3538.77 Chrome/70.0.3538.77 Safari/537.36

Bug Description
Tags on github project boards are not colored and almost unreadable on some themes e.g. Material

Screenshots
Material

Coffee

I've tried to customize an internal site (doesn't start with www) as well as what other's might use using the middle part of the url that is universal for Team Foundation Server. I can't get it to recognize .*/tfs/$ as the url matching. I've tried a lot of combinations but nothing is showing up. Any recommendations on how to handle this?

Example:
https://www.google.com/search?q=%23f562ab&oq=%23f562ab&aqs=chrome..69i57&sourceid=chrome&ie=UTF-8

The color in the background is fine, but the slider, cursor position circle, and left-side panel color is wrong.

Will look into it now and see if I can figure out how to whitelist elements or images!
Here's an example:

When using darkness themes on Facebook, it widens the page so theres a scroll bar on the bottom of the page, making it hard to see you chat boxes. https://imgur.com/a/2P8bluF

And the top Facebook bar doesn't follow down when you scroll down either

would be awesome if it fixxed so that the bottom line scroll bar doesnt pop up when you are using a theme, and the top Facebook bar would follow when you scroll down

• Site: youtube
• Theme: base16tomorrow
• URL: https://www.youtube.com/watch?v=gIud0gJ3pKw&t=4s
• Darkness Version: 2.0.0 Unknown
• Browser: Chrome 70.0.3538.102
• Operating System: Windows 10
• Resolution: 1920x1080
• Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.102 Safari/537.36

Bug Description

Hello, there is an annoying error, the logo of the extension is always in the upper right corner in full screen, could you solve it please?
I am a pro user, I already paid.
Regards!

Screenshots

Bug Information
(visit the affected website → click the moon icon → "Send Feedback" → "Bug Report" → paste here)

• Site: Facebook
• Theme: Iceberg (or any other)
• Browser: Chrome 70.0.3538.102
• Operating System: Windows 10
• Resolution: 1920x1080
• Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.102 Safari/537.36

I've noticed that in Facebook messenger on the website, white background started to appear not long ago aroung the messages in the bubbles, doesn't matter what color I choose, and it's kinda irritating that it started to show up only few days ago (also minor fact - when people are showing up online, their "online status circle" is not green, it's purple, I don't mind about this just informing)

Have you thought of also packaging this for firefox? Firefox also uses WebExtensions and there are only minor differences in both. Mostly in the manifest file.

On some sites, where I have Darkness enabled, the background is changing color every other time I click with my mouse.

I don't know if this is a problem with the invert function in CSS in the newest version of chrome, but if that was the case, I guess it would affect all sites.

Right now I've only experienced it on Google Docs, so it might just be Google refreshing the site a lot.

Hello, maybe you could add support for Google Translator?

Best Regards!

perhaps the icon could be made draggable? it's overriding other buttons at the top-right of webpages etc.

I was using this the other day and noticed that a live video feed on Twitter was showing up as inverted.

While installing the dev version, this didn't work for me:

5. Set up a the original repo as a remote: git remote add upstream [email protected]:liorgrossman/darkness.git
6. Get the code: git fetch upstream

It complained I didn't have the correct access rights.

Same was true for git clone [email protected]:YOUR_GITHUB_USER/darkness.git, so then I used git clone https://github.com/YOUR_GITHUB_USER/darkness.git and it worked.

Didn't think to similarly change the url for the upstream before I already had npm installed / got darkness into Chrome.

At some point I'll do it again and properly, until then if the permission thing is an issue that others would also have, and if as I suspect git remote add upstream https://github.com/liorgrossman/darkness.git would have worked, it might be worth changing that in the Readme...

Is your feature request related to a problem you've encountered? Please describe.

There is no special color for the emphasized text in all themes.

The keyword Darkness is red in original theme and other texts are black. But the color for the keyword and other texts are the same in themes provided by Darkness.

No Theme

Iceberg

Describe the solution you'd like to see
It's nice to have colors to the emphasized tag <em>.

• Site: github
• Theme: iceberg
• URL: https://github.com/liorgrossman/darkness/issues/new/choose
• Darkness Version: 2.0.0 Pro
• Browser: Chrome 70.0.3538.110
• Operating System: Mac OS X 10_14_1
• Resolution: 1680x1050
• Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.110 Safari/537.36

Bug Description
On trying to create a new issue in a Github repository, with the above configuration of Darkness, visited and active anchor elements button texts for the button "Get Started" appear in different shades. This makes it slightly unclear whether the button itself is clickable or not. In themes like Dusk, the button text the situation is worse, in that, the text is highly invisible. Please refer to the screenshots below for both scenarios.

Such a differentiation is not applied to the button with the default Github theme, ie. when Darkness is disabled. Could the behavior be made consistent?

Screenshots

alexa.amazon.com is inverted, We probably just need to ignore it in the regex.

Bug Information
(visit the affected website → click the moon icon → "Send Feedback" → "Bug Report" → paste here)

• Site: Facebook.com
• Theme: Iceberg
• URL: https://www.facebook.com/gaming/StoneMountain64/?video_id=276207276372426&external_ref=live_notification&notif_id=1544562778001098&notif_t=live_video_explicit&ref=notif
• Darkness Version: Free/Trial
• Browser: Google Chrome
• Operating System: Windows 7 (64-Bit)

Bug Description
Videos playing at 1080p without the theme play smooth and have no stutter.
Videos playing at 1080p "WITH" the theme are choppy, stutter constant and drops in framerate are extremely noticeable to the point I don't want to use the theme at all.

Screenshots
If necessary, add screenshots to help explain your problem.

It seems like Youtube is doing A/B testing of a new UI. Darkness is broken on all themes for it.

Edit: as of july 25th It's turned on everywhere for me now it seems. Still needs fixing.

Edit 2: Well, considering there's a built-in dark mode in youtube now, I guess I don't need darkness for youtube anymore. https://www.youtube.com/new

Bug Information

• Site: google
• Theme: iceberg
• URL: https://www.google.com/search?q=iphone+xr&oq=Iphone+XR&aqs=chrome.0.0j69i61l3j0l2.4082j1j7&sourceid=chrome&ie=UTF-8
• Darkness Version: 2.0.0 Pro
• Browser: Chrome 70.0.3538.110
• Operating System: Mac OS X 10_14_1
• Resolution: 2560x1440
• Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.110 Safari/537.36

Bug Description
Some of the images that are shown for search results are too dark to see well.

Screenshots

Is your feature request related to a problem you've encountered? Please describe.
https://github.com/liorgrossman/darkness/blob/master/README.md does not contained updated button texts, under the section Installation->Loading it in Chrome:->Point 4

Describe the solution you'd like to see
I have created a PR for the fix, just an update to the readme : #98

• Site: facebook
• Theme: iceberg
• URL: https://www.facebook.com/
• Darkness Version: 2.0.2
• Browser: Chrome 71.0.3578.80
• Operating System: Windows 10
• Resolution: 1920x1080
• Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/71.0.3578.80 Safari/537.36

Here it shows how the text format doesnt adjust to the theme and it fills the square with white space. It's really annoying.

Here it shows again how the text that shows people who have liked a post is adjusting poorly and can barely be understood.

Can you do something about it?
Thank you for the attention!

Bug Information

• Site: google
• Theme: material
• URL: https://www.google.com/search?num=20&newwindow=1&source=hp&ei=RbsGXK_cD4WhsgH005WQAg&q=color+picker&btnK=Google-Suche&oq=color+picker&gs_l=psy-ab.3..35i39j0l3j0i203j0l5.1192.2849..3023...0.0..0.186.1158.11j2......0....1..gws-wiz.....0..0i131j0i20i263.kbvwU6Xnhs0
• Darkness Version: 2.0.1 Pro
• Browser: Chrome 70.0.3538.110
• Operating System: Windows 10
• Resolution: 1920x1080
• Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.110 Safari/537.36

Bug Description
The Google color-picker has some elements with inverted colors.
This affects all themes.

Screenshots

I get many complaints from users about the moon icon obstructing and covering various UI elements (x buttons, toolbar buttons, etc.)

While many users suggest making it draggable / hide-able, this introduces some additional complexity to a very simple product (what if user drags the icon outside the viewport? what is the screen resolution changes? how can a user restore an icon after it's hidden?)

I think the easiest solution might be to change the circular moon icon to a small triangular icon, and put it in the rightmost-topmost corner (top: 0, right: 0) of the screen - for all websites.
That way, it is much less likely that it will cover/obstruct any website's UI buttons.

What do you think?
Is there any website where such a triangular icon would not fit well?
Would it interfere with any other extension or functionality?

Overlap issue on the Google Photos page.

The "Upload" link seems to be overlapping the "more google menu" button on the header navigation bar.

Image link

I'd like to see the dark theme working on Google Drive. It seems to be a part of almost every other Google app, even those I've never used/heard of!
Drive is an app I use constantly, and sometimes the white screen is really taxing on my eyes. I'm enjoying the themes on the other sites I use, and it feels well worth the money. I just feel like I need this last site to work now!

I just noticed this extension and think it's an awesome idea.

I'm interested in creating a new theme to match my IDE & Linux theme, are you guys okay with me making pull requests with the theme, or should I just keep it locally?

I know there are other projects like Dark Reader that do a good job at universal dark themes. I feel Darkness gives that up for better quality and customization. However it's a lot more time consuming to take these steps.

What would you think about something similar to Dark Reader's dev tool popup or maybe even a selector tool that would help edit and override the custom theme quickly? Perhaps this could save to app data in Google Drive . Then to make part of the universal list the theme could be shared and merged. If the initial adjustments can be made quickly without running npm start type sessions, maybe it would promote quick theme generation edits with less steps.

On Darkness for Firefox (doesn't happen on Chrome):
When scrolling Facebook down, fixed elements such as the toolbar and chatbar aren't fixed, and behave like absolute elements, disappearing as I scroll down the page.

This behavior is caused by using the CSS "filter" attribute on - which is necessary in order to invert the page.
https://bugzilla.mozilla.org/show_bug.cgi?id=1311070
https://stackoverflow.com/questions/37949942/firefox-position-bug-by-parent-with-filter

I tried and committed the suggested solution of putting the filter on the instead of the , but the problem still persists!
Removing the CSS "filter" attribute from solves this issue immediately, but it's not feasible since filter:invert(1) is necessary for Darkness to function.

Can anyone take a look?

Would like an option to automatically enable if identified as a supported site.
Right now I notice if I go to a new site that has a theme generated, that I end up having to click and select a theme manually to start with.

The profile dropdown menu in github is a bit wonky.

I've looked at the css, but can't seem to find the issue. Here are some screenshots for reference.

When the menu is first opened:

And then when hovered over:

Darkness v2
Chrome
Firefox
Open Source

Upgrade
Contact
To report a bug, please:

• Site: google
• Theme: iceberg
• URL: https://www.google.co.in/search?q=election+results&oq=election&aqs=chrome.0.0j69i57j0l4.1099j0j1&sourceid=chrome&ie=UTF-8
• Darkness Version: 2.0.0 Pro
• Browser: Chrome 70.0.3538.110
• Operating System: Mac OS X 10_14_1
• Resolution: 1680x1050
• Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.110 Safari/537.36
  Chrome Extension · Firefox Add-on · GitHub · Pro Upgrade · Contact · Privacy
  Darkness is made with love by Lifehack Labs

Bug Description
The color of the chart slice differs from the color of the chart slice legend( my guess is its because its inverted). Note: the link above may not be available for long, since it is the result of an election that concluded today ie. 11 Nov 2018

Screenshots
Here is the normal expected behavior:

Here is the buggy behavior:

I think inversion it is not well idea!

Looks why: http://joxi.ru/xAevl1EiYKpVOr

At whole site I got inverted colors. But I trying look content what must display without inversion.

Just logging that this problem exists, because I don't have time to fix it right now.

Hi, as title said, when I use any dark theme on Facebook today the navbar just not stay on top anymore

Switch back to no theme and it work

Hope you guys can update it :)

on the Facebook page no matter what topic one uses the left side and the right side do not go down with the middle ghet down then it is left and right black and not like in the standard right friend list and left favorites, info, groups. That's only with Fierfox.