lionel- / contributing Goto Github PK

View Code? Open in Web Editor NEW

13.0 13.0 2.0 27 KB

Contributing to GNU R

Home Page: https://bookdown.org/lionel/contributing/

Shell 88.22% Makefile 11.78%

contributing's People

Contributors

Stargazers

Watchers

Forkers

jeffreypullin atheriel

contributing's Issues

Error when running `../configure`

Hiya! Firstly thanks for this awesome resource, I'm VERY green so I'm sorry if this is absolute noob but I'm working through this and ran ../configure inside the build folder we created but I got the error:

No Fortran compiler found

What's the recommended way of installing this?

[Somewhat related I don't know how much prior knowledge is assumed for the bookdown but it took me a minute to chase down that I needed to run brew install wget to get the tweaking files 😊 ]

Thanks again!!

Tweak for use with r-svn?

https://github.com/r-devel/r-svn is also an SVN mirror, but offers CI/CD. Is the process for compiling local sources different for that repository?

Need to tell `configure` where to find X11

I seem to need to add this to my ../configure call

--x-libraries=/opt/X11/lib/ --x-includes=/opt/X11/include

otherwise I get:

configure: error: --with-x=yes (default) and X11 headers/libs are not available

not sure why it can't find xquartz on its own

libcurl error

Hi Lionel,

I realise it's a little early for you to be accepting contributions just yet but I've been playing along at home and ran into the error:

error: libcurl >= 7.28.0 library and headers are required with support for https

I was able to fix it with by taking anaconda3 off the path following this answer.

Would you consider adding this to Compilation troubleshooting section? I'd be happy to make a PR if so.

All the best!

Note about libtiff version error

I saw this when running make all

No rule to make target /usr/local/Cellar/libtiff/4.2.0/include/tiffio.h', needed by rbitmap.o'.  Stop.

I went and looked in /usr/local/Cellar/libtiff/ and I had 4.3.0 but not 4.2.0.

I think this is what happened:

I had an old version of macOS when I last built R from source
There were files in build/ from the last time I built R
One of those files was a Makefile for X11 that is generated by make all, and it looked for /usr/local/Cellar/libtiff/4.2.0 because the file was generated on my old version of macOS
I have since upgraded macOS and the upgrade must have come with 4.3.0
make clean did not remove that file from build/

I finally had to nuke the buiild/ directory and start over, that seemed to work

Zero-width characters in code chunks

On my mac, when I copied the Mac build script and pasted it into a file and ran it, I see these messages:

$ ./build.sh 
./build.sh: line 2: : command not found
./build.sh: line 3: : command not found
./build.sh: line 8: : command not found
./build.sh: line 11: : command not found
./build.sh: line 14: : command not found
./build.sh: line 15: : command not found

It appears that the "empty" lines have zero-width space characters:

In a hex viewer, you can see the sequence e2808b, which is a zero-width space in UTF-8:

00000000:  2321 2f62 696e 2f62 6173 680a e280 8b0a e280 8b0a 2320 5220  :#!/bin/bash.........# R 
00000018:  7265 636f 6d6d 656e 6473 2073 6574 7469 6e67 2074 6869 7320  :recommends setting this 
00000030:  746f 2061 766f 6964 2069 7373 7565 7320 7769 7468 2070 726f  :to avoid issues with pro
00000048:  6772 616d 7320 6c69 6b65 2073 6564 3a0a 6578 706f 7274 204c  :grams like sed:.export L
00000060:  414e 473d 430a 0a65 7870 6f72 7420 525f 4152 4348 3d22 220a  :ANG=C..export R_ARCH="".
00000078:  e280 8b0a 2320 4765 7420 7665 7273 696f 6e20 696e 206d 616a  :....# Get version in maj
00000090:  6f72 2e6d 696e 6f72 2066 6f72 6d61 743a 0a56 4552 5349 4f4e  :or.minor format:.VERSION
000000a8:  3d60 7365 6420 2773 2f5c 285b 302d 395d 2a2e 5b30 2d39 5d2a  :=`sed 's/\([0-9]*.[0-9]*
000000c0:  5c29 2e5b 302d 395d 2a2e 2a2f 5c31 2f27 202e 2e2f 5645 5253  :\).[0-9]*.*/\1/' ../VERS
000000d8:  494f 4e60 0ae2 808b 0a23 2055 7365 2076 6572 7369 6f6e 2d64  :ION`.....# Use version-d
000000f0:  6576 2061 7320 6465 6661 756c 7420 666f 6c64 6572 2074 6172  :ev as default folder tar
00000108:  6765 743a 0a54 4152 4745 543d 247b 313a 2d24 5645 5253 494f  :get:.TARGET=${1:-$VERSIO
00000120:  4e2d 6465 767d 0ae2 808b 0ae2 808b 0a23 2044 6f77 6e6c 6f61  :N-dev}.........# Downloa
00000138:  6420 7265 636f 6d6d 656e 6465 6420 7061 636b 6167 6573 0a2e  :d recommended packages..
00000150:  2e2f 746f 6f6c 732f 7273 796e 632d 7265 636f 6d6d 656e 6465  :./tools/rsync-recommende
00000168:  640a e280 8b0a 2e2e 2f63 6f6e 6669 6775 7265 205c 0a20 2020  :d......./configure \.   
00000180:  202d 2d65 6e61 626c 652d 522d 6672 616d 6577 6f72 6b20 4657  : --enable-R-framework FW
00000198:  5f56 4552 5349 4f4e 3d24 7b54 4152 4745 547d 205c 0a20 2020  :_VERSION=${TARGET} \.   
000001b0:  202d 2d77 6974 682d 6171 7561 3d79 6573 205c 0a20 2020 202d  : --with-aqua=yes \.    -
000001c8:  2d77 6974 682d 783d 7965 7320 5c0a 2020 2020 2d2d 656e 6162  :-with-x=yes \.    --enab
000001e0:  6c65 2d6d 656d 6f72 792d 7072 6f66 696c 696e 6720 5c0a 2020  :le-memory-profiling \.  
000001f8:  2020 4346 4c41 4753 3d22 2d67 202d 4f30 2220 2626 205c 0a20  :  CFLAGS="-g -O0" && \. 
00000210:  206d 616b 6520 616c 6c20 2626 205c 0a20 206d 616b 6520 696e  : make all && \.  make in
00000228:  7374 616c 6c0a                                               :stall.

It's also hard to copy from the middle of a code block.

Although, now that I think about this a bit more, this is probably the fault of bookdown, not this specific repo.

Update: It looks like the building.Rmd file does indeed have zero-width space characters in that code block, so it's not bookdown's fault.

Recommend Projects

React

A declarative, efficient, and flexible JavaScript library for building user interfaces.
Vue.js

🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
Typescript

TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
TensorFlow

An Open Source Machine Learning Framework for Everyone
Django

The Web framework for perfectionists with deadlines.
Laravel

A PHP framework for web artisans
D3

Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

javascript

JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
web

Some thing interesting about web. New door for the world.
server

A server is a program made to process requests and deliver data to clients.
Machine learning

Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Visualization

Some thing interesting about visualization, use data art
Game

Some thing interesting about game, make everyone happy.

Recommend Org

Facebook

We are working to build community through open source technology. NB: members must have two-factor auth.
Microsoft

Open source projects and samples from Microsoft.
Google

Google ❤️ Open Source for everyone.
Alibaba

Alibaba Open Source for everyone
D3

Data-Driven Documents codes.
Tencent

China tencent open source team.