linuxmint / mintupload Goto Github PK

While building:

Now running lintian...
[...]
E: mintupload: python-script-but-no-python-dep usr/lib/linuxmint/mintupload/file-uploader.py
E: mintupload: python-script-but-no-python-dep usr/lib/linuxmint/mintupload/launch-file-uploader.py
E: mintupload: python-script-but-no-python-dep usr/lib/linuxmint/mintupload/mintupload.py
E: mintupload: python-script-but-no-python-dep usr/lib/linuxmint/mintupload/upload-manager.py

In usr/share/applications/mintupload.desktop
you are using an hardcoded path to the icon.
result it will not change if you are choosing an other theme and it breaks the beauty of your theme.

please change the following code

Exec=mintupload-manager
Icon=/usr/share/pixmaps/mintupload/icon.svg
Terminal=false
Type=Application
Encoding=UTF-8
Categories=Application;System;Settings
StartupNotify=false
NotShowIn=KDE;

to

Exec=mintupload-manager
Icon=mintupload
Terminal=false
Type=Application
Encoding=UTF-8
Categories=Application;System;Settings
StartupNotify=false
NotShowIn=KDE;

What happens: run MintUpload (via any route, I think). Close it. Run it again. Close again. Result: two MintUpload icons in my panel. Indeed one can generate three icons in this manner.

What should happen: either the icon should disappear when one quits the program, or, if not, only one icon should ever appear at any one time. Presumably!

This problem is similar to two others that have been reported (see #5 and #4)

Mint 17.3 x64 Cinnamon 2.8.8.

OS: Mint 16 "Petra" 32-bit
mintUpload 3.9.4

Once you went through File -> New, a new service will be created even if you close the window that expects you to define the service's name.

Normally there should be a Cancel button and closing the window should perform the same action as Cancel - which is nothing.

Please fetch the following strings with ngettext, so that they can be translated properly:

Successfully uploaded %(number)d files to '%(service)s'

Located in: usr/lib/linuxmint/mintUpload/mintUpload.py:89

You can combine it with this string then:

Successfully uploaded 1 file to '%(service)s'

Located in: usr/lib/linuxmint/mintUpload/mintUpload.py:91

Uploading %(number)d files to %(service)s

Located in: usr/lib/linuxmint/mintUpload/mintUpload.py:127

Can be combined with:

A' luchdadh suas aon fhaidhle gu %(service)s

Located in: usr/lib/linuxmint/mintUpload/mintUpload.py:130

%(percentage)s of %(number)d files - Uploading to %(service)s

Located in: usr/lib/linuxmint/mintUpload/mintUpload.py:128 usr/lib/linuxmint/mintUpload/mintUpload.py:236

Can be combined with:

%(percentage)s of 1 file - Uploading to %(service)s

Located in: usr/lib/linuxmint/mintUpload/mintUpload.py:131 usr/lib/linuxmint/mintUpload/mintUpload.py:238

OS: Mint 16 "Petra" 32-bit
mintUpload 3.9.4

New, Edit, Delete <- not in Launchpad for translation

OS: Mint 16 "Petra" 32-bit
mintUpload 3.9.4

While creating a new service, tooltips could help, but the displayed domain and user name are not what the tooltips suggest.

Host name
Tooltip: mint-space.com
Actual text in text box: hostname.com

User name
Tooltip: it says it's your local user name
Actual text in text box: username

Also related, the password tooltip might be confusing considering the default port and service are 21/FTP.

The password tooltip is: "Password, by default: password-less SCP connection, null-string FTP connection, ~/.ssh keys used for SFTP connections"

and it should be: "Password, by default: null-string FTP connection, password-less SCP connection, ~/.ssh keys used for SFTP connections"

If the tooltip mentions SCP first you will have doubts whether by default mintUpload will try SCP or FTP.

Nag: "Timestamp format (strftime). By default:" <- this should have a trailing space :P

OS: Mint 16 "Petra" 32-bit
mintUpload 3.9.4

The "Quit" option from the mintUpload tray icon should close all open windows (related to #4)

or...

the mintUpload's tray menu should have an option that allows closing all the mintUpload's chlidren/windows.

The following time strings need to be fetched with ngettext:

%(hours)d hours, %(minutes)d minutes

1 hour, %d minutes

%(minutes)d minutes, %(seconds)d seconds

1 minute, %d seconds

%d seconds

Located starting from: usr/lib/linuxmint/mintUpload/mintUpload.py:191

Since most of these contain 2 numbers, maybe the following design would work:

%(hours)d hours, %(minutes)s

Combined with:

%(minutes)d minutes

And

%(minutes)d minutes, %(seconds)s

Combined with:

%(seconds)d seconds

Could you change the reference to the icon in

/usr/share/applications/mintupload.desktop

from

Exec=mintupload-manager
Icon=/usr/share/pixmaps/mintupload/icon.svg
Terminal=false
Type=Application
Encoding=UTF-8
Categories=Application;System;Settings
StartupNotify=false
NotShowIn=KDE;

to

Icon=mintupload

Last icon that breaks the otherwise great theme.

Perhaps it was the way I had (mis?)entered credentials, but I found that the cancel button didn't work. Consequently I ended up with three of the test upload windows on screen at once. They disappeared only when they timed out.

Here's a picture of one of those upload windows:

Mint 18.1 CInnamon x64. Mint Upload 4.0.9.

Example
if you drag an drop a folder with a name which contains shell chars
the program xmessage will pop up with a "hello bug" message.
(see attached screenshot)

reason
Python scripts use os.system , should use subprocess.

OS: Mint 16 "Petra" 32-bit
mintUpload 3.9.4

1. start mintUpload
2. click the mintUpload tray icon
3. click the "Upload manager..." menu option

Expected result: focus the already open window or if a window doesn't exist it will open a new one

Actual result: mintUpload will open a new window. You can repeat 15 times and you will have as many windows

OS: Mint 16 "Petra" 32-bit
mintUpload 3.9.4

I thought it was a bug in the translation but there's nothing I could do in Launchpad. The "small" html tags are not there.

P.S. The drag&drop areas have ugly corners on top. I hope those can be fixed as well.

OS: Mint 16 "Petra" 32-bit
mintUpload 3.9.4

File -> New -> Service name

Although you're advised against using spaces or special characters, they are not disallowed/rejected nor filtered. On top of that, you can even click OK without adding anything at all in the service name box.