Hi @user

Congratulations, your code compiles!! 🎉 🥳

Unfortunately our something-something-bot found a few violations that you might want to check out 😄 😄

⚠️ Violation : S109 -- Magic Number shouldn't be used

🤖 : Hey! I'm SOBO your annoying but well intentioned bot-friend from INDA

🤖 : I notice that in line(s) [5,7,9,15] there is(are) a magic number!

🤖 : This has an easy fix but is important to know why is a bad idea to use it 🤔

...

A magic number is a number that comes out of nowhere, and in a hurry no one cares about this (even I do it sometimes), BUT when you come back to your repo after one thousand days you probably will not remember why you use it or it could lead to really bad headaches when debugging. For this reason we suggest to define the variable and then use it . Here is an example:

Instead of doing this

public class Example{
    public static void doSomething() {
        for(int i = 0; i < 4; i++){               
            ...
        }
    }   
}

Do this :

public class Example{
    public static final int NUMBER_OF_CYCLES = 4;
    public static void doSomething() {
        for(int i = 0; i < NUMBER_OF_CYCLES ; i++){
            ...
        }
    }
}

...

❓ Curious fact : -1, 0 and 1 are not considered magic numbers 😱

🤖 : Now you know what to do, should we give it a new try? 😄

🤖 : Can't wait to see your next commit 😉

Tim O'Reilly

We're so excited that you've decided to create a new project! Now that you're here, let's make sure you know how to get the most out of GitHub Projects.

• Create a new project
• Give your project a name
• Press the ? key to see available keyboard shortcuts
• Add a new column
• Drag and drop this card to the new column
• Search for and add issues or PRs to your project
• Manage automation on columns
• Archive a card or archive all cards in a column

Tim O'Reilly