It will be pretty annoying to declare types for the various HTML elements, but it has

Use TypeScript instead of JavaScript about vic3-mapdata-editor HOT 3 OPEN

linnest2020 commented on May 16, 2024

Use TypeScript instead of JavaScript

from vic3-mapdata-editor.

Comments (3)

Linnest2020 commented on May 16, 2024

Yep, Typescript is neccessary for developing, change the repo into Typescript was listed in TODO list, however, it is limitied by two problem

I haven't learn how to use Typescript yet
Using Typescript may bring some barrier for adding new features, thoght the editor started to get stable

from vic3-mapdata-editor.

Jaykingamez commented on May 16, 2024

Perhaps you would like to organize it around a framework like React or Angular?

Anyway, the current JS code can be pasted in typescript, the only things to change would be declaring types.

from vic3-mapdata-editor.

Linnest2020 commented on May 16, 2024

Vic3-mapdata-editor/src/index.ts

Lines 84 to 99 in 2855057

 type state_detail_private_type = { 

 state_type:"corporated"|"incorporated"|"treaty_port"|("corporated"|"incorporated"|"treaty_port")[] 

 country:string 

 owned_provinces:string[] 

 } 

 type state_detail_type = { 

 create_state:(state_detail_private_type|state_detail_private_type[]) 

 add_claim?:string|string[] 

 add_homeland?:string|string[] 

 } 

 type history_dict_type = { 

 STATES:{[key:string]:state_detail_type} 

 }

You can see I post a ROUGH TypeScript Version on it, and the code above is the interface of 00_states.txt, however, when it comes with actual usage:

Vic3-mapdata-editor/src/update/update_states.ts

Line 32 in 2855057

 full_map_data.histroy_state_dict["STATES"][old_state]["create_state"]["owned_provinces"] = full_map_data.histroy_state_dict["STATES"][old_state]["create_state"]["owned_provinces"].filter((item:string) => item!=prov) 

It would raise error

And then, when I complite with tsc, it don't works(warning at Uncaught ReferenceError: exports is not defined at index.js:2:1)

from vic3-mapdata-editor.

Recommend Projects

Use TypeScript instead of JavaScript about vic3-mapdata-editor HOT 3 OPEN

Comments (3)

Related Issues (14)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	type state_detail_private_type = {
	state_type:"corporated"\|"incorporated"\|"treaty_port"\|("corporated"\|"incorporated"\|"treaty_port")[]
	country:string
	owned_provinces:string[]
	}

	type state_detail_type = {
	create_state:(state_detail_private_type\|state_detail_private_type[])
	add_claim?:string\|string[]
	add_homeland?:string\|string[]
	}

	type history_dict_type = {
	STATES:{[key:string]:state_detail_type}
	}