Git Product home page Git Product logo

cytograph-dev's People

Contributors

camiel-m avatar gioelelm avatar kasiletti avatar larsborm avatar pl-ki avatar slinnarsson avatar

Watchers

 avatar  avatar  avatar  avatar  avatar

cytograph-dev's Issues

Change the argument ``tissue`` with ``pool``

I open this issue here since might related to both adolescent-mouse and development-mouse pipelines.

Many of luigi.Tasks accept as main parameter --tissue, I propose to change the name with the more general --pool, since what it is reading is the Pool column of the pooling_sepcification.tab filem and tissue is confusing for the context we use it in development.

install problem: numpy-groupies not found

Following instructions on cytograph main page:

$ git clone https://github.com/linnarsson-lab/cytograph.git
Klonar till "cytograph"
...
$ cd cytograph/bhtsne
$ g++ sptree.cpp tsne.cpp -o bh_tsne -O2
$ cd ..
$ python setup.py install
......
Installed /home/peter/anaconda3/lib/python3.6/site-packages/cytograph-0.6.1-py3.6.egg
Processing dependencies for cytograph==0.6.1
Searching for numpy-groupies
Downloading http://github.com/linnarsson-lab/numpy-groupies/tarball/master#egg=numpy_groupies
error: Can't download http://github.com/linnarsson-lab/numpy-groupies/tarball/master#egg=numpy_groupies: 404 Not Found

Store build-id in .loom file

We are producing many pool cytograph .loom files. They are created in different build folder but once copied elsewhere there is not way to track when the file was generated and to wich build it belongs. Therefore I suggest we should store the build id in the loom file as a column or file attribute.

cytograph needs some basic documentation

cytograph is heavily underdocumented. This has recently been problem for both @kasiletti trying to get started with the library and me trying to come back to the code I wrote after a while.

There is no easy way to visualize the tasks tree (and no, the built in graph viewer is not an option, it is only meant to work for running tasks). Docstrings are short and not very descriptive. Documentation of the options that one can pass to the command line interface and on which task they have effect would be really needed.

With this issue I suggest that we join efforts to make an effort to document cytograph a bit while we work with it over the next months. It does not have to be something production-ready, but a documentation layer that spares us the work of going and read the source over and over again! Me and @kasiletti could add new docs/dosctrings while we modify/read the code. @slinnarsson, since you understand the luigi internals better, maybe you could help with some ideas on how to build a tasks tree inspector/visualizer.

Regarding how to build the docs, I did not find any sphinx integration or automatic documentation tools for luigi (i.e. nothing like this) , it looks like we will have to do the CLI api of the docs manually. The api of each task can be automatically estracted, and it is probably the best place to document what each task is doing. I suggest that we get started directly with reStructuredText format, allowing to build a neater html documentation with spinx later on.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.