lingaro / magento2-module-codegen Goto Github PK

In version 3.3.0 there is an unexpected : after getId() in the following code snippet. It causes syntax error for generated file.

    public function getId():
    {
        return $this->_getData('entity_id');
    }

That's enhancement I would find useful, but don't know the architecture of your library for now, so just posting an idea.

So, let's assume we generate certain types of templates, with an option of module creation on the fly. It would be nice to have dependencies sorted out in process. For example, generation of crontab, should be followed by adding dependency to Magento_Cron in module.xml and composer.json. However there are some issues I see:

• it is possible only if we say 'yes' to question if we would like to have module generated - I assume we should get that question every time we generate something
• it is a problem to resolve package version (for composer version) if we don't know for which magento version code is generated - it can be avoided by putting wildcard (*) on the other hand or we could specify our target magento version in some config file
• matrix of dependencies vs template has to be stored in some config file, but I don't know if there are templates that can generate code dependant to different packages according to what we insert during survey in CLI

Thanks for providing such an useful tool for community.

Adding additional flag like "includeCompanyHeader" would be useful as not all companies includes company name and exact author data. Adding empty values doesn't prevent adding copyrights notes in headers and they look like this:

<!--
/**
 * @copyright Copyright ©  . All rights reserved.
 * @author
 */
-->

When Codegen 4.0 is installed globally via Composer, it throws a fatal error when running.

Fatal error: Lingaro\Magento2Codegen\Util\Symfony\CommandTester and Symfony\Component\Console\Tester\TesterTrait define the same property ($input) in the composition of Lingaro\Magento2Codegen\Util\Symfony\CommandTester. However, the definition differs and is considered incompatible. Class was composed in /home/devilbox/.composer/vendor/lingaro/magento2-codegen/src/Lingaro/Magento2Codegen/Util/Symfony/CommandTester.php on line 20

This can be fixed by not allowing installation of symfony/console with version 5.4 or higher.

Thanks for providing such an useful tool for community. I have just started testing it around and found tiny issues.

While answering questions about crontab.xml file I couldn't insert value 0 for scheduleHour. I bet the same issue may occur for other parts of crontab expression. Maybe 0 is casted to null or sth like this and it is not accepted as value is required.

Generated crontab not exactly matches what I've inserted through CLI. Job name is prepended with snake case module name, what was for me unexpected.