lilypad / bukkit-connect Goto Github PK

Hello,

Can you work on getting this plugin to work with this: https://build.true-games.org/job/ProtocolSupport/

Error log: http://pastebin.com/FQweuqRh

@coelho

The newest version of bukkit-connect does not work with spigot 1.16.5. There are 2 errors present on startup. It also doesnt work with the latest java 16.

Errors pastebin: https://pastebin.com/j5AntRca
I will copy and paste the errors too incase the pastebin breaks.
1st error:
[12:28:54] [Server thread/WARN]: Legacy plugin LilyPad-Connect v132 does not specify an api-version.
[12:28:54] [Server thread/WARN]: java.lang.NoSuchFieldException: modifiers
[12:28:54] [Server thread/WARN]: at java.base/java.lang.Class.getDeclaredField(Class.java:2549)
[12:28:54] [Server thread/WARN]: at lilypad.bukkit.connect.util.ReflectionUtils.(ReflectionUtils.java:19)
[12:28:54] [Server thread/WARN]: at lilypad.bukkit.connect.hooks.SpigotHook.(SpigotHook.java:23)
[12:28:54] [Server thread/WARN]: at lilypad.bukkit.connect.ConnectPlugin.(ConnectPlugin.java:25)
[12:28:54] [Server thread/WARN]: at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
[12:28:54] [Server thread/WARN]: at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:78)
[12:28:54] [Server thread/WARN]: at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
[12:28:54] [Server thread/WARN]: at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:499)
[12:28:54] [Server thread/WARN]: at java.base/java.lang.reflect.ReflectAccess.newInstance(ReflectAccess.java:128)
[12:28:54] [Server thread/WARN]: at java.base/jdk.internal.reflect.ReflectionFactory.newInstance(ReflectionFactory.java:350)
[12:28:54] [Server thread/WARN]: at java.base/java.lang.Class.newInstance(Class.java:642)
[12:28:54] [Server thread/WARN]: at org.bukkit.plugin.java.PluginClassLoader.(PluginClassLoader.java:94)
[12:28:54] [Server thread/WARN]: at org.bukkit.plugin.java.JavaPluginLoader.loadPlugin(JavaPluginLoader.java:153)
[12:28:54] [Server thread/WARN]: at org.bukkit.plugin.SimplePluginManager.loadPlugin(SimplePluginManager.java:414)
[12:28:54] [Server thread/WARN]: at org.bukkit.plugin.SimplePluginManager.loadPlugins(SimplePluginManager.java:322)
[12:28:54] [Server thread/WARN]: at org.bukkit.craftbukkit.v1_16_R3.CraftServer.loadPlugins(CraftServer.java:393)
[12:28:54] [Server thread/WARN]: at net.minecraft.server.v1_16_R3.DedicatedServer.init(DedicatedServer.java:281)
[12:28:54] [Server thread/WARN]: at net.minecraft.server.v1_16_R3.MinecraftServer.w(MinecraftServer.java:1074)
[12:28:54] [Server thread/WARN]: at net.minecraft.server.v1_16_R3.MinecraftServer.lambda$a$0(MinecraftServer.java:293)
[12:28:54] [Server thread/WARN]: at java.base/java.lang.Thread.run(Thread.java:831)
[12:28:54] [Server thread/INFO]: [LilyPad-Connect] Loading LilyPad-Connect v132

2nd error: [12:28:54] [Server thread/INFO]: [LilyPad-Connect] Enabling LilyPad-Connect v132*
[12:28:54] [Server thread/WARN]: java.lang.NullPointerException: Cannot invoke "java.lang.reflect.Field.setInt(Object, int)" because "lilypad.bukkit.connect.util.ReflectionUtils.FIELD_MODIFIERS" is null
[12:28:54] [Server thread/WARN]: at lilypad.bukkit.connect.util.ReflectionUtils.setFinalField(ReflectionUtils.java:41)
[12:28:54] [Server thread/WARN]: at lilypad.bukkit.connect.injector.NettyInjector.injectAndFindPort(NettyInjector.java:46)
[12:28:54] [Server thread/WARN]: at lilypad.bukkit.connect.ConnectPlugin.onEnable(ConnectPlugin.java:88)
[12:28:54] [Server thread/WARN]: at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:263)
[12:28:54] [Server thread/WARN]: at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:370)
[12:28:54] [Server thread/WARN]: at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:500)
[12:28:54] [Server thread/WARN]: at org.bukkit.craftbukkit.v1_16_R3.CraftServer.enablePlugin(CraftServer.java:518)
[12:28:54] [Server thread/WARN]: at org.bukkit.craftbukkit.v1_16_R3.CraftServer.enablePlugins(CraftServer.java:432)
[12:28:54] [Server thread/WARN]: at net.minecraft.server.v1_16_R3.DedicatedServer.init(DedicatedServer.java:282)
[12:28:54] [Server thread/WARN]: at net.minecraft.server.v1_16_R3.MinecraftServer.w(MinecraftServer.java:1074)
[12:28:54] [Server thread/WARN]: at net.minecraft.server.v1_16_R3.MinecraftServer.lambda$a$0(MinecraftServer.java:293)
[12:28:54] [Server thread/WARN]: at java.base/java.lang.Thread.run(Thread.java:831)
[12:28:54] [Server thread/INFO]: [Connect] Unable to start plugin - unsupported version?

Site seems to be down, this breaks the maven build.

Hello,

today i updated my servers to Spigot 1.8.
As previously, spigot generates random uuids in offline-mode, so i switched back to online-mode
(for the backend servers).
This worked, until 1.8:

[11:49:39] [User Authenticator #2/ERROR]: Could not pass event AsyncPlayerPreLoginEvent to LilyPad-Connect v86
org.bukkit.event.EventException
at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:303) ~[2014-11-29-11-16-38-spigot1658.jar:git-Spigot-"606148f"]
at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62) ~[2014-11-29-11-16-38-spigot1658.jar:git-Spigot-"606148f"]
at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:509) [2014-11-29-11-16-38-spigot1658.jar:git-Spigot-"606148f"]
at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:491) [2014-11-29-11-16-38-spigot1658.jar:git-Spigot-"606148f"]
at net.minecraft.server.v1_8_R1.ThreadPlayerLookupUUID.fireLoginEvents(ThreadPlayerLookupUUID.java:79) [2014-11-29-11-16-38-spigot1658.jar:git-Spigot-"606148f"]
at net.minecraft.server.v1_8_R1.ThreadPlayerLookupUUID.run(ThreadPlayerLookupUUID.java:31) [2014-11-29-11-16-38-spigot1658.jar:git-Spigot-"606148f"]
Caused by: java.lang.NullPointerException
at lilypad.bukkit.connect.login.LoginListener.onAsyncPlayerPreLogin(LoginListener.java:34) ~[?:?]
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_25]
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_25]
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_25]
at java.lang.reflect.Method.invoke(Method.java:483) ~[?:1.8.0_25]
at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:299) ~[2014-11-29-11-16-38-spigot1658.jar:git-Spigot-"606148f"]
... 5 more
[11:49:39] [User Authenticator #2/INFO]: Disconnecting com.mojang.authlib.GameProfile@10bb93e4id=8dec9c7d-1fe1-3bdf-94d0-04e226a4953e,name=maxs97,properties={},legacy=false: LilyPad: Internal server error
[11:49:39] [Server thread/INFO]: com.mojang.authlib.GameProfile@10bb93e4id=8dec9c7d-1fe1-3bdf-94d0-04e226a4953e,name=maxs97,properties={},legacy=false lost connection: LilyPad: Internal server error

I'm using Bukkit-Connect v86

Due to changes in ProtocolSupport, they've now completely removed isOnlineMode from the login handler causing players to be unable to log into 1.13.x servers. This will likely need to be completely rewritten https://github.com/LilyPad/Bukkit-Connect/blob/master/src/main/java/lilypad/bukkit/connect/login/LoginNettyInjectHandler.java#L175-L200

I tried to do it myself by using their API events, but couldn't figure out how to get the payload from the proxy so that it doesn't use offline mode UUIDs and properties.

ProtocolSupport build: 278

Stacktrace: https://i.tcpr.ca/I3TDJ6X When a player attempts to log in, this is what is outputted

Edit:

Appears to happen with the dev builds of ProtocolSupport that are before the 1.13 builds.

To help people understand the purpose of this plugin when they find it on the internet or by using github's search text box, add a readme file to let people know if they found what they need!

I am unable to connect to my server using a 1.12.2 client.

I have tried on a paperspigot 1.12.1 + viaversion 1.3.0 and a paperspigot 1.12.2 server
Both times I have been using BukkitConnect v121
I saw there was no changes listed between 120 and 121, so I also tried the 120 build with no luck.

On my server, the Bukkit-Connect plugin prints this error when attempting to connect.

java.lang.NoSuchFieldException: isOnlineMode
    at java.lang.Class.getDeclaredField(Class.java:2070)
    at lilypad.bukkit.connect.util.ReflectionUtils.setFinalField(ReflectionUtils.java:37)
    at lilypad.bukkit.connect.login.LoginNettyInjectHandler.handlePacketLoginStart(LoginNettyInjectHandler.java:198)
    at lilypad.bukkit.connect.login.LoginNettyInjectHandler.packetReceived(LoginNettyInjectHandler.java:37)
    at lilypad.bukkit.connect.injector.NettyDecoderHandler.decode(NettyDecoderHandler.java:24)
    at io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:88)
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362)
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348)
    at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:340)
    at io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:310)
    at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:284)
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362)
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348)
    at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:340)
    at io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:310)
    at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:284)
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362)
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348)
    at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:340)
    at protocolsupport.protocol.pipeline.initial.InitialPacketDecoder.setNativeProtocol(InitialPacketDecoder.java:194)
    at protocolsupport.protocol.pipeline.initial.InitialPacketDecoder.decode(InitialPacketDecoder.java:149)
    at protocolsupport.protocol.pipeline.initial.InitialPacketDecoder.channelRead0(InitialPacketDecoder.java:104)
    at protocolsupport.protocol.pipeline.initial.InitialPacketDecoder.channelRead0(InitialPacketDecoder.java:30)
    at io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:105)
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362)
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348)
    at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:340)
    at protocolsupport.protocol.pipeline.common.SimpleReadTimeoutHandler.channelRead(SimpleReadTimeoutHandler.java:39)
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362)
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348)
    at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:340)
    at io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1359)
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362)
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348)
    at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:935)
    at io.netty.channel.epoll.AbstractEpollStreamChannel$EpollStreamUnsafe.epollInReady(AbstractEpollStreamChannel.java:797)
    at io.netty.channel.epoll.EpollEventLoop.processReady(EpollEventLoop.java:404)
    at io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:304)
    at io.netty.util.concurrent.SingleThreadEventExecutor$5.run(SingleThreadEventExecutor.java:858)
    at java.lang.Thread.run(Thread.java:748)

I'm kicked from the server saying Outdated Server! I'm still on 1.12.2

If I downgrade to a 1.12 client then I am able to connect briefly before being kicked for a possibly different issue.

logged in with entity id 2 at ([world]-812.971494864038, 4.0, 16.679425994224676)
lost connection: Internal Exception: io.netty.handler.codec.DecoderException: java.lang.IndexOutOfBoundsException: readerIndex(1) + length(8) exceeds writerIndex(2): PooledUnsafeDirectByteBuf(ridx: 1, widx: 2, cap: 256)

I'm going to continue to look into the possibility of this being an issue on my end, since I don't see anyone else having problems with Bukkit-Connect on 1.12.2, but I figured you might want the stack trace at least.

Between 1.15.1 and 1.15.2, getNettyInjectorChannelFutureList changed from f to listeningChannels.

I've fixed this on my own servers, however, this update comes without a change to the package version (v1_15_R1), meaning I can't just PR it back into Bukkit-Connect without making it incompatible for 1.15 and 1.15.1.

Bukkit-Connect does not load with 1.13.2. Disables on startup. LilyPad-Proxy & Connect are updated to 1.13.2, and the plugin should be aswell.

Hi! When I'm connecting to the server with premium mode to the target server, uuid on this server is as my offline mode uuid. So when I'm joining with premium the uuid is non premium.

Hello,

A server owner, using my SpigotLib plugin have a compatibility issue, with this plugin. which I could fix. The fix is just a changing of one line:
I needed to change the 40. line in the lilypad.bukkit.connect.injector.NettyInjector class to:
ChannelHandler serverBootstrapAcceptor = channelPipeline.get("ServerBootstrap$ServerBootstrapAcceptor#0");
Please add this fix to the plugins official release too.

Unable to join on any version.
Fresh server, latest PaperSpigot (Tried Spigot) build as of this morning, latest Bukkit-Connect (Proxy / Connect as-well) and latest Protocol Support.

Receive the following error:
https://hastebin.com/unopaheteb.md

Reported to ProtocolSupport developer, and simply told this is an incompatibility with LilyPad.

Description
Bukkit-Connect won't properly store the logout location of a player. If you login after a logout you will be teleported to the previous location.

Steps to reproduce
Get a fresh spigot 1.9.4 server with latest version of BukkitConnect and GoLilyPad. Login at location A, fly to location B, logout there, login again and see that you are at location A again.

so Im new with network syncing plugins and Im trying to sync LP between 2 servers, but when I start lilypad with the ip(17.0.0.1) and port 3306 and log in details of root, but when I start it, it spams the console with this

Caused by: java.lang.IndexOutOfBoundsException: readerIndex(47) + length(100) exceeds writerIndex(74): UnpooledHeapByteBuf(ridx: 47, widx: 74, cap: 74)
[10:11:00 WARN]: at io.netty.buffer.AbstractByteBuf.checkReadableBytes(AbstractByteBuf.java:1175)
[10:11:00 WARN]: at io.netty.buffer.AbstractByteBuf.readBytes(AbstractByteBuf.java:676)
[10:11:00 WARN]: at io.netty.buffer.AbstractByteBuf.readBytes(AbstractByteBuf.java:684)
[10:11:00 WARN]: at lilypad.packet.common.util.BufferUtils.readString(BufferUtils.java:50)
[10:11:00 WARN]: at lilypad.packet.connect.impl.RedirectPacketCodec.decode(RedirectPacketCodec.java:14)
[10:11:00 WARN]: at lilypad.packet.connect.impl.RedirectPacketCodec.decode(RedirectPacketCodec.java:7)
[10:11:00 WARN]: at lilypad.packet.common.PacketDecoder.decode(PacketDecoder.java:29)
[10:11:00 WARN]: at io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:249)
[10:11:00 WARN]: ... 18 more

did I do anything wrong or is there conflicting plugins?

Hello,

I was wondering what version of Bukkit-Connect to use at this is what happens on Spigot 1.8.3:

15.03 10:47:54 [Server] INFO Unable to start plugin - unsupported version?
15.03 10:47:54 [Server] WARN at java.lang.Thread.run(Thread.java:745)
15.03 10:47:54 [Server] WARN at net.minecraft.server.v1_8_R2.MinecraftServer.run(MinecraftServer.java:522)
15.03 10:47:54 [Server] WARN at net.minecraft.server.v1_8_R2.DedicatedServer.init(DedicatedServer.java:200)
15.03 10:47:54 [Server] WARN at org.bukkit.craftbukkit.v1_8_R2.CraftServer.enablePlugins(CraftServer.java:316)
15.03 10:47:54 [Server] WARN at org.bukkit.craftbukkit.v1_8_R2.CraftServer.loadPlugin(CraftServer.java:356)
15.03 10:47:54 [Server] WARN at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:405)
15.03 10:47:54 [Server] WARN at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:335)
15.03 10:47:54 [Server] WARN at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:321)
15.03 10:47:54 [Server] WARN at lilypad.bukkit.connect.ConnectPlugin.onEnable(ConnectPlugin.java:44)
15.03 10:47:54 [Server] WARN at lilypad.bukkit.connect.injector.PacketInjector.injectStringMaxSize(PacketInjector.java:31)
15.03 10:47:54 [Server] WARN java.lang.NullPointerException
15.03 10:47:54 [Server] INFO Enabling LilyPad-Connect v86

Bukkit-Connect needs updating to 1.11 bukkit/spigot versions.

[Connect] Unable to start plugin - unsupported version (v1_11_R1).

It hasn't built since 2017 by the looks of it, would be nice to not have to clone and build just for the jar.

Since upgrading to the latest version of GoLilypad and Bukkit-Connect I'm getting a NullPointerException here

Connect connect = getServer().getServicesManager().getRegistration(Connect.class).getProvider();

So I have a plugin that changes the Tablist Name of players, using the Player.setListName(String) method. Unfortunately, now all names are duplicated in the tablist. One for the new name, one for uncolored old name. This started happening when I updated Bukkit-Connect to Build 67. I then downgraded to Build 56. No problem on build 56. I would gather pictures but alas I don't have access to a PC at the moment (typing this on tablet).