liji32 / gbvideoplayer2 Goto Github PK

make SOURCE=vid.mp4
Compiling player...
rgbasm -o output/video.gbc.o video.asm
rgblink -o output/video.gbc -m output/video.map -n output/video.sym output/video.gbc.o
Compiling encoder...
cc -g -Ofast -std=c11 -Werror -Wall -o output/encoder encoder.c
Resizing video...
ffmpeg -loglevel warning -stats -hide_banner -i vid.mp4 -c:v rawvideo -vf scale=-2:144 output/vid/video.mp4.tmp.mp4
[mp4 @ 0x13a705360] Could not find tag for codec rawvideo in stream #0, codec not currently supported in container
Could not write header for output file #0 (incorrect codec parameters ?): Invalid argument
Error initializing output stream 0:0 --
[aac @ 0x13a707490] 2 frames left in the queue on closing
make: *** [output/vid/video.mp4] Error 1

Cant compile rom from source code

Sorry about sounding like a Karen, but I have no clue what the heck I do to compile this. I downloaded the source, and all of the recommended programs, loaded encoder.c into visual studio code, and then typed the command, and got an error.

Could you add ability to use mono sound instead of stereo?
Mono sound instead of stereo would half the audio size,
to further lower it, 2bit sound would also be nice... (since 2bit is still listenable)

Would it be possible to create an original Gameboy DMG version ?

I get several errors with rgbds-0.4.2 (or specific rgbasm) such as

ERROR: video.asm(117):
    syntax error
error: Assembly aborted (1 errors)!

or

ERROR: video.asm(446):
    syntax error
error: Assembly aborted (1 errors)!

These lines seem to be related to calculation including defined constant symbols, ie.

117: jp $ff00 + compression_jr
...
446: ld hl, $ff00 + current_line

Seems rgbds-0.4.2 doesn't like calculation with symbols.

Hi. Thanks for this amazing software!

When I try to compile it with gcc (8.3.0), I get the following error:

encoder.c: In function ‘main’:                                                                           
encoder.c:454:9: error: ignoring return value of ‘fread’, declared with attribute warn_unused_result [-Werror=unused-result]
         fread(rgb, sizeof(rgb), 1, in);
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors                                                                

As the warning says, the return value of fread is being ignored, and turns into an error because of the -Werror flag.

A simple fix is of course to remove that flag. I tried to add a simple return check for it in encoder.c, but for some reason that check always fails at the first frame. Apparently the code works without it though, so I'm hesitant to change anything there.