Complete quoting for parameters of some CMake commands about mcsema HOT 9 CLOSED

I would appreciate another constructive comment for remaining update candidates.

from mcsema.

elfring, this is the CMakeLists.txt file in the llvm38 branch: https://github.com/trailofbits/mcsema/blob/llvm38/CMakeLists.txt and this is where cmake is invoked: https://github.com/trailofbits/mcsema/blob/llvm38/bootstrap.sh#L111-L140

Are these satisfactory?

from mcsema.

I see that there are still update candidates left over also in build scripts from other project directories.

from mcsema.

Can you point them out in the llvm38 branch?

from mcsema.

How do you think about another example like ${MCSEMA_DIR}?

from mcsema.

Can you make your CMake fixes to the llvm38 branch and submit a PR?

from mcsema.

I am unsure when one of the affected scripts contains information like “…, all rights reserved.”.

from mcsema.

The license of all of the McSema codebase is a 3-clause BSD license. I have my source code editors auto add that. If that is not compatible with the license then please also submit a PR for those files, adding whatever the correct license header is required.

from mcsema.

I can not quickly determine if a licence information in a specific file is really inappropriate according to your intention.

from mcsema.