lifinance / contracts Goto Github PK

I noticed that in the PR #2 you added Milkomeda support, but have it commented out. Is there any plan to enable it?

Hey there! I've probably spotted a bug with the swapAndStartBridgeTokensViaHopL2ERC20 method ABI in https://github.com/lifinance/contracts/blob/main/diamondABI/diamond.json. If you flat the struct types you'll get

(bytes32,string,string,address,address,address,uint256,uint256,bool,bool),(address,address,address,address,uint256,bytes,bool)[],(uint256,uint256,uint256,uint256,uint256,address)

The function ID from that params will be 0x00d2aed6 what doesn't match the explorers (it says it should be 0xd40e64cc). Looks like the ABI is missing 3 more types there (address, uint256 and uint256). After adding them the function arguments look like

(bytes32,string,string,address,address,address,uint256,uint256,bool,bool),(address,address,address,address,uint256,bytes,bool)[],(uint256,uint256,uint256,uint256,uint256,address,address,uint256,uint256)

and produce the proper method signature (0xd40e64cc)

Hello,
Max approves in facets mean

https://github.com/lifinance/contracts/search?q=maxApproveERC20

that protocols are able to control assets of the proxy contract. Since integrated protocols could by buggy o malicious, isn't it too risky to give a maxApprove?

Thanks.

[error] invalid use case selected ('Did not find a Gradle, Maven, Bach, JBang or Ant project') - exiting script

Can someone guide me how to resolve this issue.