Checking for missed cron job? about cron HOT 7 CLOSED

Hi Troy,
Yes you can. Please test this:

Event::listen('cron.afterRun', function($rundate, $inTime, $runtime, $errors, $crons, $lastrun){
    if($inTime === -1) {
        // No previous Cron runs found, do you run Cron the first time?
    } elseif ($inTime) {
        // Cron was called in time, so don't worry
    } else {
        // Whoops, Cron is not in time! You need to check this. In this block you can for example log this error or write a mail
    }
});

from cron.

Will the $crons array return a list of all the jobs that where supposed to run and didn't if $inTime is false or will it return a list of all the jobs I have added to cron? If $inTime is false I would really need cron.afterRun to return the job names that were supposed to run but didn't because the system was unavailable to run it at the time it was supposed to.

from cron.

In looking through the code I noticed that you do retrieve the last date the Cron was run in $lastRun variable. I think that could be a helpful parameter if it was passed to the cron.afterRun. That way when $inTime was false I could do a comparison to see how much time has elapsed since the last Cron run and determinations can be made from there how to proceed with that information.

The issue is that I have a command that gets ran at a certain time of the day and sends out a text message when the Cron job executes. If this Cron job is not executed because the job was not ran I would need to make that determination in the cron.afterRun event I would want to call the command from that cron.afterRun event. If I have the previous run date and time to compare against the current run date and time I can then determine if the job that sends the text messages was supposed to be run within the time frame since the last Cron job was run.

from cron.

I added the $lastRun parameter to the cron.afterRun event. Please test.

from cron.

Since $lastrun does not get passed every time to the afterRun event you might want to update your documentation to look like this for the event:

Event::listen('cron.afterRun', function($rundate, $inTime, $runtime, $errors, $crons, $lastrun = null){

});

If not setup this way then the Laravel log will fill up with missing argument exceptions really quick.

Thanks for all your help. The enhancement works very well.

from cron.

You are right, Troy. It is not a good solution to add the $lastRun parameter to the event only if there was a Cron run before. I changed this with commit e894e8e, updated the test cases and corrected the readme file at the events section. Now you always get this event parameter but it could be an empty array. Please test again. Thank you for improving Cron.

from cron.

Closed due to inactivity.

from cron.