Comments (3)
Yes, this would be a nice feature. But you can use the cron.collectJobs
event for your purpose:
\Event::listen('cron.collectJobs', function() {
$date = date('Y-m-d', $rundate);
/** @var Holidays $holidays */
$holidays = new Holidays();
if ($holidays->isHoliday($date)) {
\Cron::add('HolidayJob1', '* * * * *', function() {
// Do some crazy things unsuccessfully every minute
return 'No';
});
\Cron::add('HolidayJob2', '* * * * *', function() {
// Do some crazy things unsuccessfully every minute
return 'No';
});
} else {
\Cron::add('RegularJob1', '* * * * *', function() {
// Do some crazy things unsuccessfully every minute
return 'No';
});
\Cron::add('RegularJob2', '* * * * *', function() {
// Do some crazy things unsuccessfully every minute
return 'No';
});
}
To my mind, this would be a cleaner way, because Cron is still running (and the in time check would still work) and if you need jobs during holidays, you can add them. Maybe this is a better way instead of disabling Cron completely. What do you think? Will this solution work for you?
from cron.
well, that makes a lot of sense 😃
I misinterpreted the event as fired just before every single cronjob. Looking into the code I found out it fires at the beginning of a complete run. So this can't work if you want to distinguish between jobs that should run and jobs that shouldn't (as you pointed out in your answer).
Therefore using the cron.collectJobs
event is indeed a better and cleaner position for making addional checks.
Thank you for making this clear 👍
from cron.
You are welcome :)
from cron.
Related Issues (20)
- Are tests working? HOT 2
- Incompatibility with Laravel 8, 9 HOT 1
- Exception with two closures on the same line of code HOT 3
- Symfony\Component\Console\Helper\HelperSet->get('table') HOT 3
- usage question: loading jobs from database HOT 3
- command cron:run/list error HOT 1
- Cron job running only one time HOT 3
- Pull request #80 not in composer package HOT 3
- trying to understand why I should use this over Laravel's built-in scheduler HOT 2
- Which user should run cron HOT 2
- Laravel 5.4 support HOT 3
- PHP Fatal error: Class 'App\Providers\Cron' not found in C:\xampp\htdocs\isend\blog\app\Providers\AppServiceProvider.php on line 33 HOT 3
- laravel5.2.45 install failed HOT 2
- passing variable to the function parameter before adding a cron HOT 5
- Have Undefined index while run the cron job!!! HOT 3
- Php artisan cron:run Not working HOT 13
- Can't use `artisan route:cache` because the built-in cron route uses a closure HOT 5
- [Laravel 5.6] Ambiguous class resolution warning HOT 10
- doesn't work with Laravel 5.8 HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cron.