Git Product home page Git Product logo

Comments (6)

liebig avatar liebig commented on July 25, 2024

Thanks for using Cron. Yes, I cut the return String after 500 characters.

} else if ($returnType === 'integer' || $returnType === 'double' || $returnType === 'string') {
    // We cut the string at 500 characters to not overcharge the database
    $jobEntry->return = substr((string) $job['return'], 0, 500);
}

I understand why you want to save more than 500 characters to the database and I want to change Crons behaviour. But maybe it would be better to remove the substr function call because you should know what you are doing with the return value ;)

} else if ($returnType === 'integer' || $returnType === 'double' || $returnType === 'string') {
    $jobEntry->return = (string) $job['return'];
}

One more config value would be overhead in my opinion. What do you thing? At the moment I am on a journey and I am not able to change the code. But I will return on 11.09 and then I can fix this. Of course I have an open mind about PRs ;)

from cron.

liebig avatar liebig commented on July 25, 2024

I changed the code and removed the truncating. Please update to head and test.

from cron.

MarkBaker avatar MarkBaker commented on July 25, 2024

Thanks for that, really appreciated.... I've updated the test system, and the existing schedules will click in sometime in the early hours of the morning, I'll be able to check the logs when I get to work tomorrow

from cron.

liebig avatar liebig commented on July 25, 2024

4 days have passed. Was the test successfully?

from cron.

MarkBaker avatar MarkBaker commented on July 25, 2024

So far, all successful (no scheduled tasks over the weekend), but Friday and Monday logged their result without any problems.... aside from this mornings run, which failed, for a totally different reason, but logged the fail reason successfully.... now I can modify my log viewer to display the result cleanly

from cron.

liebig avatar liebig commented on July 25, 2024

Perfect, thank you for your response.

from cron.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.