Git Product home page Git Product logo

Comments (11)

lokielse avatar lokielse commented on June 26, 2024

change the dir name

../vendor/liebig/cron/src/Liebig/Cron/facades

to

../vendor/liebig/cron/src/Liebig/Cron/Facades

from cron.

liebig avatar liebig commented on June 26, 2024

Hi Lokielse,

thank you for supporting Cron. If this does work, I will change the src dir name 'facades' to 'Facades' and will commit this. Maybe we can handle the linux issue #4 with renaming the src dir 'models' to 'Models' and the classes 'job.php' to 'Job.php' and 'manager.php' to 'Manager.php'? Can you test this, because I don't get this error with mit Linux Debian.

Thank You.

from cron.

lokielse avatar lokielse commented on June 26, 2024

Yes, It does! for psr-0 standards:

https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-0.md

from cron.

liebig avatar liebig commented on June 26, 2024

Okay, thank you. Then I will change all directories and files to first letter upper case spelling and I will remove the "require_once DIR . '/models/job.php'; require_once DIR . '/models/manager.php';" lines. I will test this with my windows and linux environment and will commit this. After that, could you test this again?

Thanks in advance!

from cron.

lokielse avatar lokielse commented on June 26, 2024

You should change the dir name and namespace name and all its usages

eg: Liebig\Cron\Models\Manager , Liebig\Cron\Models\Job, \Liebig\Cron\Models\Manager::

and the you'd better change the filenames: manager.php and job.php to Manage.php and Job.php all together.

with pleasure test i can do for it. :D

from cron.

ryanwinchester avatar ryanwinchester commented on June 26, 2024

Thanks for responses. Now we get:

ErrorException
include(/var/www/_sites/test/vendor/liebig/cron/src/Liebig/Cron/facades/Cron.php): failed to open stream: No such file or directory

But I guess that will be fixed when you finish renaming everything and updating the references? ;-)

from cron.

liebig avatar liebig commented on June 26, 2024

Yes, I am sorry for this issue. The 'facades' directory was not renamed. I hope everything should work now. Please update to head and test again.

@lokielse Now it's your turn, please update and test :) Thanks to both of you!

from cron.

ryanwinchester avatar ryanwinchester commented on June 26, 2024

Okay I am not getting any error messages after update, but when I go to

Route::get('cron/test', function()
{
    Cron::add('test_01', '* * * * *', function() {
        // Do some crazy things successfully every minute
    });

});

I don't see any jobs added to database. Is that where they are stored?

from cron.

liebig avatar liebig commented on June 26, 2024

I'm glad to hear that :) By default Cron logs error jobs to database only (jobs which not return null). You can change this behaviour by changing the value 'logOnlyErrorJobsToDatabase' in the Config file. But you can find an entry for each route call in the table 'cron_manager'. For more information about the usage, please read the README.md file.

from cron.

lokielse avatar lokielse commented on June 26, 2024

tests pass! no error anymore.

from cron.

liebig avatar liebig commented on June 26, 2024

Thank you very much for your support!

from cron.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.