licybora / nanocorefirefox Goto Github PK

Describe the issue (Required)

Firefox Version of Nano Adblock is not blocking all ads and does not display the number of blocked ads

Screenshots (Required)

Screenshot of console (Required, press F12 to open the console)

URLs where this issue occurs (Required if applicable)

https://www.youtube.com/watch?v=O4irXQhgMqg as an example

Reproduction Steps (Optional if trivial)

Anything else you believe to be useful (Optional)

Environment (Required)

• Operating System and Version: Win 10 ver 1809
• Browser and Version: 67.0.2 (64-bit)
• Nano Adblocker Version: Nano Adblocker 1.0.0.116
• Nano Defender Version (Optional if you are not using it): currently disabled

Your filter lists (Required)

All filters that come with nano adblocker except regionals ones

Nano Defender Integration​​​
Nano filters​​​
Nano filters – Annoyance​​​
Nano filters – Whitelist​​​
uBlock filters​​​
uBlock filters – Annoyances​​​
uBlock filters – Badware risks​​​
uBlock filters – Experimental​​​​​
uBlock filters – Privacy​​​
uBlock filters – Resource abuse​​​
uBlock filters – Unbreak​​
Adblock Warning Removal List​​​
AdGuard Base List​​​​
AdGuard Mobile Ads​​​​
EasyList​​​
Nano contrib filter – Placeholder buster​​​​​
AdGuard Tracking Protection​​
EasyPrivacy​​​
Fanboy's Enhanced Tracking List​
Malvertising filter list by Disconnect​​​​​​​
Malware Domain List
Malware domains​
AdGuard Annoyances​​​
AdGuard Social Media​​​
Anti-Facebook List​​​
Fanboy's Annoyance List​​​
Fanboy's Cookie List​​​
Fanboy's Social Blocking List
Dan Pollock's hosts file​
hpHosts' Ad and tracking servers​​​
NoCoin Filter List​​​
Peter Lowe's Ad and tracking server list​

Your custom filters (Required if you have any)

youtube.com#@#.ytp-ce-element
youtube.com#@#.video-annotations
youtube.com#@#.ytp-cards-teaser
youtube.com#@#.ytp-ce-playlist

Describe the issue (Required)

Nothing at all loads when Nano Adblocker is enabled. No pages, search engines, etc except domains restricted for webextensions (addons.mozilla.org, etc) loads. Even updating filter lists within the addon doesn't work.

Screenshots (Required)

Screenshot of console (Required, press F12 to open the console)

Later if needed

URLs where this issue occurs (Required if applicable)

All

Reproduction Steps (Optional if trivial)

1. Install Nano Adblocker on Firefox for Android.

2. Attempt to load any page.

Anything else you believe to be useful (Optional)

Environment (Required)

• Operating System and Version: Android P
• Browser and Version: 67.0.2 (Firefox for Android)
• Nano Adblocker Version: 1.0.0.116
• Nano Defender Version (Optional if you are not using it): n/a

Your filter lists (Required)

Default filters only

Your custom filters (Required if you have any)

Describe the issue (Required)

https://memoryhackers.org/ can block Nano adblocker

Screenshots (Required)

URLs where this issue occurs (Required if applicable)

https://memoryhackers.org/

Reproduction Steps (Optional if trivial)

Have nano adblocker enabled and try to access https://memoryhackers.org/

Environment (Required)

• Operating System and Version: W10
• Browser and Version: Firefox latest
• Nano Adblocker Version: Latest
• Nano Defender Version (Optional if you are not using it): Latest

Should you have any problem, ask in Defender repository in the meantime.

Describe the issue (Required)

Firefox Android disabled nano ad block after the update with a signature verification error requiring a manual override in about:config to get it working again

Screenshots (Required)

Screenshot of console (Required, press F12 to open the console)

URLs where this issue occurs (Required if applicable)

Reproduction Steps (Optional if trivial)

Anything else you believe to be useful (Optional)

Environment (Required)

• Operating System and Version: Android 6.0.1
• Browser and Version: Firefox 68.8.1
• Nano Adblocker Version: 1.0.0.148
• Nano Defender Version (Optional if you are not using it): 15.0.0.199

Your filter lists (Required)

Your custom filters (Required if you have any)

Your other extensions (Required if you have any)

As at gorhill/uBlock@34a138e, new permission is added since 1.18.9rc2.

Better to wait until 1.18.10 rollout, which uBO's decision on new permission is final and widely spread.

This is a continuation of NanoAdblocker#130

Describe the issue (Required)

Neither copy nor paste can be chosen in editor of My filters. Even selecting a single line of rule is usually problematic (either nothing can be selected, or everything are selected).

Screenshots (Required)

Later or see from link above.

Screenshot of console (Required, press F12 to open the console)

Later.

URLs where this issue occurs (Required if applicable)

None.

Reproduction Steps (Optional if trivial)

1. Open My filters in Nano Adblocker on Firefox Android
2. Long click any rules or comment, or even empty space, wondering why everything are highlighted but no option for copy/paste (or either nothing can be highlighted).

Anything else you believe to be useful (Optional)

Only occurs in My filters but not My rules, Whitelist or any advance setting.

Environment (Required)

• Operating System and Version: Android P
• Browser and Version: Firefox 66.0.5
• Nano Adblocker Version: 1.0.0.109
• Nano Defender Version (Optional if you are not using it): Not important

Describe the issue (Required)

Extra resources of nano (e.g. nanop-click-elements-onready.js) mostly don't work when using it in own filters (and setting advanced setting ""). While the exact same rules do work in chrome. So looks like problem with firefox version to use these extra resources correctly?

Screenshots (Required)

Screenshot of console (Required, press F12 to open the console)

URLs where this issue occurs (Required if applicable)

https://radar.avrotros.nl/
https://www.gelderlander.nl

Reproduction Steps (Optional if trivial)

Go to site and see cookie wall/cookie message not getting clicked. Do it in chrome and the button will get clicked.

Anything else you believe to be useful (Optional)

Environment (Required)

• Operating System and Version: Win 7
• Browser and Version: Firefox/Waterfox latest
• Nano Adblocker Version: latest
• Nano Defender Version (Optional if you are not using it): lateset

Your filter lists (Required)

ootb

Your custom filters (Required if you have any)

avrotros.nl##+js(nanop-click-elements-onload.js, button.ccm_btn:nth-child(1))
myprivacy.persgroep.net##+js(nanop-click-elements-onready.js, button.button:nth-child(3))

As of now, NanoCore is in version v1.0.0.153
Features:

• → Updated script snippets and web accessible resources ←
• Updated filters
• Cherry-picked gorhill/uBlock@d49a9dc

I first reported this on NanoCore, Issue #294, and was told to make it here instead, as it only seems to affect Firefox for me.

Describe the issue (Required)

At random, the entire browser will act like the nothing on the Internet is responding. Like the router is frozen for a minute... but I've gone down a rabbit hole to figure out that it's NanoAdblocker.

Screenshots (Required)

Screenshot of console (Required, press F12 to open the console)

URLs where this issue occurs (Required if applicable)

All URLs.

Reproduction Steps (Optional if trivial)

This happens randomly, and I haven't figured out how to reproduce it on demand yet. Which makes this bug all the more irritating.

1. I will click on a link, or open a new tab or window to go to a new address. Nothing out of the ordinary, only regular internet browsing for work.
2. Firefox will start acting like the internet is taking an extremely long time to respond. Not just the link I clicked on, but any other link, opening new windows, etc.
3. Clicking on the NanoAdblocker extension
4. After roughly 60 seconds or so, NanoAdblocker starts responding, and all of the tabs I opened waiting for the internet to respond, start working at the same time. (I could time this if it would be useful.)

Anything else you believe to be useful (Optional)

For weeks now, I thought this was my internet connection, either my ISP or my router. Not like the connection has been broken, but like the packets are taking forever to respond, across all open Firefox tabs. The issue acts exactly like that would be the case, and I was preparing to plunk down a ton of money on replacing the router. So here's how I figured out that it's this extension:

Yesterday when it happened, I switched from my MacBook Pro to my PC, and realized that Firefox on it (with NanoAdblocker installed there too) was working just fine. That narrowed it down to the MacBook somehow.

So the second time it happened yesterday, I opened up Chrome, which has uBlock on it. That browser wasn't having issues either. I was also able to use curl and ping from the terminal without issues, so that narrowed it down to Firefox.

The third time it happened, I opened up a Private Browsing window. The issue was happening there. But the only extension I allow to run in Private Browsing was NanoAdblocker. (FWIW, I also have Nano Defender installed and running in Private Browsing, I haven't ruled it out yet). So I disabled it from Private Browsing and waited for the fourth time.

When the fourth time happened, I opened a new Private Browsing window in Firefox, and it was able to go to the same link I had been trying. Back in my regular Firefox window, I clicked on NanoAdblocker, and found that it was rendering only the outline of the dropdown, but none of the content inside it was loading.

Environment (Required)

• Operating System and Version: macOS Mojave 10.14.6
• Browser and Version: Firefox 70.0.1 (64-bit)
• Nano Adblocker Version: 1.0.0.131
• Nano Defender Version: 15.0.0.170

Your filter lists (Required)

Your custom filters (Required if you have any)

None here.

Your other extensions (Required if you have any)

• 1Password
• Bypass Paywalls
• Facebook Container
• Firefox Multi-Account Containers
• HTTPS Everywhere
• RescueTime for Firefox

Only NanoAdblocker and Nano Defender are enabled to run in Private Browsing.

#24 - changed to minimalize risk?

  "browser_specific_settings": {
    "gecko": {
      "id": "{0f929014-5ed2-4527-8b8d-86a9c889b129}",
      "update_url": "https://github.com/LiCybora/NanoCoreFirefox/issues",
      "strict_min_version": "55.0"
    }
  }
}

should be one from these:

https://github.com/LiCybora/NanoCoreFirefox/raw/master/Extension%20Compiler/updates.json

https://raw.githubusercontent.com/LiCybora/NanoCoreFirefox/master/Extension%20Compiler/updates.json

I find myself spending over half an hour a day just to handle the day to day maintenance of my projects, and I want to change that. I want to have time to actually develop my projects, especially with Manifest V3 changes coming, my current setup is nowhere near ready to handle that.

As a first step, I will start to use Renovate to manage dependencies. I am receiving a dozen vulnerability alerts from GitHub every week, although I don't believe any of them is true positive, having noise in vulnerability reports is not very good.

I will be automating more and more of my daily maintenance tasks through GitHub Apps, Continuous Integration, and NanoMeow. These changes will probably not affect you, this is just a heads up so you know what will be coming.

Describe the issue (Required)

Every time a change is made to "My Filters" (when a filter needs to be temporarily commented out, for example) Nano Adblocker keeps scrolling to the end of the filter list and one has to scroll back and find the place one was editing before. After a few saves like that it gets annoying pretty quick, especially if the filter list is long enough.

Screenshots (Required)

Screenshot of console (Required, press F12 to open the console)

URLs where this issue occurs (Required if applicable)

"My Filters" section of the Nano Adblocker

Reproduction Steps (Optional if trivial)

1. Open the Nano Adblocker and go to the "My Filters" section. Create a filter list that takes several pages there.
2. Scroll to the beginning of the list and make a small change
3. Press the "Apply Changes" button or press Ctrl+S
4. You will see that Nano Adblocker will save the change but will also scroll to the bottom of the filter list thus losing the place where the edit was made. If one is testing something and has to repeatedly comment/uncomment the same filter in the middle of the list, the unrequested scroll to the bottom of the filter list is unnecessary and annoying.

Anything else you believe to be useful (Optional)

Environment (Required)

• Operating System and Version: Debian 10 Buster
• Browser and Version: 78.3.0esr (64-bit)
• Nano Adblocker Version: 1.0.0.151
• Nano Defender Version (Optional if you are not using it): none

Your filter lists (Required)

Your custom filters (Required if you have any)

Just a quick heads up about the selfie magic, upstream seems to have changed it, so you may need to change it again on the next release.

Describe the issue (Required)

Both nano adblocker and ublockorigin are not compatible with windscribe vpn addon,
If i enable both extensions at the same time and restart my browser the current tab will refresh itself automatically.

Screenshots (Required)

Screenshot of console (Required, press F12 to open the console)

URLs where this issue occurs (Required if applicable)

Reproduction Steps

-->
Install windscribe addon
And sigin and then restart your browser

Anything else you believe to be useful

Maybe windscribe also disable ads that's why it is not compatible with other adblockers

Environment (Required)

• Operating System and Version: windows 10
• Browser and Version: firefox x64 66.0.3
• Nano Adblocker Version: latest
• Nano Defender Version (Optional if you are not using it): latest

Your filter lists (Required)

Default settings only

Your custom filters (Required if you have any)

Hello @LiCybora thanks for maintaining nano all this time. I was wondering if you'd be open if I sent you a simple design update of the D and N hexagons. I'll just give it a contemporary clean look without changing the overall design idea so they look aligned and together, especially as icons in the toolbar.

Describe the issue (Required)

Addon after update no add "block element" in right click menu.

Screenshots (Required)

N/A

Screenshot of console (Required, press F12 to open the console)

N/A

URLs where this issue occurs (Required if applicable)

N/A

Reproduction Steps (Optional if trivial)

N/A

Anything else you believe to be useful (Optional)

N/A

Environment (Required)

• Operating System and Version: Windows 7 Pro
• Browser and Version: FX 70.0.1
• Nano Adblocker Version: 1.0.0.130
• Nano Adblocker installed from: Mozilla store

Your filter lists (Required)

N/A

Your custom filters (Required if you have any)

N/A

Some users do not happy with the extra configuration on uBO with ND and just want NA to install and forget as they used in other browser. Before the goal achieve, the following has to be done:

• Patch innerHTML assignment in ace.js
• Handle integration with ND
• Grant official permission from upstream
• Not applying Chromium specific patch

The first one can be update acejs to v1.4.2, but it create another issue that I am unwilling to deal with. Require manually grab innerHTML assignement removal commits and apply to v1.2.9 (currently in use in upstream).

The second one is likely I trapped myself as the ND from GitHub hosted and AMO using different extension ID (currently, NA from here will not auto-enable integration during ND on AMO is installed). I still need a GitHub hosted version to take care the existing user, so will create new version of NA on AMO. For simplicity, NA in AMO will only integrate ND from AMO and vice versa. If user download one from AMO and one from GitHub....then good luck for them to manually enable integration list.

I will ask for the permission once everything are ready.

The final one is done but require double check.

Describe the issue (Required)

lequipe.fr does not show the same infos wether or not nano adblocker is enabled. This can be verified accessing https://www.lequipe.fr /Football/ and following the link "Voir les directs" which is supposed to give in real-time the evolution of score during games. When nano adblocker is enabled the scores are sticky and remain live when desabling nano adb.

Screenshots (Required)

Screenshot of console (Required, press F12 to open the console)

[Nano] Nano Defender Activated :: www.lequipe.fr core.js:43:24
[Nano] Excluded :: uBO-Extra rules-common.js:306:28
Échec du chargement pour l’élément <script> dont la source est « https://www.lequipe.fr/js/app.f565b1b62be6a2c5cdd0.js ». Football:1127:1
Échec du chargement pour l’élément <script> dont la source est « https://www.lequipe.fr/js/vendors.f565b1b62be6a2c5cdd0.js ».

Environment (Required)

• Operating System and Version: Windows 10
• Browser and Version: FF 72.0.1
• Nano Adblocker Version: 1.0.0.134
• Nano Defender Version (Optional if you are not using it): 15.0.0.177

Your filter lists (Required)

standard filters only.

Your custom filters (Required if you have any)

Copying multiple lines from My Filters to the outside so far doesn't work, like to an editor like Notepad. Already tried these below:

• Firefox' Edit, Select All, Copy.
• Firefox' Edit, Select All, right mouse button, Copy.
• Left mouse click to put the cursor in the My Filters area. CTRL+A. CTRL+C.
• Left mouse click to put the cursor in the My Filters area. CTRL+A. Right mouse button, Copy.
• Left mouse click to put the cursor in the My Filters area. Right mouse button, Select All, Copy.

Possible results to the outside after pasting:

• Only the last line is pasted.
• The previous clipboard content is pasted form whatever it originated from, not the multiple lines desired from My Filters.
• Nothing is pasted, or just a middle dot (a unicode middle dot?).

These related action(s) work:

• My Filters accepts and saves one or many lines from the outside. Like say after I sorted the lines alphabetically and auto-removed duplicates with an editor.

My versions:

• Firefox 78.0. I'm still waiting a bit more for possible versions higher than 78.0.1, to save internet data.
• Nano Adblocker 1.0.0.148
• Nano Defender 15.0.0.200
• Windows, 64 bit

Related:

• Such issue is nonexistent in uBO, in the same Firefox and OS. I never experienced such from my very first usage of its own My Filters.
• The very first time I tried to copy from Nano's My Filters, the issue was immediately there. I can't remember how many versions back when I first ever tried to copy. The issue was already there back, way below Firefox v78.0. I just ended up using my workaround below.

My workaround:

• From My Filters, Export. Then open the exported text file with for example Notepad to get its contents.

Thanks in advance, and more power.☺

Describe the issue (Required)

I am not able to open the "Block element..." interface.
Screenshots (Required)

https://user-images.githubusercontent.com/52380472/60399303-1bf25280-9b52-11e9-8302-a2bab170e543.png

https://user-images.githubusercontent.com/52380472/60399304-1d237f80-9b52-11e9-92a1-6b1a5252ae44.png

Screenshot of console (Required, press F12 to open the console)

https://user-images.githubusercontent.com/52380472/60399276-b56d3480-9b51-11e9-97fc-2fabab0fdfbc.png

URLs where this issue occurs (Required if applicable)

Reproduction Steps (Optional if trivial)

Anything else you believe to be useful (Optional)

Environment (Required)
Operating System and Version: Windows 7 Ultimate, SP1
Browser and Version: Firefox, 67.0.4, 64-bit
Nano Adblocker Version: 1.0.0.117
Nano Defender Version (Optional if you are not using it): 15.0.0.153

Your filter lists (Required)
Adguard annoyances

Anti-Facebook List
Fanboy's Social Blocking List
Your custom filters (Required if you have any)
Adblock the NSA

Your other extensions (Required if you have any)
HTTPS Everywhere
Decentraleyes
Facebook Container
Nano Defender
Tampermonkey
Imagus
Private Bookmarks
Image Search Options

From uBlock Origin 1.28 is no longer possible to point-and-click to create allow (green) rules from within the popup panel.
Is there any chance that this feature will remain in Nano Defender? or are we too closed to the base code?

Describe the issue (Required)

The issue is in the title.... on recent days mozilla developers as release a totally new version of firefox for android devices.
In this news version there's addons it's not anymore compatible:

• https://addons.mozilla.org/en-US/firefox/addon/nano-adblocker-firefox/
• Nano Defender

Thanks for some feedback in future.

Eg link: https://forum.xda-developers.com/showthread.php?t=2263392
OS: Android 9
Platform: Firefox (note this issue doesn't happen on the chromium-based browser)

Everything else is just default so, no point typing all that.

Edit: Sorry, my bad. Everything else was not default, I had additional placeholder buster in Firefox, while it wasn't enabled on kiwi (Chromium-based browser). After enabling it in Kiwi it's happening there too, so it's NOT Firefox only issue.
I'm sorry again.

Describe the issue (Required)

Detached logger window shown as blank until resize or right click. This is known as browser bug and just open here for record.

Screenshots (Required)

Screenshot of console (Required, press F12 Ctrl+Shift+J [Cmd+Shift+J on Mac] to open the console)

URLs where this issue occurs (Required if applicable)

Not important.

Reproduction Steps (Optional if trivial)

1. Open logger. If it is open in new tab, close it, press shift and click logger will open it on detached window.
2. See a blank log console.
   Note: Reproduce fail if the console is opened and fixed to window (e.g.: F12 pressed)

Anything else you believe to be useful (Optional)

Browser bug. See: https://bugzilla.mozilla.org/show_bug.cgi?id=1408446

Environment (Required)

• Operating System and Version: Debian 9.4 on VirtualBox (cannot reproduce on macOS)
  • Update: can be reproduced on macOS with Firefox 60 (include ESR), but fixed on 61 or above (macOS only)
• Browser and Version: Firefox 60 ESR, 61.0 and 62.0b3
• Nano Adblocker Version: 1.0.0.54
• Nano Defender Version (Optional if you are not using it): Does not matter

how to sync or backup addons Nano Defender for Firefox and addons Nano Adblocker Core for Firefox?

v1.0.0.122 is ready for test. Due to the large amount of changes, make sure to clean existing build output as the build scripts do not automatically handle that. In general, I recommend to do a clean for every version update.

Let me know if something blows up.

I am just here to thank you for your time. I really enjoyed the extension as long as it lasted.

♥