lichthund / citizenscmd Goto Github PK

Hello,

I use LuckPerms as PermissionManager.

CitizenCMD is 2.1.

It seems permission for cmd list is misspelled. Here my luckperm report:

It seems the permission for list is citizescmd.list and not citizenscmd.list

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Versions (please complete the following information):

• Citizens version
• Spigot version
• CitizensCMD version
• Java version

Additional context
Add any other context about the problem here.

Describe the bug
The link on the page about migrating from 1.2.2 to 2.0 is broken
To Reproduce
Steps to reproduce the behavior:
check it here:
https://github.com/ipsk/CitizensCMD/wiki/Migrating-from-CitizensCMD-1.2.2-to-CitizensCMD-2.0

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Versions (please complete the following information):

• Citizens version
• Spigot version
• CitizensCMD version
• Java version

Additional context
Add any other context about the problem here.

Title basically, I'd like to give a different cooldown to each command I have bound to an NPC. For example: /npcmd cooldown left/right 1/2/3/etc (cooldown number here). The following would also work: /npcmd cooldown all (cooldown number here) which sets the cooldown to that number for all added commands, so you wouldn't have to give each one a cooldown individually, should you need to have all commands be the same cooldown.

Got this error when startup
[CitizensCMD] Plugin CitizensCMD v2.3.2 has failed to register events for class me.mattstudios.citizenscmd.listeners.NPCListener because net/citizensnpcs/api/event/NPCCloneEvent does not exist.

• Citizens 2.0.24 (1.13.2 BETA #2)
• Paper Spigot 1.13.2
• CitizensCMD 2.3.2
• Java 8

Converter is either not online or not working, I'm going to the website, but it's offline.

Describe the bug

I get a error message in the console while lanuching my 1.13 spigot server. When it's enabling CitizensCMD and then trying to find Citizens but it fails which leads to that CitizensCMD gets disabled.

To Reproduce

Steps to reproduce the behavior:

1. Start the server
2. Wait for it to load
3. CitizensCMD is getting enabled
4. Error from Console:

[18:51:55 INFO]: [CitizensCMD] Enabling CitizensCMD v2.1
[18:51:55 INFO]: [CitizensCMD] Citizens is needed for this plugin to work!
[18:51:55 INFO]: [CitizensCMD] Citizens.jar is not installed on the server!
[18:51:55 INFO]: [CitizensCMD] Disabling CitizensCMD...
[18:51:55 INFO]: [CitizensCMD] Disabling CitizensCMD v2.1
[18:51:55 ERROR]: Error occurred while disabling CitizensCMD v2.1 (Is it up to d
ate?)
java.lang.NullPointerException: null
        at me.mattmoreira.citizenscmd.CitizensCMD.onDisable(CitizensCMD.java:215
) ~[?:?]
        at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:266) ~[s
pigot-1.13.jar:git-Spigot-fe3ab0d-3418f8d]
        at org.bukkit.plugin.java.JavaPluginLoader.disablePlugin(JavaPluginLoade
r.java:363) [spigot-1.13.jar:git-Spigot-fe3ab0d-3418f8d]
        at org.bukkit.plugin.SimplePluginManager.disablePlugin(SimplePluginManag
er.java:422) [spigot-1.13.jar:git-Spigot-fe3ab0d-3418f8d]
        at me.mattmoreira.citizenscmd.CitizensCMD.onEnable(CitizensCMD.java:81)
[CitizensCMD.jar:?]
        at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:264) [sp
igot-1.13.jar:git-Spigot-fe3ab0d-3418f8d]
        at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader
.java:339) [spigot-1.13.jar:git-Spigot-fe3ab0d-3418f8d]
        at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManage
r.java:403) [spigot-1.13.jar:git-Spigot-fe3ab0d-3418f8d]
        at org.bukkit.craftbukkit.v1_13_R1.CraftServer.enablePlugin(CraftServer.
java:426) [spigot-1.13.jar:git-Spigot-fe3ab0d-3418f8d]
        at org.bukkit.craftbukkit.v1_13_R1.CraftServer.enablePlugins(CraftServer
.java:340) [spigot-1.13.jar:git-Spigot-fe3ab0d-3418f8d]
        at net.minecraft.server.v1_13_R1.MinecraftServer.m(MinecraftServer.java:
562) [spigot-1.13.jar:git-Spigot-fe3ab0d-3418f8d]
        at net.minecraft.server.v1_13_R1.MinecraftServer.g_(MinecraftServer.java
:524) [spigot-1.13.jar:git-Spigot-fe3ab0d-3418f8d]
        at net.minecraft.server.v1_13_R1.MinecraftServer.a(MinecraftServer.java:
423) [spigot-1.13.jar:git-Spigot-fe3ab0d-3418f8d]
        at net.minecraft.server.v1_13_R1.DedicatedServer.init(DedicatedServer.ja
va:288) [spigot-1.13.jar:git-Spigot-fe3ab0d-3418f8d]
        at net.minecraft.server.v1_13_R1.MinecraftServer.run(MinecraftServer.jav
a:686) [spigot-1.13.jar:git-Spigot-fe3ab0d-3418f8d]
        at java.lang.Thread.run(Unknown Source) [?:1.8.0_181]

Expected behavior

The plugin should load in with Citizens but it doesnt, it just gets disabled. So I thought there were some problems with the Citizens.jar file but i downloaded the latest one, but I got the same error and CitizensCMD got disabled once more.

Screenshots

All my plugins (may help, but I don't think so myself):

Versions

• Citizens version: citizens-2.0.24-SNAPSHOT.jar
• Spigot version: spigot-1.13-R0.1-SNAPSHOT-b1851.jar
• CitizensCMD version: CitizensCMD v2.1
• Java version: Java 8 (build: 1.8.0_181-b13)

Additional context

I thought that it needed the Citizens file to be called exactly Citizens.jar but that doesn't make any difference. I have tried both Citizens.jar & citizens.jar

Paper dev 175 (Spigot 1.14.4)
Citizens2 dev 1744
CitizensCMD v2.3.2

[11:14:55] [Server thread/ERROR]: Exception when mibby attempted to tab complete npcmd remove left 
org.bukkit.command.CommandException: Unhandled exception during tab completion for command '/npcmd remove left ' in plugin CitizensCMD v2.3.2
	at org.bukkit.command.PluginCommand.tabComplete(PluginCommand.java:150) ~[patched_1.14.4.jar:git-Paper-175]
	at org.bukkit.command.Command.tabComplete(Command.java:93) ~[patched_1.14.4.jar:git-Paper-175]
	at org.bukkit.command.SimpleCommandMap.tabComplete(SimpleCommandMap.java:244) ~[patched_1.14.4.jar:git-Paper-175]
	at org.bukkit.craftbukkit.v1_14_R1.CraftServer.tabCompleteCommand(CraftServer.java:1716) ~[patched_1.14.4.jar:git-Paper-175]
	at org.bukkit.craftbukkit.v1_14_R1.CraftServer.tabComplete(CraftServer.java:1688) ~[patched_1.14.4.jar:git-Paper-175]
	at org.bukkit.craftbukkit.v1_14_R1.command.BukkitCommandWrapper.getSuggestions(BukkitCommandWrapper.java:49) ~[patched_1.14.4.jar:git-Paper-175]
	at com.mojang.brigadier.tree.ArgumentCommandNode.listSuggestions(ArgumentCommandNode.java:71) ~[patched_1.14.4.jar:git-Paper-175]
	at com.mojang.brigadier.CommandDispatcher.getCompletionSuggestions(CommandDispatcher.java:596) ~[patched_1.14.4.jar:git-Paper-175]
	at com.mojang.brigadier.CommandDispatcher.getCompletionSuggestions(CommandDispatcher.java:579) ~[patched_1.14.4.jar:git-Paper-175]
	at net.minecraft.server.v1_14_R1.PlayerConnection.lambda$a$3(PlayerConnection.java:563) ~[patched_1.14.4.jar:git-Paper-175]
	at net.minecraft.server.v1_14_R1.TickTask.run(SourceFile:18) ~[patched_1.14.4.jar:git-Paper-175]
	at net.minecraft.server.v1_14_R1.IAsyncTaskHandler.executeTask(IAsyncTaskHandler.java:136) ~[patched_1.14.4.jar:git-Paper-175]
	at net.minecraft.server.v1_14_R1.IAsyncTaskHandlerReentrant.executeTask(SourceFile:23) ~[patched_1.14.4.jar:git-Paper-175]
	at net.minecraft.server.v1_14_R1.IAsyncTaskHandler.executeNext(IAsyncTaskHandler.java:109) ~[patched_1.14.4.jar:git-Paper-175]
	at net.minecraft.server.v1_14_R1.MinecraftServer.aX(MinecraftServer.java:1013) ~[patched_1.14.4.jar:git-Paper-175]
	at net.minecraft.server.v1_14_R1.MinecraftServer.executeNext(MinecraftServer.java:1006) ~[patched_1.14.4.jar:git-Paper-175]
	at net.minecraft.server.v1_14_R1.IAsyncTaskHandler.awaitTasks(IAsyncTaskHandler.java:119) ~[patched_1.14.4.jar:git-Paper-175]
	at net.minecraft.server.v1_14_R1.MinecraftServer.sleepForTick(MinecraftServer.java:990) ~[patched_1.14.4.jar:git-Paper-175]
	at net.minecraft.server.v1_14_R1.MinecraftServer.run(MinecraftServer.java:923) ~[patched_1.14.4.jar:git-Paper-175]
	at java.lang.Thread.run(Thread.java:748) [?:1.8.0_222]
Caused by: java.lang.NullPointerException
	at me.mattstudios.citizenscmd.files.DataHandler.getCompleteCommandsNumbers(DataHandler.java:364) ~[?:?]
	at me.mattstudios.citizenscmd.utility.Util.getTabCompleteArgs(Util.java:169) ~[?:?]
	at me.mattstudios.citizenscmd.commands.base.CommandHandler.getCommandNames(CommandHandler.java:216) ~[?:?]
	at me.mattstudios.citizenscmd.commands.base.CommandHandler.onTabComplete(CommandHandler.java:177) ~[?:?]
	at org.bukkit.command.PluginCommand.tabComplete(PluginCommand.java:141) ~[patched_1.14.4.jar:git-Paper-175]
	... 19 more

Describe the bug
A clear and concise description of what the bug is.

It looks like its trying to load before Citizens is loaded, complaining that Citizens isnt installed, and then disabling itself.
Enabling it with the use of Plugman after the server is loaded causes no issues and the plugin then continues to work properly

To Reproduce
Steps to reproduce the behavior:

1. Turn server on
2. CitizensCMD tries to load before Citizens
3. It disables itself

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Versions (please complete the following information):

• Citizens version
• Spigot version
• CitizensCMD version
• Java version

https://pastebin.com/RV32aQnL

Additional context
Add any other context about the problem here.

[10:24:59 WARN]: java.lang.ClassCastException: Cannot cast net.citizensnpcs.nms.v1_14_R1.entity.PufferFishController$EntityPufferFishNPC to net.minecraft.server.v1_14_R1.EntityFishSchool [10:24:59 WARN]: at java.lang.invoke.MethodHandleImpl.newClassCastException(MethodHandleImpl.java:361) [10:24:59 WARN]: at java.lang.invoke.MethodHandleImpl.castReference(MethodHandleImpl.java:356) [10:24:59 WARN]: at net.citizensnpcs.nms.v1_14_R1.util.NMSImpl.setNotInSchool(NMSImpl.java:1607) [10:24:59 WARN]: at net.citizensnpcs.nms.v1_14_R1.entity.PufferFishController$EntityPufferFishNPC.mobTick(PufferFishController.java:178) [10:24:59 WARN]: at net.minecraft.server.v1_14_R1.EntityInsentient.doTick(EntityInsentient.java:668) [10:24:59 WARN]: at net.minecraft.server.v1_14_R1.EntityLiving.movementTick(EntityLiving.java:2528) [10:24:59 WARN]: at net.minecraft.server.v1_14_R1.EntityInsentient.movementTick(EntityInsentient.java:504) [10:24:59 WARN]: at net.minecraft.server.v1_14_R1.EntityFish.movementTick(EntityFish.java:113) [10:24:59 WARN]: at net.minecraft.server.v1_14_R1.EntityPufferFish.movementTick(EntityPufferFish.java:97) [10:24:59 WARN]: at net.minecraft.server.v1_14_R1.EntityLiving.tick(EntityLiving.java:2317) [10:24:59 WARN]: at net.minecraft.server.v1_14_R1.EntityInsentient.tick(EntityInsentient.java:275) [10:24:59 WARN]: at net.minecraft.server.v1_14_R1.EntityPufferFish.tick(EntityPufferFish.java:92) [10:24:59 WARN]: at net.minecraft.server.v1_14_R1.WorldServer.entityJoinedWorld(WorldServer.java:579) [10:24:59 WARN]: at net.minecraft.server.v1_14_R1.World.a(World.java:933) [10:24:59 WARN]: at net.minecraft.server.v1_14_R1.WorldServer.doTick(WorldServer.java:354) [10:24:59 WARN]: at net.minecraft.server.v1_14_R1.MinecraftServer.b(MinecraftServer.java:1192) [10:24:59 WARN]: at net.minecraft.server.v1_14_R1.DedicatedServer.b(DedicatedServer.java:420) [10:24:59 WARN]: at net.minecraft.server.v1_14_R1.MinecraftServer.a(MinecraftServer.java:1064) [10:24:59 WARN]: at net.minecraft.server.v1_14_R1.MinecraftServer.run(MinecraftServer.java:908) [10:24:59 WARN]: at java.lang.Thread.run(Thread.java:748)

Simple!

left-click-commands:
- '[particle] FLAME 25 0.01'

Im setting up a merchant, that if you left click i want to send the player a message, and right click will activate the payment, the problem is, if you set a payment you can no longer left click, it will right click and then it will run the left click command! This makes no sense, should the price have left/right click setting?

Not sure how this would be done but maybe add a command feedback setting where in your command the NPC does include
%input%
for example

npc-2:
cooldown: 3
right-click-commands:
- '[message] NPC: Which vault would you like to access?'
- '[inputcommand] [vault.use] vault %input%'

and that would ask you which vault and you'd reply in chat with a number and then you will do the command " /vault (number) " the vault.use is also just the permission to actually use the command with the input so vaults can be tied to an NPC so players can't just do /vault 1 everywhere sorta thing.

This is just an example though.

greetings
i get this error in console and npcs in game doesn't respond

[Server] Server thread/INFO [CitizensCMD] Enabling CitizensCMD v2.4
04.10 11:08:34 [Server] Server thread/ERROR Error occurred while enabling CitizensCMD v2.4 (Is it up to date?)
04.10 11:08:34 [Server] INFO java.lang.NoSuchMethodError: org.apache.commons.io.FileUtils.copyInputStreamToFile(Ljava/io/InputStream;Ljava/io/File;)V
04.10 11:08:34 [Server] INFO at me.mattstudios.citizenscmd.utility.YamlUtils.copyDefaults(YamlUtils.java:25) ~[?:?]
04.10 11:08:34 [Server] INFO at me.mattstudios.citizenscmd.CitizensCMD.onEnable(CitizensCMD.java:89) ~[?:?]
04.10 11:08:34 [Server] INFO at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:263) ~[spigot-1.14.4.jar:git-Spigot-94af569-a3fdef8]
04.10 11:08:34 [Server] INFO at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:352) [spigot-1.14.4.jar:git-Spigot-94af569-a3fdef8]
04.10 11:08:34 [Server] INFO at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:417) [spigot-1.14.4.jar:git-Spigot-94af569-a3fdef8]
04.10 11:08:34 [Server] INFO at org.bukkit.craftbukkit.v1_14_R1.CraftServer.enablePlugin(CraftServer.java:461) [spigot-1.14.4.jar:git-Spigot-94af569-a3fdef8]
04.10 11:08:34 [Server] INFO at org.bukkit.craftbukkit.v1_14_R1.CraftServer.enablePlugins(CraftServer.java:375) [spigot-1.14.4.jar:git-Spigot-94af569-a3fdef8]
04.10 11:08:34 [Server] INFO at net.minecraft.server.v1_14_R1.MinecraftServer.a(MinecraftServer.java:449) [spigot-1.14.4.jar:git-Spigot-94af569-a3fdef8]
04.10 11:08:34 [Server] INFO at net.minecraft.server.v1_14_R1.DedicatedServer.init(DedicatedServer.java:266) [spigot-1.14.4.jar:git-Spigot-94af569-a3fdef8]
04.10 11:08:34 [Server] INFO at net.minecraft.server.v1_14_R1.MinecraftServer.run(MinecraftServer.java:775) [spigot-1.14.4.jar:git-Spigot-94af569-a3fdef8]
04.10 11:08:34 [Server] INFO at java.lang.Thread.run(Thread.java:748) [?:1.8.0_222]

after testing over and over again, removing all plugins but citizens I found that I had the same issue. try to reproduce. create an npc with this command. /npc create npc1 --type villager, after you do that just make it rain, fly up a little, and back up to make the npc disappear, then at running speed, I think /speed 2 move toward the npc villager. I notice that this does not happen to a player npc. yes, other player can see the issue as well

git-Spigot-56f8471-7554e08 (MC: 1.14.4) (Implementing API version 1.14.4-R0.1-SNAPSHOT)
Citizens v2.0.25-SNAPSHOT (build 1776) updated to this yesterday to see if it would correct the issue.
--type villager NPC's
out of box config.

NPC's jump into the air when it rains. that's about it. when raining, and you approach the NPC's they appear to jump real high, then fall from the sky. ONLY when it rains.

Describe the bug
So, the issue is, when I right click the npc, says https://gyazo.com/f940ed7affbde7ec6855a971f4971863.

To Reproduce
Steps to reproduce the behavior:
Dont't have errors.

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
https://gyazo.com/f940ed7affbde7ec6855a971f4971863

Versions (please complete the following information):

• Citizens version 2.0.22-SNAPSHOT (build 1487)
• Spigot version 1.12.2
• CitizensCMD version 2.1
• Java version 8

Additional context
Add any other context about the problem here.

Title

Describe the bug
does not work with multiverse commands and the pit command

To Reproduce
Steps to reproduce the behavior:
add command for the pc
No error log comes out in console
just nothing
Expected behavior
mvtp to certain world
or join the pit

Screenshots
If applicable, add screenshots to help explain your problem.

Versions (please complete the following information):

• Citizens version Citizen 2 newest
• Spigot 1.14.3
• CitizensCMD version newest
• Java version 8

Additional context
Add any other context about the problem here.

Hello, i have a problem , i test different version of citizens 1.13 and the plugin say :

[19:24:38] [Server thread/INFO]: �[0;37;1m[�[0;36;22mCitizens�[0;31;1mCMD�[0;37;1m]�[m �[0;31;1mCitizens �[0;37;22mis needed for this plugin to work!�[m
[19:24:38] [Server thread/INFO]: �[0;37;1m[�[0;36;22mCitizens�[0;31;1mCMD�[0;37;1m]�[m �[0;31;1mCitizens.jar �[0;37;22mis not installed on the server!�[m
[19:24:38] [Server thread/INFO]: �[0;37;1m[�[0;36;22mCitizens�[0;31;1mCMD�[0;37;1m]�[m �[0;31;1mDisabling CitizensCMD...�[m
[19:24:38] [Server thread/INFO]: [CitizensCMD] Disabling CitizensCMD v2.1
[19:24:38] [Server thread/ERROR]: Error occurred while disabling CitizensCMD v2.1 (Is it up to date?)
java.lang.NullPointerException: null
at me.mattmoreira.citizenscmd.CitizensCMD.onDisable(CitizensCMD.java:215) ~[?:?]
at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:266) ~[spigot.jar:git-Spigot-fe3ab0d-162bda9]
at org.bukkit.plugin.java.JavaPluginLoader.disablePlugin(JavaPluginLoader.java:363) [spigot.jar:git-Spigot-fe3ab0d-162bda9]
at org.bukkit.plugin.SimplePluginManager.disablePlugin(SimplePluginManager.java:422) [spigot.jar:git-Spigot-fe3ab0d-162bda9]
at me.mattmoreira.citizenscmd.CitizensCMD.onEnable(CitizensCMD.java:81) [CitizensCMD.jar:?]
at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:264) [spigot.jar:git-Spigot-fe3ab0d-162bda9]
at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:339) [spigot.jar:git-Spigot-fe3ab0d-162bda9]
at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:403) [spigot.jar:git-Spigot-fe3ab0d-162bda9]
at org.bukkit.craftbukkit.v1_13_R1.CraftServer.enablePlugin(CraftServer.java:426) [spigot.jar:git-Spigot-fe3ab0d-162bda9]
at org.bukkit.craftbukkit.v1_13_R1.CraftServer.enablePlugins(CraftServer.java:340) [spigot.jar:git-Spigot-fe3ab0d-162bda9]
at net.minecraft.server.v1_13_R1.MinecraftServer.m(MinecraftServer.java:562) [spigot.jar:git-Spigot-fe3ab0d-162bda9]
at net.minecraft.server.v1_13_R1.MinecraftServer.g_(MinecraftServer.java:524) [spigot.jar:git-Spigot-fe3ab0d-162bda9]
at net.minecraft.server.v1_13_R1.MinecraftServer.a(MinecraftServer.java:423) [spigot.jar:git-Spigot-fe3ab0d-162bda9]
at net.minecraft.server.v1_13_R1.DedicatedServer.init(DedicatedServer.java:288) [spigot.jar:git-Spigot-fe3ab0d-162bda9]
at net.minecraft.server.v1_13_R1.MinecraftServer.run(MinecraftServer.java:686) [spigot.jar:git-Spigot-fe3ab0d-162bda9]
at java.lang.Thread.run(Thread.java:748) [?:1.8.0_151]

Is your feature request related to a problem? Please describe.
There is no way to allow players access to certain NPCs based on rank, permissions, balance, etc.

Describe the solution you'd like
The creation of interaction requirements - allow interaction with NPCs based on permissions, balance (Vault), rank, etc.

Describe alternatives you've considered
N/A

Additional context
N/A

Describe the bug
Can't use on 1.16.2 server

To Reproduce
Type /npcmd or interact with npc

Expected behavior
appeared an interal error occorred while attempting to perforn this command

Versions (please complete the following information):

• Citizens version
  Citizens-2.0.27-b2100
• Spigot version
  1.16.2
• CitizensCMD version
  2.5
• Java version
  Java 14

Additional context
Error text:
[19:42:38 ERROR]: null org.bukkit.command.CommandException: Cannot execute command 'npcmd' in plugin CitizensCMD v2.5 - plugin is disabled. at org.bukkit.command.PluginCommand.execute(PluginCommand.java:37) ~[patched_1.16.2.jar:git-Paper-147] at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:159) ~[patched_1.16.2.jar:git-Paper-147] at org.bukkit.craftbukkit.v1_16_R2.CraftServer.dispatchCommand(CraftServer.java:800) ~[patched_1.16.2.jar:git-Paper-147] at net.minecraft.server.v1_16_R2.PlayerConnection.handleCommand(PlayerConnection.java:1907) ~[patched_1.16.2.jar:git-Paper-147] at net.minecraft.server.v1_16_R2.PlayerConnection.a(PlayerConnection.java:1718) ~[patched_1.16.2.jar:git-Paper-147] at net.minecraft.server.v1_16_R2.PacketPlayInChat.a(PacketPlayInChat.java:47) ~[patched_1.16.2.jar:git-Paper-147] at net.minecraft.server.v1_16_R2.PacketPlayInChat.a(PacketPlayInChat.java:5) ~[patched_1.16.2.jar:git-Paper-147] at net.minecraft.server.v1_16_R2.PlayerConnectionUtils.lambda$ensureMainThread$1(PlayerConnectionUtils.java:23) ~[patched_1.16.2.jar:git-Paper-147] at net.minecraft.server.v1_16_R2.TickTask.run(SourceFile:18) ~[patched_1.16.2.jar:git-Paper-147] at net.minecraft.server.v1_16_R2.IAsyncTaskHandler.executeTask(IAsyncTaskHandler.java:136) ~[patched_1.16.2.jar:git-Paper-147] at net.minecraft.server.v1_16_R2.IAsyncTaskHandlerReentrant.executeTask(SourceFile:23) ~[patched_1.16.2.jar:git-Paper-147] at net.minecraft.server.v1_16_R2.IAsyncTaskHandler.executeNext(IAsyncTaskHandler.java:109) ~[patched_1.16.2.jar:git-Paper-147] at net.minecraft.server.v1_16_R2.MinecraftServer.ba(MinecraftServer.java:1135) ~[patched_1.16.2.jar:git-Paper-147] at net.minecraft.server.v1_16_R2.MinecraftServer.executeNext(MinecraftServer.java:1128) ~[patched_1.16.2.jar:git-Paper-147] at net.minecraft.server.v1_16_R2.IAsyncTaskHandler.awaitTasks(IAsyncTaskHandler.java:119) ~[patched_1.16.2.jar:git-Paper-147] at net.minecraft.server.v1_16_R2.MinecraftServer.sleepForTick(MinecraftServer.java:1089) ~[patched_1.16.2.jar:git-Paper-147] at net.minecraft.server.v1_16_R2.MinecraftServer.w(MinecraftServer.java:1003) ~[patched_1.16.2.jar:git-Paper-147] at net.minecraft.server.v1_16_R2.MinecraftServer.lambda$a$0(MinecraftServer.java:177) ~[patched_1.16.2.jar:git-Paper-147] at java.lang.Thread.run(Thread.java:832) [?:?]

i need this to work for bungeecord but for some reason it keeps saying unknown command and theres no setting to enable bungeecord support any where is this a bug or is bungeecord un supported

To Reproduce
Steps to reproduce the behavior:

1. Add NPC
2. Add Command: 'server {servername}'
3. Punch/Right click NPC
4. Say's Unknown command

Versions

• Latest Version
• I'm Using Paper 1.16.1 Latest
• Latest Version
• Latest Version

Title.

message-display: "{name}:&r"
doesn't work when getting a message from an NPC?

Describe the bug
It is easier for me to edit files than to use commands. But if I make a mistake in saves.yml and then use /npcmd reload. I'll get this stacktrace.

[19:10:18] [Server thread/INFO]: [CitizensCMD] Using English messages!
[19:10:18] [Server thread/ERROR]: null
org.bukkit.command.CommandException: Unhandled exception executing command 'npcmd' in plugin CitizensCMD v2.3.2
	at org.bukkit.command.PluginCommand.execute(PluginCommand.java:47) ~[patched_1.14.3.jar:git-Paper-130]
	at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:159) ~[patched_1.14.3.jar:git-Paper-130]
	at org.bukkit.craftbukkit.v1_14_R1.CraftServer.dispatchCommand(CraftServer.java:739) ~[patched_1.14.3.jar:git-Paper-130]
	at net.minecraft.server.v1_14_R1.PlayerConnection.handleCommand(PlayerConnection.java:1831) ~[patched_1.14.3.jar:git-Paper-130]
	at net.minecraft.server.v1_14_R1.PlayerConnection.a(PlayerConnection.java:1639) ~[patched_1.14.3.jar:git-Paper-130]
	at net.minecraft.server.v1_14_R1.PacketPlayInChat.a(PacketPlayInChat.java:47) ~[patched_1.14.3.jar:git-Paper-130]
	at net.minecraft.server.v1_14_R1.PacketPlayInChat.a(PacketPlayInChat.java:5) ~[patched_1.14.3.jar:git-Paper-130]
	at net.minecraft.server.v1_14_R1.PlayerConnectionUtils.lambda$ensureMainThread$0(PlayerConnectionUtils.java:18) ~[patched_1.14.3.jar:git-Paper-130]
	at net.minecraft.server.v1_14_R1.TickTask.run(SourceFile:18) ~[patched_1.14.3.jar:git-Paper-130]
	at net.minecraft.server.v1_14_R1.IAsyncTaskHandler.executeTask(IAsyncTaskHandler.java:127) ~[patched_1.14.3.jar:git-Paper-130]
	at net.minecraft.server.v1_14_R1.IAsyncTaskHandlerReentrant.executeTask(SourceFile:23) ~[patched_1.14.3.jar:git-Paper-130]
	at net.minecraft.server.v1_14_R1.IAsyncTaskHandler.executeNext(IAsyncTaskHandler.java:105) ~[patched_1.14.3.jar:git-Paper-130]
	at net.minecraft.server.v1_14_R1.MinecraftServer.aW(MinecraftServer.java:1002) ~[patched_1.14.3.jar:git-Paper-130]
	at net.minecraft.server.v1_14_R1.MinecraftServer.executeNext(MinecraftServer.java:995) ~[patched_1.14.3.jar:git-Paper-130]
	at net.minecraft.server.v1_14_R1.IAsyncTaskHandler.executeAll(IAsyncTaskHandler.java:91) ~[patched_1.14.3.jar:git-Paper-130]
	at net.minecraft.server.v1_14_R1.MinecraftServer.sleepForTick(MinecraftServer.java:978) ~[patched_1.14.3.jar:git-Paper-130]
	at net.minecraft.server.v1_14_R1.MinecraftServer.run(MinecraftServer.java:912) ~[patched_1.14.3.jar:git-Paper-130]
	at java.lang.Thread.run(Thread.java:748) [?:1.8.0_151]
Caused by: java.lang.IllegalArgumentException: Cannot translate null text
	at org.apache.commons.lang.Validate.notNull(Validate.java:192) ~[patched_1.14.3.jar:git-Paper-130]
	at org.bukkit.ChatColor.translateAlternateColorCodes(ChatColor.java:354) ~[patched_1.14.3.jar:git-Paper-130]
	at me.mattstudios.citizenscmd.utility.Util.color(Util.java:130) ~[?:?]
	at me.mattstudios.citizenscmd.files.LangHandler.getMessage(LangHandler.java:302) ~[?:?]
	at me.mattstudios.citizenscmd.commands.CMDReload.execute(CMDReload.java:69) ~[?:?]
	at me.mattstudios.citizenscmd.commands.base.CommandHandler.onCommand(CommandHandler.java:109) ~[?:?]
	at org.bukkit.command.PluginCommand.execute(PluginCommand.java:45) ~[patched_1.14.3.jar:git-Paper-130]
	... 17 more

To Reproduce

1. Go to data/saves.yml
2. Make a mistake in this file.
3. Use /npcmd reload

Expected behavior
I would expect a message that there is an error in the file.
Ideally, the message shows where the problem is.

Versions:

• Citizens version: 2.0.25-b1719
• Paper version: 1.14.3 b130
• CitizensCMD version: 2.3.2
• Java version: 1.8.0_151

Hello,
since the 1.14 implementation, I noticed with random crashes with CitizensCMD indication in the crashlog.
Currently my server uses paper-87 in 1.15.2
Please resolve this if possible.
http://bin.mc-imperia.fr/KEeHbh65hg

Describe the bug
Update-check network call is made every hour, even though configuration is set to disable it.

To Reproduce
Steps to reproduce the behavior:

1. Configure network to disallow outbound calls.
2. Configure CitizensCMD to disable update checks.
3. Start server.
4. Observe errors in console/log.

Expected behavior
CitizensCMD should not make outbound network calls.

Screenshots

Versions (please complete the following information):

• Citizens 2.0.25-SNAPSHOT (build 1719)
• Spigot 1.13.2 final = git-Spigot-1a3504a-a46fdbc (MC: 1.13.2) (Implementing API version 1.13.2-R0.1-SNAPSHOT)
• CitizensCMD 2.3.2
• Java 11.0.3 on up-to-date CentOS platform

Additional context

# Citizens CMD Plugin by Mateus Moreira
# @LichtHund
# Version 2.3.2
# Wiki: https://github.com/ipsk/CitizensCMD/wiki
# GitHub: https://github.com/ipsk/CitizensCMD
# Spigot: https://www.spigotmc.org/resources/citizens-cmd.30224/

#
# Enables Checking for update.
check-updates: false

[08:20:58 WARN]: java.io.IOException: Connect failed
[08:20:58 WARN]:        at me.lucko.networkinterceptor.interceptors.ProxySelectorInterceptor$LoggingSelector.select(ProxySelectorInterceptor.java:59)
[08:20:58 WARN]:        at com.github.games647.lagmonitor.listener.BlockingConnectionSelector.select(BlockingConnectionSelector.java:33)
[08:20:58 WARN]:        at java.base/sun.net.www.protocol.http.HttpURLConnection.plainConnect0(HttpURLConnection.java:1175)
[08:20:58 WARN]:        at java.base/sun.net.www.protocol.http.HttpURLConnection$6.run(HttpURLConnection.java:1065)
[08:20:58 WARN]:        at java.base/sun.net.www.protocol.http.HttpURLConnection$6.run(HttpURLConnection.java:1063)
[08:20:58 WARN]:        at java.base/java.security.AccessController.doPrivileged(Native Method)
[08:20:58 WARN]:        at java.base/java.security.AccessController.doPrivilegedWithCombiner(AccessController.java:793)
[08:20:58 WARN]:        at java.base/sun.net.www.protocol.http.HttpURLConnection.plainConnect(HttpURLConnection.java:1062)
[08:20:58 WARN]:        at java.base/sun.net.www.protocol.https.AbstractDelegateHttpsURLConnection.connect(AbstractDelegateHttpsURLConnection.java:177)
[08:20:58 WARN]:        at java.base/sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1581)
[08:20:58 WARN]:        at java.base/sun.net.www.protocol.http.HttpURLConnection$9.run(HttpURLConnection.java:1501)
[08:20:58 WARN]:        at java.base/sun.net.www.protocol.http.HttpURLConnection$9.run(HttpURLConnection.java:1499)
[08:20:58 WARN]:        at java.base/java.security.AccessController.doPrivileged(Native Method)
[08:20:58 WARN]:        at java.base/java.security.AccessController.doPrivilegedWithCombiner(AccessController.java:793)
[08:20:58 WARN]:        at java.base/sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1498)
[08:20:58 WARN]:        at java.base/sun.net.www.protocol.https.HttpsURLConnectionImpl.getInputStream(HttpsURLConnectionImpl.java:245)
[08:20:58 WARN]:        at me.mattstudios.citizenscmd.updater.SpigotUpdater.checkForUpdates(SpigotUpdater.java:65)
[08:20:58 WARN]:        at me.mattstudios.citizenscmd.schedulers.UpdateScheduler.run(UpdateScheduler.java:40)
[08:20:58 WARN]:        at org.bukkit.craftbukkit.v1_13_R2.scheduler.CraftTask.run(CraftTask.java:81)
[08:20:58 WARN]:        at org.bukkit.craftbukkit.v1_13_R2.scheduler.CraftAsyncTask.run(CraftAsyncTask.java:52)
[08:20:58 WARN]:        at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
[08:20:58 WARN]:        at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
[08:20:58 WARN]:        at java.base/java.lang.Thread.run(Thread.java:834)

The per NPC permission does not work.

We currently use PEX as our permissions system. Guest does NOT have citizenscmd.use.

NPC 181 has permission npc.use and the Guest can still access the right click command of the NPC.
NPC 181 then has the permission citizenscmd.use and the Guest can still access.

The per NPC permission is not working and there is an immense lack of detail for how the permission works. Poor documentation and effort.

I may sound stupid but how do I run commands through the NPC like /give %p% 64 stone

[22:18:15] [Server thread/ERROR]: Error occurred while disabling CitizensCMD v2.3.2 (Is it up to date?)

java.lang.NullPointerException: null

at me.mattstudios.citizenscmd.files.CooldownHandler.createBasics(CooldownHandler.java:67) ~[CitizensCMD.jar:?]

at me.mattstudios.citizenscmd.files.CooldownHandler.saveToFile(CooldownHandler.java:108) ~[CitizensCMD.jar:?]

at me.mattstudios.citizenscmd.CitizensCMD.onDisable(CitizensCMD.java:220) ~[CitizensCMD.jar:?]

at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:265) ~[spigot-1.14.3.jar:git-Spigot-595711b-e8b39d4]

at org.bukkit.plugin.java.JavaPluginLoader.disablePlugin(JavaPluginLoader.java:377) [spigot-1.14.3.jar:git-Spigot-595711b-e8b39d4]

at org.bukkit.plugin.SimplePluginManager.disablePlugin(SimplePluginManager.java:437) [spigot-1.14.3.jar:git-Spigot-595711b-e8b39d4]

at org.bukkit.plugin.SimplePluginManager.disablePlugins(SimplePluginManager.java:429) [spigot-1.14.3.jar:git-Spigot-595711b-e8b39d4]

at org.bukkit.craftbukkit.v1_14_R1.CraftServer.disablePlugins(CraftServer.java:392) [spigot-1.14.3.jar:git-Spigot-595711b-e8b39d4]

at net.minecraft.server.v1_14_R1.MinecraftServer.stop(MinecraftServer.java:679) [spigot-1.14.3.jar:git-Spigot-595711b-e8b39d4]

at net.minecraft.server.v1_14_R1.DedicatedServer.stop(DedicatedServer.java:681) [spigot-1.14.3.jar:git-Spigot-595711b-e8b39d4]

at net.minecraft.server.v1_14_R1.MinecraftServer.run(MinecraftServer.java:845) [spigot-1.14.3.jar:git-Spigot-595711b-e8b39d4]

at java.lang.Thread.run(Thread.java:748) [?:1.8.0_202]

Hello, I want to receive a few messages from an NPC when it's the first time that I click on it, but execute a command when is the second time.

Can I do that? And if cannot, it will be added? When?

Thanks

Describe the bug
If I, per say, have a deluxemenu, and I set an open requirement with the permission open.menu and then I try to open the menu through npcmd without being op the plugin will open the menu without using the perm.

To Reproduce
Steps to reproduce the behavior:

1. Create menu with an open_requirement of "has permission" (perm being open.menu for ex.)
2. Use /npcmd add open.menu menu (menu is the comand i've set to open the menu)
3. Use a group without that permission and see how the menu opens up.

Expected behavior
The menu shouldn't open up cause I don't have the permission.

Versions (please complete the following information):

• CitizensCMD: 2.3
• Deluxemenus: 1.10.4

Plugin supports 1.14.1?

i cant get it so that when i click it it will take me to my creative plot server even tho i have set up a custom camand that is /creativeserver and it works for the player but wont work with the npc how do i make it work

Describe the bug
Just that, i have to use the reload command to make the commands work

To Reproduce
Steps to reproduce the behavior:!

It just happens, mostly every time i start the server they stop working, after a npcdm reload it works again

Versions (please complete the following information):

• Citizens version 2.0.27- build 2058
• Spigot version paper 136
• CitizensCMD version 2.5
• Java version 1.8

PD: Please add support for newer citizens versions

Describe the bug
After adding a price to the npc, i can click them to use them, it shows me a message saying to shift click for confirmation or cancellation and that it will expire in 15 seconds. However shift clicking (either left or right) it keeps giving me the message to confirm or cancel.

To Reproduce
Steps to reproduce the behavior:

1. Add command to npc
2. Add price to activate
3. Right click to use npc and activate command
4. Shift-right-click to confirm

Expected behavior
After shift clicking for confirmation, the command run

Versions (please complete the following information):

• Citizens version: 4.0.25
• Spigot version: 1.14.2
• CitizensCMD version: 2.3.1
• Java version: 8

Describe the bug
When we perform a /npcmd reload an error occurs

To Reproduce
Steps to reproduce the behavior:

1. execute /npcmd reload

LOGS
https://pastebin.com/pNuYbDbH

Versions (please complete the following information):

• Citizens version: 2.0.24
• Spigot version: 1.13.1
• CitizensCMD version: 2.1
• Java version: 8

I am very new to making servers. I know that since I am using luckperms, people need permissions to do different things. What I know about Citizens is that a player needs the permission. citizens.npc.talk, and citizen.npc.text, to use the NPCs. When I gave the default rank those permissions, people with the rank still can't use the NPC's. Please help!

Title, very simple :)

Hello,

as you probably know, October is a Hacktoberfest month and I would like to make a contribution to your project.

I am a native Czech language speaker so I could prepare a localized Czech language file and start a pull request with my changes. Does it sound like something you would be interested in?

If you don't know about the Hacktoberfest initiative, then it is a month-long even when developers try to contribute as much as possible into open-source projects and their successful pull requests are counted. For a pull request to be counted towards my Hacktoberfest profile, it must be merged during October, but the sooner the better.

I will prepare a localization file hopefully today or in the upcoming two days and send a pull request, which I hope you will accept.

I use command /npcmd add console shop MyShop %p%

And nothing happen...

Someone can help me ?