cwd_and_chdir test failure about libuv HOT 4 CLOSED

FWIW, I went back and forth regarding the terminating NULL, we should check the git history to make sure we don't break anything. Also, we should be consistent with uv_exepath and other functions that behave similarly.

As a side note, wouldn't changing this be a backwards incompatible change?

from libuv.

As a side note, wouldn't changing this be a backwards incompatible change?

Yes, so we can only change this as part of a major release.
I'll fix the test on v1.x.

from libuv.

So I would expect this test to fail on linux too. @bnoordhuis can you maybe shed some light on this, because I have no idea.

Because size is 26 after the first call to uv_cwd() and 20 after the second call (/home/bnoordhuis/src/libuv vs. /home/bnoordhuis/src). In other words, it worked by accident. :-)

from libuv.

The test was fixed and unix/windows behavior was made the same. That's all we can do on an API-stable branch.

For posterity: the meaning of the size argument is still weird. It's something that we should address in libuv 2.x.

from libuv.