Test failure with 1.48.0 on OSX x86 about libuv HOT 10 CLOSED

Can you provide more details? Arch, os and version in particular.

from libuv.

As per the logs, the test failure occurs on OS X x86.

from libuv.

What version of OS X? Per SUPPORTED_PLATFORMS.md, macos < 11 isn't supported.

from libuv.

We use a recent version of OS X as build platform but buit against rather old MACOS SDK by default (10.9).

Is the SDK Version 11 required? (This seems like a big jump).

from libuv.

IIRC, this particular macro changed from a runtime detection to a compile-time detection, hence the resulting test failure you notice when compiling with older headers

from libuv.

this particular macro changed from a runtime detection to a compile-time detection.

This was also a problem when trying to upgrade libuv for last Node.js 20 release: we couldn't do it because Node.js still supports macos 10.15 (also refs: nodejs/node#51976 (comment)). @bnoordhuis IIRC you were open to bring back support somehow at least until 20.x goes EOL?

from libuv.

Yes. I'll open a pull request. All this back and forth just wastes everyone's time. :)

from libuv.

#4345 - please refresh my memory: does that also apply to pwritev?

from libuv.

#4345 - please refresh my memory: does that also apply to pwritev?

I think we're ok only with preadv as that's the one they kind of expose via the API.

from libuv.

I think we're ok only with preadv as that's the one they kind of expose via the API.

That was completely wrong, we need to manually check for pwritev availability too, otherwise it'll fail on old macos. Don't think we need a fallback though because it's not exposed

from libuv.