Mixed allocator usage with `realpath` about libuv HOT 2 CLOSED

I can guess the context in which you're opening this issue. saghul/txiki.js#457, right? :)

The extra allocation could be avoided like this:

diff --git a/src/unix/fs.c b/src/unix/fs.c
index 3a74350f..99d42d4e 100644
--- a/src/unix/fs.c
+++ b/src/unix/fs.c
@@ -2127,6 +2127,13 @@ void uv_fs_req_cleanup(uv_fs_t* req) {
     uv__free(req->bufs);
   req->bufs = NULL;
 
+#if defined(_POSIX_VERSION) && _POSIX_VERSION >= 200809L
+  if (req->fs_type == UV_FS_REALPATH) {
+    free(req->ptr);  /* _Not_ uv__free() */
+    req->ptr = NULL;
+  }
+#endif
+
   if (req->fs_type != UV_FS_OPENDIR && req->ptr != &req->statbuf)
     uv__free(req->ptr);
   req->ptr = NULL;

from libuv.

I can guess the context in which you're opening this issue. saghul/txiki.js#457, right? :)

Pretty much :-)

The extra allocation could be avoided like this:

Not quite. We have other uses of realpath. The one that hit me first was:

Which can also be fixed in a similar way.

After sleeping on it it's probably ok to just go through and fix the specific instances of this problem. Having a few small allocations on the system allocator is not too bad...

from libuv.