Git Product home page Git Product logo

Comments (15)

Themaister avatar Themaister commented on May 24, 2024

Does similar output happen with all shaders? Works fine here, so I suspect driver bug or gamegear bug.

from retroarch.

eadmaster avatar eadmaster commented on May 24, 2024

yes, all shaders i've tried.
It affects the GameGear core only.

from retroarch.

almostalive avatar almostalive commented on May 24, 2024

I think this might be a driver issuse. I've noticed this same thing in other sega emus running game gear. I kinda always figured it was a game gear emulation problem but if maister isn't getting that wierd thing at the top of the screen it could be driver issue then. Happens on my Atom/ION board with the Nvidia driver, I might check to see if the same thing happens with the nouveau sometime.

from retroarch.

Themaister avatar Themaister commented on May 24, 2024

Note that I haven't tried gamegear specifically, but I've never seen glitches like that.

from retroarch.

eadmaster avatar eadmaster commented on May 24, 2024

I'm using an AMD APU (no discrete video card).
I've never seen this kind of issue with other emus using shaders...

from retroarch.

p1pkin avatar p1pkin commented on May 24, 2024

I want to confirm that issue. I have the same colored trash at the top border area in all GG games.
It happens with or without shaders and with any video-driver, so looks like this issue not shader-related.
More likely it somehow related to new "gg_extra" feature/setting in GenPlusGX 1.7.1 core.

Strange thing - this bug is also present in my selfcompiled win32 x86 MSVC Release build, BUT not present in Debug build.

from retroarch.

p1pkin avatar p1pkin commented on May 24, 2024

One more thing - in GenPlusGX MSVC projects you are probably forgot to add FRONTEND_SUPPORTS_RGB565 preprocessor definition.

from retroarch.

inactive123 avatar inactive123 commented on May 24, 2024

p1pkin - Try again with the latest commit of Genesis Plus GX.

from retroarch.

p1pkin avatar p1pkin commented on May 24, 2024

yep, project is ok now, but GameGear gfx glitch is still in place.
http://imageshack.us/photo/my-images/141/ggbug.png/

from retroarch.

p1pkin avatar p1pkin commented on May 24, 2024

... and I see why:
in libretro.c:
video_cb(bitmap_data_ + bitmap.viewport.x + bitmap.viewport.y * 1024, .....
bitmap.viewport.x/y can be negative, so it gets some garbage data from memory before bitmap_data_ array.

from retroarch.

p1pkin avatar p1pkin commented on May 24, 2024

Themaister - plz look at this libretro/Genesis-Plus-GX#4
before: http://imageshack.us/photo/my-images/141/ggbug.png/
after: http://imageshack.us/photo/my-images/196/ggnorm.png/

also full overscan mode (config.overscan = 3) now works ok if enabled.

from retroarch.

inactive123 avatar inactive123 commented on May 24, 2024

Hmm - I thought the overscan mode would be a lot slower - but I guess for Game Gear purposes there is a need. Before I'll merge your pull request though first I want to know why the change to md_cart.c is necessary - ekeeke might object to core changes like that if they serve no worth.

from retroarch.

p1pkin avatar p1pkin commented on May 24, 2024

twinaphex
in md_cart.c was hacky "leave this for() after we found cart in database" code, in the case if cart not found in db. at last iteration (i == CART_CNT) will be readed values out of bounds rom_database[] array.

VS2012 code analyser reported this buggy place.

from retroarch.

inactive123 avatar inactive123 commented on May 24, 2024

Well, I can pass that on to ekeeke, but for now, let's keep that out of the pull request. So if you can make another pull request with no changes to md_cart.c - I can merge it.

from retroarch.

p1pkin avatar p1pkin commented on May 24, 2024

Ok
libretro/Genesis-Plus-GX#5

from retroarch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.