Comments (5)
A sub-frame shader solution (to that 120hz workaround) wouldn't be able to inject an 'extra' sub-frame like a driver solution could. But I still think it might be better to 'hide' a feature that is purposefully injecting noticeable annoying artifacting in a shader rather than as a front-end option.
So you'd maybe do something more like (100-0)-(100-0)-(50-50)-(0-100)-(0-100) style phase shift on a framecount%(adjustable number of how long you want between phase shifts). And keep in mind framecount intentionally doesn't increment on sub-frames, or sub-frames would mess with anything older that looks at framecount but isn't sub-frame aware.
The 50-50 transition frame might be a less noticeable/annoying transition than just a straight flip like 100-0-0-100? Trading some of the very noticeable change in instantaneous average brightness for some transient motion blur, still annoying but maybe a -little- less distracting.
from retroarch.
The current problem is that we don't -know- a good way to improve it that doesn't have fairly bad artifacting or other major issues of its own. I personally think the rolling scan feature as it is now, will scare people off BFI thinking it's an entirely useless/broken feature. But I didn't want to stand in the way of merging either, as it isn't my place, and as this code should not inhibit the existing full-frame BFI/shader sub-frame code paths from working as intended.
Some of the best things we know of, for the issues this feature has, are trying to hide the joint lines behind scanlines in CRT filters, and having some overlap between rolling scan sections with brightness adjustment which replaces some of the tearing problem with horizontal strips of less motion blur reduction. Which in and of itself is a pretty apparent visual artifact.
Also, a front-end solution like this wont be aware of what shaders are in use, and the screen resolution and Hz being used will also change where those rolling scan joint lines are in the image. Making trying to build front end code, or a shader specificially meant to be used in conjunction with this feature, need to account for a LOT of different joint line possibilities.
If anyone can provide a solution to where the artifacting is minimal enough to compete with the existing full-frame BFI that has zero inherent artifacting (other than strobing itself being a little annoying, obviously), I am all for it though. There are a few side benefits to the rolling scan method over full-frame BFI when/if it works well. This is where @mdrejhon would be very handy. :)
from retroarch.
For the record, I find a double ON to be much less obtrusive than a double OFF flicker.
from retroarch.
Did you mean this response for my last reply on the previous PR regarding the 120hz bfi workaround?
from retroarch.
Yeah, I just put it here instead of there so we could close the lid on that one and continue discussion of improvements here.
from retroarch.
Related Issues (20)
- fbneo core: The issue of crashing occurring across multiple platforms, as raised by many users. HOT 4
- Only the cheat notification is shown when a cheat file gets auto-loaded
- Ios gbp shader bug
- every version of retroarch crash on launch ( mac high sierra) HOT 3
- [Feature Request] Wayland: Support for wl_shell HOT 6
- [BUG] Fast-Forward and Rewind soft-lock Retroarch on Steam Deck OLED models using Vulkan HOT 9
- [ANDROID] playlist thumbnail update stuck at 0% not downloading anything HOT 2
- Problem
- Nobody seems to be maintaining issues
- GPU Recording Causes Massive Slowdown, Doesn't Disable Achievements Hardcore Mode HOT 2
- runahead+rewind conflicts
- Pokemon
- The L trigger and R trigger on iOS build can only be recognized as buttons and cannot be identified as analog triggers. HOT 5
- [Feature Request] Patch Picker HOT 19
- Thanks for allowing rename playlist, but has an issue ... HOT 8
- Can't click right stick and use the dpad at the same time HOT 6
- atari paddle support gone now? HOT 8
- 1.18.0 changing "sync to exact content ramerate" ON/OFF causes the screen to flicker for a moment HOT 2
- [Feature Request] SPOUT HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from retroarch.