Git Product home page Git Product logo

Comments (4)

lnykww avatar lnykww commented on July 24, 2024

ping @vyzo

from go-libp2p-daemon.

vyzo avatar vyzo commented on July 24, 2024

@bigs maintains the client.

from go-libp2p-daemon.

bigs avatar bigs commented on July 24, 2024

hmm can you give me steps to reproduce this or propose a patch? definitely down to fix this, just not fully sure i understand

from go-libp2p-daemon.

lnykww avatar lnykww commented on July 24, 2024

The protocol needs to be added to the multiaddr's protocol list by calling AddProtocol. for the circuit protocol, it was added during the init phase:

 var Protocol = ma.Protocol{
     Code:  P_CIRCUIT,
     Size:  0,
     Name:  "p2p-circuit",
     VCode: ma.CodeToVarint(P_CIRCUIT),
 }
func init() {
     ma.AddProtocol(Protocol)
 }

But in go client, there is no need to import the circuit package, so the circuit protocol would not to be added to the protocol list.

so when client call convertStreamInfo to parse multiaddr, there was no circuit protocol in the list:

func convertStreamInfo(info *pb.StreamInfo) (*StreamInfo, error) {
      ...
     addr, err := ma.NewMultiaddrBytes(info.Addr)
     ...
 }

from go-libp2p-daemon.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.