Git Product home page Git Product logo

atheme-extra's People

Contributors

abstractbeliefs avatar edk0 avatar glguy avatar ilbelkyr avatar jesopo avatar mniip avatar mquin avatar skizzerz avatar spb avatar tomaw avatar

Stargazers

 avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

atheme-extra's Issues

CS CLAIM doesn't properly update last modified on CS FLAGS

When a group contact has limited flags in a channel (for example, +Aiotv) and that group contact runs /CS CLAIM to gain founder privileges on the channel, the output from CS FLAGS reports the updated flags, but the last modified timestamp and account name do not get updated.

Reproduction steps

  1. Register a project with namespace/contact and openreg set
/msg projectserv register helpmebot
/msg projectserv channel helpmebot add #helpmebot
/msg projectserv contact helpmebot add stwalkerster
/msg projectserv set helpmebot openreg on
/msg projectserv info helpmebot
22:18:42 -ProjectServ- Information on helpmebot:
22:18:42 -ProjectServ- Registered on Dec 15 22:17:15 2022 +0000 by [email protected]{earth.localnet}
22:18:42 -ProjectServ- Channel namespaces: #helpmebot
22:18:42 -ProjectServ- Cloak namespaces: (none)
22:18:42 -ProjectServ- Group contacts (private): stwalkerster
22:18:42 -ProjectServ- Anyone may register channels in the project namespace
22:18:42 -ProjectServ- *** End of Info ***
  1. Register a channel as a non-contact user
/cs register #helpmebot
22:19:12 -ChanServ- #helpmebot is now registered to dng.
22:19:12 -ChanServ- The #helpmebot namespace is managed by the helpmebot project.
/cs flags #helpmebot
22:19:22 -ChanServ- Entry    Nickname/Host          Flags
22:19:22 -ChanServ- ----------------------------------------------------------------
22:19:22 -ChanServ- 1        dng                    +AFORefiorstv        (FOUNDER) [modified 3s ago, on Dec 15 22:19:10 2022 +0000, by dng]
22:19:22 -ChanServ- ----------------------------------------------------------------
22:19:22 -ChanServ- End of #helpmebot FLAGS listing.
  1. As contact user, claim channel. Observe flag setter is correctly set to stwalkerster.
/cs claim #helpmebot
22:24:55 -ChanServ- Full access to #helpmebot has been granted to stwalkerster on behalf of the helpmebot project.
/cs flags #helpmebot
22:25:21 -ChanServ- Entry    Nickname/Host          Flags
22:25:21 -ChanServ- ----------------------------------------------------------------
22:25:21 -ChanServ- 1        dng                    +AFORefiorstv        (FOUNDER) [modified 6m 6s ago, on Dec 15 22:19:10 2022 +0000, by dng]
22:25:21 -ChanServ- 2        stwalkerster           +AFORefiorstv        (FOUNDER) [modified 23s ago, on Dec 15 22:24:53 2022 +0000, by stwalkerster]
22:25:21 -ChanServ- ----------------------------------------------------------------
22:25:21 -ChanServ- End of #helpmebot FLAGS listing.
  1. Reduce contact's access to channel as non-contact user. Observe last modification user is non-contact user dng.
/cs flags #helpmebot stwalkerster -*+Aio 
Flags -FORefrstv were set on stwalkerster in #helpmebot.
/cs flags #helpmebot
22:26:48 -ChanServ- Entry    Nickname/Host          Flags
22:26:48 -ChanServ- ----------------------------------------------------------------
22:26:48 -ChanServ- 1        dng                    +AFORefiorstv        (FOUNDER) [modified 7m 25s ago, on Dec 15 22:19:10 2022 +0000, by dng]
22:26:48 -ChanServ- 2        stwalkerster           +Aio                 [modified 12s ago, on Dec 15 22:26:23 2022 +0000, by dng]
22:26:48 -ChanServ- ----------------------------------------------------------------
22:26:48 -ChanServ- End of #helpmebot FLAGS listing.
  1. Reclaim channel as contact
/cs claim #helpmebot
22:27:35 -ChanServ- Full access to #helpmebot has been granted to stwalkerster on behalf of the helpmebot project.
/cs flags #helpmebot
22:27:37 -ChanServ- Entry    Nickname/Host          Flags
22:27:37 -ChanServ- ----------------------------------------------------------------
22:27:37 -ChanServ- 1        dng                    +AFORefiorstv        (FOUNDER) [modified 8m 26s ago, on Dec 15 22:19:10 2022 +0000, by dng]
22:27:37 -ChanServ- 2        stwalkerster           +AFORefiorstv        (FOUNDER) [modified 1m 13s ago, on Dec 15 22:26:23 2022 +0000, by dng]
22:27:37 -ChanServ- ----------------------------------------------------------------
22:27:37 -ChanServ- End of #helpmebot FLAGS listing.

Observe the last modified date and user is still the non-contact dng user, implying that dng granted the founder flags.

I expect that the last modified timestamp and user would be updated to match the acting user - in this case the group contact.

This only occurs if the group contact already has some level of access to a channel. If the group contact does not appear in the channel's ACL prior to the /CS CLAIM, then the last modified time/user are correctly set.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.