lfaoanl / marketcrates Goto Github PK

The mod does not work on servers, Forge returns this error on startup:
[15:39:40] [modloading-worker-0/ERROR] [net.minecraftforge.fml.javafmlmod.FMLModContainer/LOADING]: Failed to create mod instance. ModID: marketcrates, class com.lfaoanl.marketcrates.MarketCrates java.lang.RuntimeException: Attempted to load class net/minecraft/client/world/ClientWorld for invalid dist DEDICATED_SERVER

Upgarding to a double crate is not a block placement, therefor there needs to be some check to determine if the player is allowed to break or place stuff in the area
(also for inclining and declining crates)

This is due to mojang dropping com.mojang.math.Quaternion in exchange for com.joml.Quaternionf
Plus registry and Creative Tab changes

For working with other mods

Idea:
A config file where someone can add custom wood types
the following needs to be specified:

Material, Texture, Recipe ingredients (slabs and fences), (maybe) is inclinable

Idea from user on curseforge:
Framed crate (think like carpenters blocks), right clicking a crate with a block places the texture on the block.

Leave default crate when breaking doubles.
Spill only the contents from the top crate on the ground

Bug when first tried:
Breaking the double crate causes the items to stop rendering

If there is a block just behind an inclined crate it will cause the front of the crate to render blackish

Problem with the mod Stacker that allows altering the stack of items for bigger ones.

Then I put a bigger than vanilla stack into the crate it instantly crashed the game, the only way to get back was nbt-explorer and cheated back the deleted item into my inventory (that's why I have cheats enabled).

A possible solution for here would be to ignore any number over 64 and just count them as 64 for the render?

I know it's not your mod fault as you'd normally don't think about stacks bigger than vanilla but reporting on both sides to let know each side part of a problem they didn't know could occur.

Anyway using these crates for a temporary small container for my temporary tree farm and for my furnace array fuel storage (now more for the case I'm out of fuel).
Gonna use more of them in the village after I expend it and have all professions needed and using it as a way to remember where they are xD

Looks like the link is incorrect. Game still starts. Just thought you might want to know.

[06Jan.2022 07:47:44.791] [Forge Version Check/INFO] [net.minecraftforge.fml.VersionChecker/]: arketcrates] Starting version check at http://lfaoanl.space/mc/marketcrates/update.json [06Jan.2022 07:47:44.836] [Forge Version Check/WARN] [net.minecraftforge.fml.VersionChecker/]: Failed to process update information java.net.UnknownHostException: lfaoanl.space at java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:220) ~[?:?] at java.net.Socket.connect(Socket.java:591) ~[?:?] at java.net.Socket.connect(Socket.java:540) ~[?:?] at sun.net.NetworkClient.doConnect(NetworkClient.java:182) ~[?:?] at sun.net.www.http.HttpClient.openServer(HttpClient.java:474) ~[?:?] at sun.net.www.http.HttpClient.openServer(HttpClient.java:569) ~[?:?] at sun.net.www.http.HttpClient.<init>(HttpClient.java:242) ~[?:?] at sun.net.www.http.HttpClient.New(HttpClient.java:341) ~[?:?] at sun.net.www.http.HttpClient.New(HttpClient.java:362) ~[?:?] at sun.net.www.protocol.http.HttpURLConnection.getNewHttpClient(HttpURLConnection.java:1242) ~[?:?] at sun.net.www.protocol.http.HttpURLConnection.plainConnect0(HttpURLConnection.java:1181) ~[?:?] at sun.net.www.protocol.http.HttpURLConnection.plainConnect(HttpURLConnection.java:1075) ~[?:?] at sun.net.www.protocol.http.HttpURLConnection.connect(HttpURLConnection.java:1009) ~[?:?] at sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1581) ~[?:?] at sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1509) ~[?:?] at java.net.HttpURLConnection.getResponseCode(HttpURLConnection.java:527) ~[?:?] at net.minecraftforge.fml.VersionChecker$1.openUrlStream(VersionChecker.java:155) ~[?:?] at net.minecraftforge.fml.VersionChecker$1.process(VersionChecker.java:187) ~[?:?] at java.lang.Iterable.forEach(Iterable.java:75) [?:?] at net.minecraftforge.fml.VersionChecker$1.run(VersionChecker.java:139) [?:?]

Symptoms

1. When a hopper fails to pull an item from crates, the content of crates frantically rotates.
2. When a hopper pushes an item to a full single-deck crate, the item seemingly vanishes.

Step to reproduce

For symptom 1:

1. place a hopper with all slots filled with some item (e.g. dirt).
2. place a crate on top of the hopper.
3. put a different item (e.g. sand) in the crate.

For symptom 2:

1. place a single-deck crate with all slots filled with some item (e.g. dirt).
2. place a hopper on the crate.
3. put a different item (e.g. sand) in the hopper.

Note

• Symptom 1 is caused by setChanged method called in AbstractCrateBlockEntity.setItem and AbstractCrateBlockEntity.removeItem. They may be removed; other components (item slots, hoppers, etc.) call it when necessary.
• Symptom 2 is caused by slots 6-11 which should only be accessible when the crate is double-decked.

Based on what I'm seeing in the .jar, you should be able to recompile this with 1.19 / 1.19.1/2 compat and it should work out of the box.

Can you please give it a try and post it here? I can test for you, if you want.

I just used cflookup.com to find out why I couldn't implement the deobf of Market Crates for 1.18.2. This way I can add support or module where the block of Market Crates can be used along with foreign wood_type from Biomes O' plenty or other mods that add wood_type.

I see you don't allowed 3rd distribution party. Is there a reason for this? if you have no reason, then can you change the setting to allow the distribution?