lewis6991 / spaceless.nvim Goto Github PK

With the new commit 9c8cbff I get an error when launching a telescope search (any sort of telescope thing, even just :Telescope)

Error detected while processing TextChanged Autocommands for "*":
Error executing lua callback: .../.local/share/nvim/lazy/spaceless.nvim/lua/spaceless.lua:46: Argument "start" is higher than "end"
stack traceback:
        [C]: in function 'nvim_buf_set_lines'
        .../.local/share/nvim/lazy/spaceless.nvim/lua/spaceless.lua:46: in function 'stripWhitespace'
        .../.local/share/nvim/lazy/spaceless.nvim/lua/spaceless.lua:56: in function <.../.local/share/nvim/lazy/spaceless.nvim/lua/spacel
ess.lua:53>

I've pinned back down to the previous commit 4012c77 and the error doesn't reproduce, so I think it's something in the new commit, but I'm not sure what exactly.

Hi, I love and use this plug-in every day. All the other whitespace stripping plug-ins I've tried would modify the whole file, it's nice that this plug-in only modifies the lines that you touch. My workplace is cautious about allowing code without a LICENSE file and it'd be a big help if this plug-in could use a FOSS license. I'm sure others in the same position and would appreciate it too. Could a FOSS license please be added if this plug-in is meant for public use?

Hi, Lewis. First of all, the plugin is flawless as far as my usage goes. Thank you for creating it.

Secondly, this thing is not an actual 'issue' per se because it doesn't affect the functionality. I am just asking out of curiosity.

This is how I setup the plugin and as you can see, lua_ls shows a warning:

When I looked into the actual plugin files, I found the line in picture below is what causing this warning because if I delete this line, save the file and go back to my plugin setup file, the warning goes away.

I would just like to know why this behaviour occurs and especially whether this is an intended behaviour or not.

Thanks again for the plugin as well as for reading through this message. ❤️

When using this plugin with numToStr/Comment.nvim, the mapping gcO or gcA to open a comment above or below the current line don't work properly.

Eg in lua:

Actual: string -- is inserted
Expected: string -- is inserted (as it is with the plugin disabled)

Would you consider porting the thirtythreeforty/lessspace.vim logic for white/blacklisting?

Or would such a thing be better accomplished by some autocmd filetype detection magic?

I would like to be able to temporarily enable / disable this plugin, and looking through the code I couldn't work out how.

Would you consider adding LessSpace{Disable,Enable,Toggle} commands for individual buffers?

They may be a pre-requisite for auto enable/disable by autocmd in #7.

I get the following error when opening the Telescope prompt:

Error detected while processing TextChangedI Autocommands for "*":
Error executing lua callback: .../.local/share/nvim/lazy/spaceless.nvim/lua/spaceless.lua:61: attempt to compare nil with number
stack traceback:
        .../.local/share/nvim/lazy/spaceless.nvim/lua/spaceless.lua:61: in function <.../.local/share/nvim/lazy/spaceless.nvim/lua/spaceless.lua:55>
        ...ocal/share/nvim/lazy/spaceless.nvim/plugin/spaceless.lua:12: in function <...ocal/share/nvim/lazy/spaceless.nvim/plugin/spaceless.lua:11>

Looks like #2/#5 would be a workaround if merged.