Comments (6)
@ronag The leveldown-as-a-base strategy has worked well for several years on rocksdb
and is the only reason I've been willing to maintain rocksdb
(ignoring my current hiatus). The many changes that you've made in your fork, as great as they may be, are not required to achieve abstract-level
compatibility.
@MeirionHughes TLDR, you can use ronag's rocks-level
(which I reckon is highly optimized, but it will stay in userland) or you can start fresh (which could become an org project and benefit accordingly, but will have to favor compat over raw performance).
from community.
I have made some good progress but I'm mostly developing for our in-house needs which might not work well for an open-source project. I would recommend you fork mine and continue from there.
from community.
It should be fully compatible with abstract-level. Mostly the development style that doesn't fit well with a open-source type package.
from community.
A better starting point is classic-level
. Take the minor differences between leveldown
and rocksdb
, and apply those to a fork of classic-level
. That gives us a good base for maintenance, i.e. being able to cherry-pick future commits from classic-level
to rocks-level
. Otherwise, there's no room for it in the Level org, just based on how many people are available to maintain it.
from community.
Yea... classic-level as a base didn't work for me and upstreaming changes was too slow. Another option would be to apply the "improvements" I've made to classic-level and then forking that into a rocks-level.
from community.
@ronag The leveldown-as-a-base strategy has worked well for several years on rocksdb and is the only reason I've been willing to maintain rocksdb (ignoring my current hiatus). The many changes that you've made in your fork, as great as they may be, are not required to achieve abstract-level compatibility.
Yes, didn't mean it as criticism. It just didn't work for me. I think your suggestion is better community-wise.
from community.
Related Issues (20)
- Proposal: add map method to abstract-down HOT 4
- Add `db.getMany(keys)` across the board HOT 8
- Refactor encodings HOT 6
- `rocksdb`: to be ported from `leveldown` (after other recent PRs)
- Fix Typings on DefinitelyTyped HOT 7
- Proposal: Add `db.has(key)` and `db.hasMany(keys)` HOT 12
- Deprecate old modules
- Package level with electron HOT 2
- Redisdown: how to create new `level-` libs? HOT 1
- Replace Sauce Labs with Playwright HOT 3
- Tracking issue: implicit and explicit snapshots
- willing to help revive some databases with abstract-level api HOT 4
- Switch to dependabot HOT 9
- Dump Buffer for TypedArrays (for compactness and efficiency) HOT 6
- Any interest in maintaining 'lmdb'? HOT 3
- Counting entries in a level database HOT 4
- leveldown to remote database HOT 1
- Maintenance round: drop legacy features & runtime environments HOT 1
- Move to GitHub Actions HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from community.