Git Product home page Git Product logo

Comments (7)

sebastianst avatar sebastianst commented on June 22, 2024

Cross-ref issue in levelup repo.

from community.

sebastianst avatar sebastianst commented on June 22, 2024

It would also be good to remove the unused type LevelUpBatch in the leveup types declaration file.

from community.

MeirionHughes avatar MeirionHughes commented on June 22, 2024

been delayed on this ... I'm in the middle of a init product release that is draining my will to live. Once that's done, and the rocksdb gets a new release, I'll start upgrading our dependencies and work through the types.

from community.

sebastianst avatar sebastianst commented on June 22, 2024

The return type of db.iterator() also needs to be fixed. It should be something like AsyncIterable<[K, V]>. The current custom return type doesn't allow for async (const x of it) syntax in typescript code.

from community.

sebastianst avatar sebastianst commented on June 22, 2024

The LevelUpConstructor interface could be improved to accept a ErrorValueCallback<LevelUp> as the third parameter, it currently only receives ErrorCallback. (Or ErrorValueCallback<LevelUp|undefined>?)

from community.

vweevers avatar vweevers commented on June 22, 2024

Relevant: Level/abstract-level#5

from community.

vweevers avatar vweevers commented on June 22, 2024

Closing because abstract-level and dependents have built-in type declarations. If someone wants to fix the typings of older modules on DT, go for it of course, but because @MeirionHughes is the main contributor of those types and seems to be busy, and the work needs to happen externally, I don't see an actionable item for us here.

from community.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.