Git Product home page Git Product logo

dungeontools's People

Contributors

axelwnilsson avatar baruchvlz avatar bluenightsky avatar bohdandiachun avatar bryanmytko avatar bsolar17 avatar calistusk avatar chriskader avatar crueldrool avatar dynaletik avatar grimonja avatar grimsbain avatar jammer avatar jat001 avatar juanptm avatar mallman1 avatar mmpashby avatar nnoggie avatar robincombrink avatar splitix avatar srenauld avatar stinth avatar stschake avatar toesmasher avatar tomslack avatar ueberbrot avatar urtgard avatar uujfwmnp avatar witnesscm avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

dungeontools's Issues

Global namespace polluting

mdtDB, oldPresetLen, newPresetLen, and currentIdx should be local.

mdtDb = LibStub("AceDB-3.0"):New("MythicDungeonToolsDB", defaultSavedVars).global
for dungeonIdx,presets in pairs(mdtDb.presets) do
if not db.presets[dungeonIdx] then
db.presets[dungeonIdx] = {}
end
oldPresetLen = #db.presets[dungeonIdx]
newPresetLen = #presets
-- Quick hack
db.presets[dungeonIdx][newPresetLen] = MDT:DeepCopy(db.presets[dungeonIdx][oldPresetLen])
currentIdx = oldPresetLen

Opening HoA/SoA does not work in v1.1.9

I have routes created in a previous version which I believe are set to week 4 affixes (Tyrannical/Inspiring/Necrotic/Prideful), in case that helps with tracking this down. I'm in the middle of a dungeon session right now so I don't have time to track this down, but I'll take a look afterwards.

Time: Sat Jan  2 18:34:02 2021
Count: 2
Stack: Interface\AddOns\DungeonTools\DungeonTools.lua:2807: attempt to index field 'value' (a number value)
[string "=[C]"]: ?
[string "@Interface\AddOns\DungeonTools\DungeonTools.lua"]:2807: in function `EnsureDBTables'
[string "@Interface\AddOns\DungeonTools\DungeonTools.lua"]:5092: in function <Interface\AddOns\DungeonTools\DungeonTools.lua:5044>
[string "@Interface\AddOns\DungeonTools\DungeonTools.lua"]:667: in function `ShowInterface'
[string "@Interface\AddOns\DungeonTools\DungeonTools.lua"]:62: in function `?'
[string "@Interface\FrameXML\ChatFrame.lua"]:5093: in function `ChatEdit_ParseText'
[string "@Interface\FrameXML\ChatFrame.lua"]:4757: in function `ChatEdit_SendText'
[string "@Interface\FrameXML\ChatFrame.lua"]:4793: in function `ChatEdit_OnEnterPressed'
[string "*:OnEnterPressed"]:1: in function <[string "*:OnEnterPressed"]:1>

Locals:

Routes not being saved

The routes are not correctly saved. You can't load your old routes and if you do a new route it is only temporarily saved. A /reload wipes the addon back to default, so does closing the game.

Bug: Issue with Skada?

After loading this new addon my Skada UI disappeared, can there be a conflict of some sort?

Suggestion: Informations in the Nameplate or Tooltip

Would be nice to have the function to see in the tooltip or Nameplate which Mobs i mark in Dungeon Tools.
For Example: I mark some mobs on the right side and ingame when i run the route it must show it on the tooltip that i mark them.

Hide/Show Minimap button doesn't work

In "Interface > Addons > ManbabyDungeonTools" there's an option to toggle the minimap icon, but no matter what it's always showing the minimap icon.

Client don't see the addon

I have downloaded an addon recently and it doesn't work from the start because client doesn't see him in modifications.

lua error when clicking on enemies in a route

To be honest I am not sure what were I clicking on it when I got this lua error. I think something on the right side, in the list of the pulls\packs. It was a premade route what I got from somwhere in MythicDungeonTools previously.

Message: Interface\AddOns\DungeonTools\DungeonEnemies.lua:492: attempt to concatenate field 'name' (a nil value)
Time: Sat Jan  2 18:03:53 2021
Count: 1
Stack: Interface\AddOns\DungeonTools\DungeonEnemies.lua:492: attempt to concatenate field 'name' (a nil value)
[string "@Interface\AddOns\DungeonTools\DungeonEnemies.lua"]:492: in function `DisplayBlipTooltip'
[string "@Interface\AddOns\DungeonTools\DungeonEnemies.lua"]:96: in function <Interface\AddOns\DungeonTools\DungeonEnemies.lua:92>

Locals: self = <table> {
 DeleteAllPresets = <function> defined @Interface\AddOns\DungeonTools\DungeonTools.lua:3152
 DungeonEnemies_UpdateSelected = <function> defined @Interface\AddOns\DungeonTools\DungeonEnemies.lua:842
 GetCurrentPull = <function> defined @Interface\AddOns\DungeonTools\DungeonTools.lua:2347
 LiveSession_RequestSession = <function> defined @Interface\AddOns\DungeonTools\LiveSession.lua:83
 PingMap = <function> defined @Interface\AddOns\DungeonTools\DungeonTools.lua:2321
 AddPull = <function> defined @Interface\AddOns\DungeonTools\DungeonTools.lua:4113
 DungeonEnemies_UpdateSeasonalAffix = <function> defined @Interface\AddOns\DungeonTools\DungeonEnemies.lua:945
 HideInterface = <function> defined @Interface\AddOns\DungeonTools\DungeonTools.lua:681
 GetBlip = <function> defined @Interface\AddOns\DungeonTools\DungeonEnemies.lua:758
 RestoreScrollframeScripts = <function> defined @Interface\AddOns\DungeonTools\toolbar.lua:498
 GetFullScreenSizes = <function> defined @Interface\AddOns\DungeonTools\DungeonTools.lua:867
 ADDON_LOADED = <function> defined @Interface\AddOns\DungeonTools\DungeonTools.lua:144
 UpdateDungeonEnemies = <function> defined @Interface\AddOns\DungeonTools\DungeonTools.lua:2624
 IsFrameOffScreen = <function> defined @Interface\AddOns\DungeonTools\DungeonTools.lua:1009
 dungeonEnemies = <table> {
 }
 IsCurrentPresetTyrannical = <function> defined @Interface\AddOns\DungeonTools\DungeonTools.lua:2282
 POI_CreateFramePools = <function> defined @Interface\AddOns\DungeonTools\Pointsofinterest.lua:9
 CreateDevPanel = <function> defined @Interface\AddOns\DungeonTools\devpanel.lua:134
 StartEraserDrawing = <function> defined @Interface\AddOns\DungeonTools\toolbar.lua:841
 SetLivePreset = <function> defined @Interface\AddOns\DungeonTools\DungeonTools.lua:2417
 GetDungeonName = <function> defined @Interface\AddOns\DungeonTools\DungeonTools.lua:276
 LiveSession_SendPreset = <function> defined @Interface\AddOns\DungeonTools\LiveSession.lua:201
 UpdateEnemyInfoData = <function> defined @Interface\AddOns\DungeonTools\EnemyInfo.lua:553
 HardReset = <function> defined @Interface\AddOns\DungeonTools\DungeonTools.lua:5028
 CleanEnemyData = <function> defined @Interface\AddOns\DungeonTools\DungeonEnemies.lua:1328
 GetHighestFrameLevelAtCursor = <function> defined @Interface\AddOns\DungeonTools\toolbar.lua:529
 DisplayBlipTooltip = <function> defined @Interface\AddOns\DungeonTools\DungeonEnemies.lua:460
 ClearPull = <function> defined @Interface\AddOns\DungeonTools\DungeonTools.lua:4150
 StringToTable = <function> defined @Interface\AddOns\DungeonTools\Transmission.lua:92
 SkinProgressBar = <function> defined @Interface\AddOns\DungeonTools\DungeonTools.lua:982
 MakeRenameFrame = <function> defined @Interface\AddOns\DungeonTools\DungeonTools.lua:4227
 DungeonEnemies_UpdateBoralusFaction = <function> defined @Interface\AddOns\DungeonTools\DungeonEnemies.lua:991
 initToolbar = <function> defined @Interface\AddOns\DungeonTools\toolbar.lua:14
 POI_UpdateAll = <function> defined @Interface\AddOns\DungeonTools\Pointsofinterest.lua:486
 OpenCustomColorsDialog = <function> defined @Interface\AddOns\DungeonTools\DungeonTools.lua:2696
 LiveSession_SendCommand = <function> defined @Interface\AddOns\DungeonTools\LiveSession.lua:180
 MakeCustomColorFrame = <function> defined @Interface\AddOns\DungeonTools\DungeonTools.lua:3648
 UpdatePresetDropDown = <function> defined @Interface\AddOns\DungeonTools\DungeonTools.lua:1888
 HSVtoRGB = <functio

Failed To load (Various)

Upon loading into the game after installing the addon, I'm greeted with all of these errors. (ignore the x2 part, I had relogged to see if it stayed around so it counted each error twice)

image

It looks like you're missing a bunch of the library files from the original MDT.

Mythic Dungeon Tools on Left, ManBaby on Right

image

Moving over the missing library files fixes most of the errors.

image

ManBabyDungeonTools not loading.

I attempted to download and install this version of the addon for use, however when I reloaded and relogged I could not get this version of the addon to show up in my addon list. I would LOVE to use this version for the lols, as it stands your data input string works wonderful and I'm using it at this moment.

Proper Changelog For Releases

If it is not to much trouble I would like to see a proper changelog for the new releases.
Maybe adapt a git commit style (maybe Conventional Commits) and from there move to a auto generated changelog and release notes with github actions?

Maybe its just me but I love the commit style and CHANGELOGS look so much better with it.

Release zip

The release zip should probably not contain the python dir or the .git dir. OopsIUpdated.txt is questionable I guess.

QOL improvements

I would love to have the ability to hide the right side bar and only show the map in sort of a read only view mode as my main usage is leaving it up during the dungeon, also having it auto swap to the correct floor like in Theatre of Pain would be awesome.

Idea for Prideful.

I tried to implement it on my own. Got the mob to show up by editing the lua for each dungeon, and it would show up wherever i put the XY at but without a name. I thought i would try to make it moveable by hacking it into being the mob for the old BFA Nyalotha Spire to make it moveable, but still no dice. The dev panel is wonky use to add stuff to maps esp with no real instructions on how to use it.

So here is my idea and the data i have for you guys. Make 5 "Manifestation of Pride" NPC Blips on the main map using the NPC half of the Nyalotha Spire VignettePinTemplate Blip which is already draggable and can be dropped onto the MapLinkPin POI's to move and place where we plan to spawn our prideful at. I know the pull counter colors the NPC portrait dragon on the pull number red for it, but its hard to really KNOW where its going to spawn when sharing a route. here is the NPC data for the prideful.

["id"] = 173729; ["characteristics"] = { ["Taunt"] = true; }; ["spells"] = { [340873] = {}; [342466] = {}; }; ["scale"] = 2; ["teemingCount"] = 0; ["count"] = 0; ["displayId"] = 97240; ["creatureType"] = L["Aberration"]; ["level"] = 60; ["health"] = 280000; ["name"] = L["Manifestation of Pride"];

Dungeon data

How can one update the dungeon data in an automated manner?

For example plaguefall currently seems to have wrong % as a route I follwed to the point did not get me to 100 as it should have.

Essentially what I am aslking is where do we get the % data so that we can regenerate the dungeon specific lua files?

Read-only mode / use mid-dungeon

Most of these would be for us that don't play enough to memorize all the routes, and frequently check stuff mid-run. Perhaps these are all too niche suggestions.

It would be nice to have a read-only toggle, which would allow clicking around in a hurry mid-dungeon without risk of making accidental changes.

While in read-only mode it would be an idea to have left-clicking mobs on the map highlight/scrolls to them in the pull list instead of removing them from their current group. In particular for routes that loop back to pick up percentage it would be nice to be able to go click on something in the map view to find where in the pull order it sits.

It would be nice if notes could somehow be attached to a pull. (i.e. if a pull group has a note then an icon would show both on the pull in map and on the pull list, and hovering either would show the note). The current map notes are helpful, but I think having it shown from both map and pull-list could be helpful for mid-dungeon checks.

How i can install the addon?

Hey , sorry for this obviusly question, but i Put the comppressed zip on retail but the addon didnt appear on the Game.

Thanks everyone will help me 👍

Marking the mobs

I have a suggestion for this, it sometimes feels hard (especially at the start) to memorize which mobs you gonna kill, and which you gonna pass, is there any way someone can implement a marking for the mobs that are in the route? So you know that you have to kill marked mobs, and avoid the mobs that aren't marked.

Week changer behavior

Is it possible to separate the week affixes dropdown choices from the saved routes? On this week I would like to see which mobs are inspired, and I have to change to the week to 4 on every single route\dungeon one by one, as I guess the week number is saved with the route. Since no Teeming it wouldn't be a big deal, and even now I can just leave it on an Inspiring week for the whole season I guess, but maybe in the future seasons would be useful if you once change the week to something, it stays there on all routes and dungeons until you change to something else.

The actual behaviour is ok I guess if you have different route saved for every dungeon every week, and you just choose the week4 necrotic wake route, and it automatically jump to week4, but I think this is the less common usage style.

Not working D:

I downloaded the file, extracted it to my addons folder for retail, and its not working any help would be greatly appreciated.

Slash commands and hiding minimap button lead to error

By either using the Slash commands /mdt or /manbabydungeontools or going into the options to hide the minimap button leads to following error:

2x ...eManbabyDungeonTools\ManbabyDungeonTools-3.3.4.lua:1042: bad argument #1 to 'random' (interval is empty)
[string "=[C]"]: in function `random'
[string "@ManbabyDungeonTools\ManbabyDungeonTools-3.3.4.lua"]:1042: in function `UpdateBottomText'
[string "@ManbabyDungeonTools\ManbabyDungeonTools-3.3.4.lua"]:676: in function `ShowInterface'
[string "@ManbabyDungeonTools\ManbabyDungeonTools-3.3.4.lua"]:32: in function `OnClick'
[string "@BigWigs\Libs\LibDBIcon-1.0\LibDBIcon-1.0-44.lua"]:144: in function <BigWigs\Libs\LibDBIcon-1.0\LibDBIcon-1.0.lua:142>

Locals:
(*temporary) = 0

Edit: Clicking on the minimap button leads to same error (opens the window though)

Cant seem to install

Installing it dosnt seem to work for me. Ive placed it in the addons folder but nothing shows up in game

Solution for unloaded enemy data

Hey guys, just a quick note from someone who has the new version working (to some extent anyways). If you know then ignore.

Step 1 -> Download the most recent version of MDT (Trust Me)
Step 2 -> Download the 3.3.4 version (3f4065e) from December 13th
Step 3 -> Replace all files from current MDT with those in the 3.3.4 versioning
Step 4 -> Open MythicDungeonTools.toc, add a line at the end of the file for dataImport.lua
Step 5 -> Use MDT renamed as MBDT, because fuck that guy, he is just being salty and the community needs a tool like this.

Hope this helps (I already did this to mine and got everything working, no manual import necessary 👍 )

Discord server,Patron for DungeonTools?

Hi there,

Is there a discord server / Patron you could setup for the community? :)

Optional Donations and such with cool perks people could use, I think is a good idea. Like sort of "Buy me a coffee" a nice appreciation for your hardwork and time to help the community :)

Just saves everyone making an Issue request on github for things that could be explained on discord and faster replies 🥇

Angry triangle is back

So this is a minor issue which is goin on a while ago in MDT, I know Noggie fixed a bit once, but looks like it's still happening here and there.

So it's 4th week, you can see the week number is green, but the angry triangle is still there, warning you it's a wrong week. You can recreate this issue by choosing any route which has stored a different week - getting the triangle correctly - then changing dungeon, which having already set a correct route with a correct week - but the triangle is still out.

image

previous ticket about this in MDT: Nnoggie/MythicDungeonTools#138

Cannot install the addon

Cannot find the addon in the charachter select addon list after unziping the downloaded zip file.
Its not clear how it shoulld be installed.

Selecting other dungeon is broken

Hi,

I have an issue while selecting an other dungeon on the current version (1.1.12) it doesn't display the sub maps and the actual map anymore.
image

Occurs on Other side, Mists, Plaguefall, Sanguine Depth, Theater of pain. If logs are needed, please let me know.

How i can insttal it?

Hey , sorry for this obviusly question, but i Put the comppressed zip on retail but the addon didnt appear on the Game.

Thanks everyone will help me 👍

Version number in ManbabyDungeonTools.toc

Don't know if you want to adjust the version in the ManbabyDungeonTools.toc. It still says 3.3.4. Should be changed to ManbabyDungeonTools newest release.
To automate this perhaps a tool like bump2version can be used for this purpose.

Also, you might want to edit the author and list Nnoggie as the original author but not as the author of this tool? I mean this is only a small thing and not necessary but it separates more form the "original" one.
And looking in the future when you want to add new functionality or as stated by @srenauld "untangle it" it would be beneficial I think.

But its just a thought :).

Routes not saving

Love the work all, the community can't thank you enough because, fuck that guy.

I am having an issue where my routes are not saving and I have to recreate them every time.

Addon Not Popping Up In Game

I have downloaded and extracted this addon to the WOW folder, and its in my addon folder with all the info, but whenever I open my game the addon doesn't seem to pop up in my addon list anywhere for me to actually use in game not sure what I'm missing if you could possibly assist with a suggestion.

Unlinking mobs

Could you unlink some packs? I can update it on my end but it reverts every time I update the addon itself. I don't know how to send you the edited version or I would go through and do it again myself and send it to you, sorry new to GitHub.

Halls of Attonement:
These mobs should be linked together and not in the group they are currently in:
Shard of Halkias 1 (G12)
Depraved Collector 1 (G12)

Shard of Halkias 3 (G3)
Depraved Collector 3 (G3)

Shard of Halkias 2 (G25)
Depraved Collector 2 (G25)

These mobs should be unlinked from eachother:
Stoneborn Slasher 2 (G38)
Stoneborn Slasher 4 (G38)

De Other Side:
These mobs should be unlinked from their groups:
4.RF-4.RF 1 (G8)
Headless Client 1 (G8)
Territorial Bladebeak 1, 3, 4, 5, 6, 8, 9, 10, 11, 12
Bladebeak Matriarch 3 (G34)

Plaguefall:
These mobs should be unlinked from their groups:
Plagueborer 2 (G5) - This pats away from its pack and can be solo pulled then.
Plagueborer 3 (G6) - This pats away from its pack and can be solo pulled then.

Sanguine Depths:
These mobs should be unlinked from their groups:
Gluttonous Tick 1 (G4)
Gluttonous Tick 2 (G4)
Gluttonous Tick 3 (G4)
Grubby Dredger 1 (G4)
Grubby Dredger 2 (G4)
Insatiable Brute 2 (G4)
Chamber Sentinel 5 (G34)

Theater of Pain:
These mobs should be unlinked from their groups:
Shattered Souls 1-12

just reporting a lua error

opening the gui greets with

1x ...eManbabyDungeonTools\ManbabyDungeonTools-3.3.4.lua:1042: bad argument #1 to 'random' (interval is empty)
[string "=[C]"]: in function `random'
[string "@ManbabyDungeonTools\ManbabyDungeonTools-3.3.4.lua"]:1042: in function `UpdateBottomText'
[string "@ManbabyDungeonTools\ManbabyDungeonTools-3.3.4.lua"]:676: in function `ShowInterface'
[string "@ManbabyDungeonTools\ManbabyDungeonTools-3.3.4.lua"]:32: in function `OnClick'
[string "@BigWigs\Libs\LibDBIcon-1.0\LibDBIcon-1.0-44.lua"]:144: in function <BigWigs\Libs\LibDBIcon-1.0\LibDBIcon-1.0.lua:142>

Locals:
(*temporary) = 0

thank you for this regardless <3

DungeonTools conflicts with MDT

Hey,

I have both DungeonTools and MDT installed and it looks like they doesn't work together.

World.of.Warcraft.2020-12-30.20-52-05_Trim.2.mp4

And if I disable MDT then DungeonTools works well. May be you have any idea about reasons of that.

DungeonTools v1.1.6

Add-on not working at all

First off, thanks guys for doing this!
Secondly, I am having an issue with the add-on loading at all. I am get 12 Lua Warnings.
error loading: Libstub
Aceaddon-3.0
Callbackhandler-1.0
AceDB-3.0
AceGUI-3.0
ChatThrottleLib
AceComm-3.0
AceSerializer-3.0
LibCompress
LibDataBroker-1.1
LibDBIcon-1.0
AceConfig-3.0

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.