lennet / figma-timer Goto Github PK

This could be optimised with a switch-case. Similar to the logic in ui.html

Originally posted by @lennet in #1

Would be nice to have a small CI setup using Github Actions and some basic tests

I am working on a feature that would show active timers in a floating window (ui.html) so the user can see it regardless of where they are on the Figma stage. Due to API limitations, this will only show up for the creator of the timer, not for other people that are viewing the document.

Reference Screenshot of page: https://www.figma.com/community/plugin/820311256083321341/Timer

The link for timebox has a period in the end. And so it gives the following error

Is there a reason for not using a boolean here?

Originally posted by @lennet in #1

I would like to request for the timer to be able to count up.

Hey Leo, I saw that I can use 'create issue from conversation' - so I created some issues for the code suggestions you made. @lennet will work on it today or tomorrow

A user asked for running the timer in a Figma Prototype. I‘m not sure if that’s supported by the API but we could reach out to Figma and ask them if that’s something on their Roadmap

same here. Let's use a boolean

Originally posted by @lennet in #1

It would be good for users to see the elapsed time after a timer is finished, that way they can see how much 'over time' that are already. We can just add a minus before the elapsed time e.g. Timer: -0:29

https://www.figma.com/community/file/824677652393376493

add a new button to UI.html, so that people can create a timer from there. Clicking the button should add a timer text field to the Figma stage.

TBD: should UI.html also contain a text field to enter amount of minutes / seconds for the timer?

We are currently just counting down an integer with isn't super accurate. We should save start date for each timer and calculate the remaining seconds based the current time.

Would be nice to create a testplan of automated & manual tests that we run before we publish a new version

Thanks for your contribution, I like the new feature!

I left you some comments. Overall it would be nice if you could:

• Remove dead code (logs, unreachable code or code that is commented out)
• Use boolean instead of integers (e.g. var paused = false instead of var paused = 0 )
• Apply a code formatter to the files you changed (in VS Code you can right click and select Format Document)

Originally posted by @lennet in #1 (comment)