Make the bundle Symfony 3.0 compliant about vipxbotdetectbundle HOT 7 CLOSED

Are you able to make a PR for this and add the new version to the composer file? This way we can run all the tests and see if your changes are enough to make the new Symfony version work.

from vipxbotdetectbundle.

Ping @tbyte80

from vipxbotdetectbundle.

I'd be happy to make a PR for this to get Symfony 3.0 compatibility, but I can't see any reference to line mentioned above in the bundle anywhere?

from vipxbotdetectbundle.

Ah, I needed to look at the underlying package the bundle uses. It looks like the Symfony 3.0 updates have been made in the package - would this mean its just a case of updating the composer.json?

from vipxbotdetectbundle.

This is fixed in the underlaying library (see lennerd/vipx-bot-detect#37).

Never the less I would be happy to get your PR to fix this. What needs to be done is fixing the composer file and automatic tests running via Travis to test against Symfony 3. A good reference for this is again the base library.

https://github.com/lennerd/vipx-bot-detect/blob/master/composer.json#L17-L18
https://github.com/lennerd/vipx-bot-detect/blob/master/.travis.yml#L20-L27

from vipxbotdetectbundle.

Hey,

I've made the PR (#14) - hope that everything is in order in it, if not let me know what I need to change!

Cheers

from vipxbotdetectbundle.

Closed with #14.

from vipxbotdetectbundle.