leifadev / scout Goto Github PK

I would recommend creating a makefile to assist contributors with building, testing, and contributing.

The README says that this program has been tested to work on Python versions 3.7-9.2. This isn't entirely possibly considering the fact that there are no major Python versions past 3. I'm not entirely sure what the correct version number would be, so that's why I'm making an issue instead of a pull request.

This is the requirements.txt file. The program is able to run without errors with only the requirements that are commented with the exception of pyinstaller.

#     altgraph==0.17
#     certifi==2020.12.5
#     macholib==1.14
pyinstaller==4.2
#     pyinstaller-hooks-contrib==2021.1
pytube==10.6.0
#     PyYAML==5.4.1
ruamel.yaml==0.16.13
#     ruamel.yaml.clib==0.2.2
#     typing-extensions==3.7.4.3
wget==3.2

Problem:
There is no requirements.txt, so the user must manually install dependencies based off error messages.

Solution:
Create requirements.txt with all dependencies included.

VideoPrivate: is not defined. line 229. and I'm assuming all the ones under it. when I marked it out it went on to the next one.
Windows 10
id also recommend maybe adding something like this to the top

try:
from pytube import YouTube
except ImportError:
print ("Trying to Install required module: requests\n")
os.system('pip3 install pytube3')

that way people don't have to install manually

The entire app is rewritten for each os. It would be better to create an interface in which the os-unique code and the common code are separate.

The readme file includes a row for Windows 8, which is unnecessary because very few users use Windows 8. According to this website, less than 5% of windows users use Windows 8, which comes out to less than 1.5% of users across all operating systems.
| Windows 8 | ? |