lefred / online-migration Goto Github PK

pt-online-schema-change h=127.0.0.1,P=3306,u=root,p=,D="world",t=City --alter="ALTER TABLE world.City DROP INDEX pol_idx, DROP COLUMN PolutionLevel;

"
-bash: world: command not found
-bash: City: command not found

When for any reason (SQL syntax for example) the migration creation fails, all the steps already done for that migration should be removed.

Ex:

  [root@devel ~]# ./online-migration.py create world sql1.sql "tables creations"
  ERROR : ("Query failed. 1064 (42000): You have an error in your SQL syntax; check the manual that
  corresponds to your MySQL server version for the right syntax to use near ') ENGINE=InnoDB 
   DEFAULT CHARSET=latin1' at line 1", 0) !

On the filesystem, the files xxxx-down.mig and xxxx-up.mig should be removed (xxxx-up.meta is not created when it fails).

The database record with status "running" should be removed too:

mysql> select * from migration_sys;
+----+-------+---------+---------------------+---------------------+---------+
| id | db    | version | start_date          | apply_date          | status  |
+----+-------+---------+---------------------+---------------------+---------+
|  1 | world |       0 | 2014-08-01 21:34:17 | 2014-08-01 21:34:17 | ok      |
|  2 | world |       1 | 2014-08-01 22:57:41 | 2014-08-01 22:57:41 | running |
+----+-------+---------+---------------------+---------------------+---------+

When init for a database that doesn't exist yet is called, an python staktrace is returned but the folder and the file 0000-up.mig are created.
An entry with satus "ok" is also created in online_migration.migration_sys which is bad !

If GTID are used, the schema checksum is different as it includes the GTID:

[root@production world]# diff 0000.schema_tmp 0000.schema_tmp.dev
3c3
< SET @@GLOBAL.GTID_PURGED = 'e6045074-4734-11e4-9885-0800272e951c:1-211';

SET @@GLOBAL.GTID_PURGED = '1b6a42a0-4736-11e4-988c-0800272e951c:1-262';

Would it be possible to add store procedures support to the versionning tool ?
With schema changes comes SP changes in many cases.

I would be glad to help, to do this.

If pt-online-schema-change is not found, we should stop (until we specify we won't use it, if this new feature
gets implemented).

We avoid this and let bad status:

ERROR : Problem while running :
    pt-online-schema-change h=127.0.0.1,P=3306,u=root,p=,D="world",t=City --alter="add PolutionLevel int;" 
    --execute >>online_migration.log 2>&1

Let's add cfg file to deal with the connections. The file will be /etc/online-migration.cfg and its content will be like:

 [world]
 user=root
 password=fred
 host=127.0.0.1
 port=3340

 [sysbench]
 user=test
 password=test
 host=127.0.0.1
 port=3306