leezhixuan / ped Goto Github PK

Should be "with a deadline" rather than "with deadline"

Should include the fact that give assigns an assignment to one student as well as the face that giveall assigns an assignment to ALL students under a module.

Claims that “if there are 2 identical prefixes in the command, only the last one works

To reproduce:

1. Find t/t5 t/t8

I'm sorry but that doesn't make a lot of sense
The ability to do so isn't recorded in the UG as well

And due dates are not changed.

To reproduce:

1. Have a number of students already with that assignment (i.e., Lab3) in the list (but with a different due date)

2. giveall m/cs1231s d/Lab3 by/ 14/06/2015

Users are able to add emails with local-part longer than 64 characters but this shouldn't be the case

To reproduce:

1. add n/carl jr m/cs1231s e/1234567890123456789012345678901234567890123456789012345678901234+x@u.nus.edu t/t5
   To reproduce:
2. edit 1 e/234567890123456789012345678901234567890123456789012345678901234+x@u.nus.edu

"Exiting the program : exit" should be "Exiting the program: exit"

According to the error message, the only constraints for “local-part” are:
1. Alphanumeric characters
2. Special characters: + _ . -
And nothing else.

But this command: “add n/harry m/cs1231s e/[email protected] t/t5” continue to be invalid

To reproduce:

1. give 11 d/Lab13 by/ 28/02/2021, 1800

"Marking an assignment : done" should be "Marking an assignment: done"

"Only works if current displayed assignment list is non-empty." should be "Only works if the currently displayed assignment list is non-empty."

"Assignment list will be sorted by status and date." should be "The assignment list will be sorted by status and date."

"Assignments with same status will be sorted by due date." should be "Assignments with the same status will be sorted by the due date."

"Shows the assignment list of student at the specified INDEX." should be "Shows the assignment list of the student at the specified INDEX."

"Viewing help : help" should be "Viewing help: help

"Clearing all entries: clear" should have been "Clearing all entries: clear"

The result of "find" should show the assignments of the top result or clear the content in the assignments window altogether. Users may be confused by the current implementation

To reproduce:

1. find n/roy
2. Show 1

"Listing all students : list" should be "Listing all students: list"

"Redoing the command : redo" should be "Redoing the command: redo"

"Recovers the effect of last undo command." should be "Recovers the effect of the last undo command."

"Redo all kinds of command except for undo and redo." should be "Redo all kinds of commands except for undo and redo."

IMO on top of names, emails should not be duplicated as well

Would be good if this is standardised throughout

"Deleting an assignment with deadline : remove" should have been "Deleting an assignment with a deadline: remove" or "Deleting an assignment: remove"

"Removes the assignment at INDEX in current displayed assignment list of a student." should have been "Removes the assignment at INDEX in the currently displayed assignment list of a student."

"Caution: If your changes to the data file makes its format invalid, TA2 will discard all data and start with an empty data file at the next run." should be "Caution: If your changes to the data file make its format invalid, TA2 will discard all data and start with an empty data file at the next run."

To reproduce:

1. giveall m/cs1231s d/Lab3 by/ 12/07/2012

"Deleting a student : delete" should be "Deleting a student: delete"

"Editing a student : edit" should be "Editing a student: edit"

"Modifies any part of student’s information." should be "Modifies any part of the student’s information."

"till the index of last student" should be "till the index of the last student"

"edit 2 e/[email protected] replaces the 2nd student’s email with [email protected] in contact list." should be "edit 2 e/[email protected] replaces the 2nd student’s email with [email protected] in the contact list."

Where did find command come from? And there is no mention of any arguments provided to the "find" command.

Does it mean Tag or Tutorial_Number?

"Undoing the last command : undo" should have been "Undoing the last command: undo"

"Undo all kinds of command except for undo and redo." should be "Undo all kinds of commands except for undo and redo."

"At the start of program, nothing can be undone." should be "At the start of the program, nothing can be undone."

To reproduce:

1. give d/Lab5 by/ MON

No 2 students will have the same email

To reproduce

1. add n/carl m/cs1231s e/[email protected] t/t5
2. add n/carlos m/cs1231s e/[email protected] t/t5
   

Suggestion: Should give users a heads up that they’ve entered an invalid date instead of going straight ahead to replace it

To reproduce:

1. give 11 d/Lab 14 by/ 29/02/2022, 1800

"Ordering of prefixes are not strict and allows for multiple keywords"

It is "incomplete" rather than "uncomplete"

Claims that find m/CS1101S CS2103T will return people who take either / or both modules
But it is impossible to have any entry to have more than 1 module under their name

To reproduce:

1. add n/carlosos m/cs1231s cs2100 e/[email protected] t/t5
2. edit 1 m/cs1231s cs2100 e/[email protected] t/t5
3. find m/cs1231s cs2100

"Adding assignments : give giveall" should be "Adding assignments: give giveall"

"Adding an assignment : give" should be "Adding an assignment: give"

"Date can be replaced by friendly commands." should be "The date can be replaced by friendly commands."

"give 1 d/Lab1 by/ 21/8/2021 gives the first student in current displayed contact list Lab1 with deadline 2021, Aug 21." should be "give 1 d/Lab1 by/ 21/8/2021 gives the first student in the currently displayed contact list Lab1 with deadline 2021, Aug 21." and many more

Also, no mention that t/ could be blank since users weren’t allowed to leave n/, e/, or m/ blank.

To reproduce:

1. edit 1 t/

Plenty of missing determiners. For example, "find n/Bernice returns the students with name Bernice." should have been "find n/Bernice returns the students with THE name Bernice."

"find n/Evian m/CS2103T t/Group10 returns the students who at least satisfy one of requirements: with name Evian, study moduleCS2103T and in tutorial Group10." should have been "find n/Evian m/CS2103T t/Group10 returns the students who at least satisfy one of the requirements: with name Evian, study moduleCS2103T and in tutorial Group10."

Would "incomplete" be a better status than "pending" since "pending" could also mean yet to be given out.