learn-co-curriculum / react-hooks-npm-lab Goto Github PK

Canvas Link

https://learning.flatironschool.com/courses/5186/assignments/179983?module_item_id=397437

Concern

With this instruction:

Run 'npm start' to run this script

you are ok with poking any readers who were not alert to your guidance about adding '"start": "serve"' to the 'scripts' property, right?

That is, to me, the passive reader, I did not perceive the guidance to manually edit 'package.json'. I thought "using the serve package" was sufficient per:
This serve (Links to an external site.) package will run a lightweight server. We can set up another npm script to run the server using the serve package:

Additional Context

No response

Suggested Changes

Maybe this was magical thinking on my part, and it's good to poke me into a more active reading stance re your instructions.
Otherwise, if you intend a more gentle tour through package setup and usage, maybe make it explicit that you expect the reader to do something:
We can set up another npm script to run the server using the serve package:

"We can" is not as clear as something like:
You should set up another npm script to run the server using the serve package by updating the scripts property:

Canvas Link

https://learning.flatironschool.com/courses/7034/pages/npm-code-along?module_item_id=637876

Concern

Line 212 of the README: "Go ahead and run npm run build."

Additional Context

Received the error message:

Could not resolve "./node_modules/date-fns/esm/format/index.js"

Suggested Changes

My instructor was able to resolve the error by having me change line 3 of color-clock/index.js

FROM
import format from "./node_modules/date-fns/esm/format/index.js";

TO
import {format} from "date-fns";

Canvas Link

https://learning.flatironschool.com/courses/5186/assignments/179983?module_item_id=397437

Concern

In the following, it seem 'date-fns' should be an active link to a module, but the link is not active for me:
a package has been created to help us: date-fns.

Additional Context

No response

Suggested Changes

I'm thinking that in here:
created to help us: date-fns.

The 'date-fns' is supposed to be an active link the way that 'serve' is active in the following:
This serve (Links to an external site.) package will run

So update 'date-fns' to work like 'serve'?

Canvas Link

https://learning.flatironschool.com/courses/4550/assignments/157562?confetti=true&submitted=0

Concern

The instructions say "Run npm start to run this script, and open up localhost:5000 (Links to an external site.) in the browser.", but my JSON server uses 3000 by default.

Maybe realizing it could be different is part of the challenge though? I passed!

Additional Context

No response

Suggested Changes

No response

Canvas Link

https://learning.flatironschool.com/courses/6336/pages/npm-code-along?module_item_id=544381

Concern

Uncaught TypeError: Failed to resolve module specifier "@babel/runtime/helpers/esm/typeof". Relative references must start with either "/", "./", or "../".

This is the error I was getting immediately after following all of the steps provided. I worked with a TC and was also unable to figure the issue. Please advise.

Additional Context

No additional context

Suggested Changes

No suggestions

Canvas Link

https://learning.flatironschool.com/courses/4550/assignments/157562?module_item_id=335736

Concern

I installed the packages correctly but was unable to get the clock to work. when I ran "npm start" I got this error:
npm ERR! Missing script: "start"

When I finally got it to work, it used localhost:3000, not localhost5000 as said in the readme.

Additional Context

No response

Suggested Changes

No response

Canvas Link

https://learning.flatironschool.com/courses/7022/pages/npm-code-along?module_item_id=624563

Concern

Had a student go through this and when running
npm install date-fns
It installed 3.1, which would cause all of this code to fail, we should update the code or instruct the student to install the version in the solution using
npm install [email protected]

Additional Context

No response

Suggested Changes

No response

Canvas Link

https://learning.flatironschool.com/courses/5186/assignments/179983?module_item_id=397437

Concern

This sentence interrupted my flow of understanding, and not in a helpful way:
Node packages are written so we don't have to re-find a solution other programmers have found.

The idea is about bits of code that have been offered up for use by others. To use such modules, I will need to "find" them, so to read "we don't have to re-find a solution" threw me off-track. What do you mean that I won't have to "find" these other modules?

It took much re-reading and mental processing to figure out the desire was to avoid writing code when others have already written and shared code for such situations.

Additional Context

No response

Suggested Changes

Maybe instead of this:
Node packages are written so we don't have to re-find a solution other programmers have found.

something like this?
Other programmers write node packages to share coding solutions they have found. And this saves us from coding up the same thing!

(Anyway, something different from "re-find a solution" as a term for "writing up code".)

This section of the README is a bit confusing:

Most prompts will provide a default value. Some are blank and can be left this way for now. Follow the prompts until the end and a fully constructed package.json file will appear in the color-clock directory.

Recommend changing to:

Most prompts will provide a default value. Some are blank and can be left this way for now. Follow the prompts by pressing enter in the terminal on each prompt until you reach the end, when you will be prompted to type 'yes' to confirm. A fully constructed package.json file will then appear in the color-clock directory.