learn-co-curriculum / rails-blog-associations-validations Goto Github PK

Under the Migrations, Associations, and Routes heading for this lab, there are instructions to create controllers for User and Tag, along with 'appropriate routes.' These controllers aren't actually needed, though, to pass existing lab specs. Would it be possible to introduce minimal features testing for User and Tag, to justify the files and routes? Or--alternatively--to clarify the reason(s) for creating these files, routes in the readme?

I have completed this lab, staged, committed, and pushed it up to github and sent a pull request but on the lesson page it shows that the pull request submission is failing. :(

This block
https://github.com/learn-co-curriculum/rails-blog-associations-validations/blob/master/spec/spec_helper.rb#L26

conflicts with this
https://github.com/learn-co-curriculum/rails-blog-associations-validations/blob/master/spec/01_models/01_user_spec.rb#L18

given that Users have to have unique names. Removing config.before(:each) from the spec_helper allows correct code to pass the tests.

The seed data should be moved the spec itself. The students have trouble reading the spec because the instances are created in the spec_helper.

@AnnJohn

Hi! This lab is missing app/assets/config/manifest.js (seems to be required by the railties gem) and missing rails_helper.rb. I was able to solve this by creating a blank app/assets/config/manifest.js file and copy+pasting the rails_helper.rb file from the has-many-through-forms-rails lab, and the rspec tests now seem to be running. Thanks!

The spec tests all pass, but when running the Rails server, creating a post fails when selecting at least one tag. Tag is failing validation, I think possibly because the uniqueness validation thinks that a new tag is being created. Here are the error details:

@details={:tags=>[{:error=>:invalid}]},
@messages={:tags=>["is invalid"]}

Ask a Question couldn't help me, so I wanted to flag this.

This lab seems a little out of place in at the end of the sequence. This is more like a beginner lab after you've build a scaffold. you're doing basic many <-> many associations, and simple validations

The lab runs on an outdated version of rspec-rails which is breaking because it is now trying to require rails_helper instead of the former spec_helper