Git Product home page Git Product logo

phrg-refactoring-tests's Introduction

Refactor Previous Lab's Tests

You will recognize this as Learn's "ActiveRecord Validations Lab" with two added tests. We are going to refactor its test files to use factories, and be more explicit about what is getting tested (by removing let).

What needs to be done

First, use valid attributes to create Post and Author factories. There will be no need to invoke Model#new in any of your tests. Rely on building and createing your factory blueprints.

Next, remove all the let declarations by moving logic directly into the test examples. Here is an example from the post_spec.rb.

BEFORE (as it stands now):

it "is invalid with too short content" do
  expect(short_content).to be_invalid
end

AFTER you fix it:

it "is invalid with too short content" do
  expect(build(:post, content: "too short")).to be_invalid
end

phrg-refactoring-tests's People

Contributors

connorgallopo avatar garettarrowood avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.