Canvas Link

https://learning.flatironschool.com/courses/6444/assignments/244094?module_item_id=574893

Concern

On canvas it says this:
The Contract class should have the following methods:

A class method contracts_by_date(cls, date): This method should return all contracts that have the same date as the date passed into the method.

The test however tells you to pass 0 arguments and to sort the contracts by date.

Additional Context

No response

Suggested Changes

You can either change the instructions on canvas or change the test itself.

Canvas Link

https://learning.flatironschool.com/courses/6559/assignments/242929?module_item_id=571576

Concern

Lines 67 and 68 of the README.md are asking for a class method that returns every contract that was produced on the same date. However, the test is looking for a function that sorts all of the contracts by date. Also, if you put in the params that the README.md asks for, you will get a TypeError as the tests believes you only need 1 required positional argument.

Additional Context

No response

Suggested Changes

I noticed other issues have been raised about this lab for months, please update either the README or the tests to reflect what is desired.

Canvas Link

https://learning.flatironschool.com/courses/6845/assignments/258999?module_item_id=614101

Concern

The README Instructions section lacks many of the requirements to pass the tests.

For example, it does not mention any methods for the Book class even though there are two tests requiring methods in Book (contracts() and authors())

Additional Context

No response

Suggested Changes

No response

Canvas Link

https://learning.flatironschool.com/courses/6435/assignments/242503?module_item_id=570054

Concern

Last ReadMe and pytest are not asking for the same thing. One wants a sorted list and the other just wants data compared.

Additional Context

if you put all soultion code in except for last attribute in Contracts contracts_by_date(cls, date) you will see. also date param is not included or needed for pytest solution.

Suggested Changes

just very annoying and this lab was a little dense compared to other labs and i have heard alot of complaints from my cohort so just thought i would bring it to somebodies attention for the future i know you guys are busy.

Canvas Link

https://learning.flatironschool.com/courses/6568/assignments/244959?module_item_id=577038

Concern

In this lab, one of the things I needed to implement was the contracts_by_date class method, and the testcase for this class method described its test as """Test Contract class has method contracts_by_date() that sorts all contracts by date""". However, contracts_by_date() takes a date as its argument and returns a list of contracts made in the date. Since all contracts in the return value were on same date, how could I sort the list by date?

Additional Context

No response

Suggested Changes

I think the test should ask me to sort the return value, a list, by author's name, book's title or royalties.

Canvas Link

https://learning.flatironschool.com/courses/6192/assignments/240664?module_item_id=565714

Concern

Canvas says this:

A class method contracts_by_date(cls, date): This method should return all contracts that have the same date as the date passed into the method.

And pytest says this: """Test Contract class has method contracts_by_date() that sorts all contracts by date"""

Additional Context

No response

Suggested Changes

Doesn't matter I just figured you would want to know. It confused me for a bit until I looked at the solution

Canvas Link

https://learning.flatironschool.com/courses/6200/assignments/240673?module_item_id=565718

Concern

The final check for the test asks for a method contracts_by_date() that SORTS all contracts by date, while the instructions ask for a method of the same name that returns all contracts that HAVE THE SAME date as the date passed into the method.

Additional Context

No response

Suggested Changes

Change the test to reflect the instructions or vice versa.

Canvas Link

https://learning.flatironschool.com/courses/6192/assignments/240664?module_item_id=565714

Concern

The lab in canvas wants you to write the method 'contracts_by_date' to return all the contracts that were on the date that it passses in as a parameter. The actual test is testing if all the contracts are sorted by date (not returning contracts on a specific date.

Additional Context

Canvas lab wants you to code this:
@classmethod
def contracts_by_date(cls, date):
return [contract for contract in cls.all if contract.date == date].

While the test file is testing for this code:
def contracts_by_date(cls):
return sorted(cls.all, key=lambda contract: contract.date)

Suggested Changes

I just figured you might want to know