learn-co-curriculum / fewpjs-fetch-lab Goto Github PK

function renderBooks(json) {
  const main = document.querySelector('main')
  json.forEach(book => {
    const h2 = document.createElement('h2')
    h2.innerHTML = `<h2>${book.name}</h2>`
    main.appendChild(h2)
  })
}

Some problems with this:

• Calling .json() doesn't turn a response into JSON- it turns a JSON string into a JS object. This function should take in something like books.
• Setting the innerHTML of an h2 to an h2 nests them: <h2><h2>A Tale of Two Cities</h2></h2>

After completing this lab, I find that the tests do not run. I've tried to download the solution and run the tests to no avail as well.

The error I get is as follows

// ♥ Traceback (most recent call last): 9: from /Users/donnovanlyons/.rvm/gems/ruby-2.6.4/bin/learn-test:23:in

I am flagging the below as an issue because this lab seems to be an outlier.

• Events Leading to Error
  running learn on my system consistently produces this error:

• Error Message
  /Users/home/.rvm/gems/ruby-2.6.1/gems/learn-test-2.6.1/lib/learn_test/strategies/mocha.rb:42:in `results': undefined method `[]' for nil:NilClass (NoMethodError)

• Additional Testing
  Even after completing the assignment correctly (confirmed by comparing my code with the solutions branch), learn throws the same error; I initially suspected the results error may have relied upon completion of the assignment to populate the test's results method with an array of data from Game of Throne's API.

EDIT:

• Temporary Fix: I was able to get around the issue by commenting out Flatiron's unit test file, running learn, and then running npm audit fix.

The function renderBooks is not present, and there are no tests for this lab.

inedx.html is missing <script type="text/javascript" src="index.js"></script>

Also, the following code passes all test cases even though renderBooks is never called:

function fetchBooks() {
  fetch('https://anapioficeandfire.com/api/books')
  .then(resp => resp.json())
  .then(json => console.log(json));
}

The correct code should be:

function fetchBooks() {
  fetch('https://anapioficeandfire.com/api/books')
  .then(resp => resp.json())
  .then(json => renderBooks(json));
}

Main tag is required in index.js but missing in index.html

api works fine from US, when i vpn in from canada i see an error on the page

Not explicit that students have access to these endpoints, or where in documentation they should look.

All the Houses in Game of Thrones
The 5th book in the series
The 1031st character in the series

#staff

Under deliverables:

In order to give them access, write you solution so that

should be "your solution"