Git Product home page Git Product logo

building-nested-hashes's People

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

building-nested-hashes's Issues

Completed Lab not showing as complete

This is now the second time this has happened to me.

The first was in the new Using Arrays lab that Learn.co sneakily added in on Tuesday (11/10,15)
I completed the lab and the green circle is not filled in.

Now the building nested hashes lab (this one) is shown on the left the exact same way, no green circle.

incorrect character name

This is so silly, but Juliet's name is incorrectly spelled "Juliette" both in the lesson and the tests.

The last section is labeled "Bonus", but the tests don't pass unless it is completed.

Hello. The last section is labeled as a "Bonus" section, which seems to imply that completing it is optional. However, the tests currently will not pass unless the "Bonus" section is completed.

To be fair, the last section is fairly easy to complete if one is familiar enough with hashes, but the README does not say how to skip it, for those who would rather move on instead. I suspect that all that needs to be done is to comment out the entire spec/bonus_spec.rb file.

Thank you for looking into this!

Sdcrouse

"Juliet" & other thoughts

I had a lot of fun with this! Yay. It was nice to be walked through the steps of building a nested data structure.

I noticed a few things:

  • "Juliet" is misspelled as "Juliette" throughout the lab, including the tests.
  • Ages are stored as strings, not as integers. Was this intentional?
  • The newer syntax key: value was not used in directions (:key => value), or in the lab, even though it does appear in the first example about instructors before the code along.

I totally want to copy this premise for a nested data lab in iOS.

@SophieDeBenedetto

Building Nested Hashes Lab - Friends is transposed for Romeo and Juliet

The Diagram has 2 friends for Romeo and 2 friends for Juliet.
Romeo's = Benvolio and Steven
Juliet's = Mercutio and Nurse

In the CODE ALONG CHALLENGE IV: NESTING FRIENDS AND ATTRIBUTES section it looks like Steven and Mercutio were transposed. In this section the 2 friends change in the text:
Romeo's = Benvolio and Mercutio
Juliet's = Steven and Nurse

The attributes are correct for Steven and Mercutio

Thanks!
image

Tests out of order

Tests for fourth challenge directly after first, then the second and third. Makes it a little weird to test using --fail-fast

not passing learn check

my nested hashes(hero_friends) are not completing the learn. It looks exactly like the follow along example but its saying "expecting end, unexpected ]"

Bonus rspec

Fun lab,

First time raising an issue so let me know if I'm doing it wrong...

The "Bonus Code Along Challenge" instructions say:

"Also! to enable these tests make sure to remove the x in front of the it block near the bottom."

There was no x and the test was running throughout the lab, not sure if the instructions should be deleted or the the RSPEC test should be disabled.

Thanks,
Schuyler

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.